----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/507/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Remove superfluous quote.
Diffs -----
README b6fa062d7fc5957e538d868b216aebf4f2403cd8 mof/LMI_Storage.reg 5a8b1404937aa1cd8e4233d48fe7f145440734da src/lmi/storage/BaseProvider.py b402e49cac75a0180d87f9bb2e3d66af9aaf576e src/lmi/storage/BasedOnProvider.py b9d44c6c2de03c0a5d2f9b666175c0a91338b5a9 src/lmi/storage/CapabilitiesProvider.py 3173bffdce873c5b85bdaa75ded85e13ed5b3be2 src/lmi/storage/DeviceProvider.py 115706bcaee6173c730c94aaee98f7745c57662f src/lmi/storage/ExtentProvider.py 370f47f84f984287c132b68bfe93ac778799a4a6 src/lmi/storage/FormatProvider.py c43ff5cfa5046126333555551ed6498ac8554785 src/lmi/storage/LMI_DataFormatProvider.py a964964f2612db3d2515bf82adcd723538679956 src/lmi/storage/LMI_DiskPartition.py 080e5eb2da1e1a90819ccc8eaca789c1a41fadb6 src/lmi/storage/LMI_DiskPartitionConfigurationCapabilities.py 20be6edec3d81fc1cc85311b287d0e20acd03f18 src/lmi/storage/LMI_DiskPartitionConfigurationSetting.py 6abb2486ba310e43fa88f989fa357f905fdedc95 src/lmi/storage/LMI_DiskPartitioningConfigurationService.py 50887eb51f667d017b755f901bbcacabdfd3ee73 src/lmi/storage/LMI_FileSystemConfigurationCapabilities.py 7be1f067b79dba29d83ccfe0c9c0b317dfa015f3 src/lmi/storage/LMI_FileSystemConfigurationService.py bcf03120e7030d8d6202e171145417bc79dc5476 src/lmi/storage/LMI_GenericDiskPartition.py 501308ed6a72967505378fab99c0bd1f11216fb4 src/lmi/storage/LMI_HostedFileSystem.py 0fd9a645a7d28712844aaf13c735e845344e12ac src/lmi/storage/LMI_HostedStorageService.py 3efc4e4cae69cd91351a409d134f7bf0c813e96d src/lmi/storage/LMI_InstalledPartitionTable.py 7275365a9ac785eeb651d29a452211f093bc8a56 src/lmi/storage/LMI_LVAllocatedFromStoragePool.py 820f2c3ca88ecdc807b0c65f0be8605ab918c203 src/lmi/storage/LMI_LVBasedOn.py 30c80d9aec6c5d4dba66d1c436918be6d9586aaf src/lmi/storage/LMI_LVStorageCapabilities.py 976c588ee06616c8b508df933e0874e46183ff96 src/lmi/storage/LMI_LVStorageExtent.py 9cb288f206867151f1b402af457fc40bba8e7d60 src/lmi/storage/LMI_LocalFileSystem.py 5e88077f7ef1070d9e7bd27fb54bc634d8ca6a8c src/lmi/storage/LMI_MDRAIDBasedOn.py 4372078363364d06c75e5ceb59605db148f33180 src/lmi/storage/LMI_MDRAIDFormatProvider.py f20678833d077260ab0045f140926e9892f905ae src/lmi/storage/LMI_MDRAIDStorageCapabilities.py c85b611f269379ebeaed858b50f7626bedc169f8 src/lmi/storage/LMI_MDRAIDStorageExtent.py 8a53e5c1092809c243af452919d9372054f92482 src/lmi/storage/LMI_PVFormatProvider.py 7b2d641c4252f3818b4ee5f780255124f2b7335c src/lmi/storage/LMI_PartitionBasedOn.py 2249a7b5602d6ab4b9e23ca8ea661ed677eda78f src/lmi/storage/LMI_StorageConfigurationService.py e7b321e901aa7c3a71dbb398826a4b654df91ea1 src/lmi/storage/LMI_StorageExtent.py ac266bf0efc7605db869336e05ede7e449812397 src/lmi/storage/LMI_SystemStorageDevice.py 1361589db5f287ec571b604c2d9962d7c3b600b6 src/lmi/storage/LMI_TransientFileSystem.py a28b66deab588121f3fb21b1f2f89aeed3e591cb src/lmi/storage/LMI_VGAssociatedComponentExtent.py 8091703cf7181b43096ed61578dd6feed1315d76 src/lmi/storage/LMI_VGStorageCapabilities.py 02c55233481e14c9ed3520b3d75a00afb2853910 src/lmi/storage/LMI_VGStoragePool.py 54c71984344caf0945e869e7c985a0b88941d2f8 src/lmi/storage/LocalFileSystemProvider.py e870d2865a96e20c3b0f4eb633a993c8efac9d06 src/lmi/storage/ProviderManager.py 37624eb7b9c38e063a7c1a969b308d12faaf1491 src/lmi/storage/ServiceProvider.py 1c8d200dcbdd583d36e8a25929411b2b7f335c26 src/lmi/storage/SettingHelper.py d023ed000b0257346788d0ed74af022297867ca3 src/lmi/storage/SettingManager.py 7b3665ebc3f25939d3b742a91b8547b496325773 src/lmi/storage/SettingProvider.py ea89efa934f425ee02c9a1fb2dee2b5bfef1c5a2 src/lmi/storage/StorageConfiguration.py 0f4d2d6dae1ac38e1c7d8dd06159cff858685729 src/lmi/storage/__init__.py 4b7e9e9076d9ffd06e8b7713fe888165811c7dd8 test/unit/config/test_unit_config.py 242433b87f26c606e42d11a45d27ede8ec56c8e9 test/unit/config/test_unit_settings.py aa7a20a21e2eaa33d77e934ec56b9af1aec7b76e test/unit/test_unit_logging.py 639f5d8290e6a9e8ac81939154ebebe5d6a06ecd
Diff: http://reviewboard-openlmi.rhcloud.com/r/507/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/507/#review612 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On July 3, 2013, 2:57 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/507/
(Updated July 3, 2013, 2:57 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Remove superfluous quote.
Diffs
README b6fa062d7fc5957e538d868b216aebf4f2403cd8 mof/LMI_Storage.reg 5a8b1404937aa1cd8e4233d48fe7f145440734da src/lmi/storage/BaseProvider.py b402e49cac75a0180d87f9bb2e3d66af9aaf576e src/lmi/storage/BasedOnProvider.py b9d44c6c2de03c0a5d2f9b666175c0a91338b5a9 src/lmi/storage/CapabilitiesProvider.py 3173bffdce873c5b85bdaa75ded85e13ed5b3be2 src/lmi/storage/DeviceProvider.py 115706bcaee6173c730c94aaee98f7745c57662f src/lmi/storage/ExtentProvider.py 370f47f84f984287c132b68bfe93ac778799a4a6 src/lmi/storage/FormatProvider.py c43ff5cfa5046126333555551ed6498ac8554785 src/lmi/storage/LMI_DataFormatProvider.py a964964f2612db3d2515bf82adcd723538679956 src/lmi/storage/LMI_DiskPartition.py 080e5eb2da1e1a90819ccc8eaca789c1a41fadb6 src/lmi/storage/LMI_DiskPartitionConfigurationCapabilities.py 20be6edec3d81fc1cc85311b287d0e20acd03f18 src/lmi/storage/LMI_DiskPartitionConfigurationSetting.py 6abb2486ba310e43fa88f989fa357f905fdedc95 src/lmi/storage/LMI_DiskPartitioningConfigurationService.py 50887eb51f667d017b755f901bbcacabdfd3ee73 src/lmi/storage/LMI_FileSystemConfigurationCapabilities.py 7be1f067b79dba29d83ccfe0c9c0b317dfa015f3 src/lmi/storage/LMI_FileSystemConfigurationService.py bcf03120e7030d8d6202e171145417bc79dc5476 src/lmi/storage/LMI_GenericDiskPartition.py 501308ed6a72967505378fab99c0bd1f11216fb4 src/lmi/storage/LMI_HostedFileSystem.py 0fd9a645a7d28712844aaf13c735e845344e12ac src/lmi/storage/LMI_HostedStorageService.py 3efc4e4cae69cd91351a409d134f7bf0c813e96d src/lmi/storage/LMI_InstalledPartitionTable.py 7275365a9ac785eeb651d29a452211f093bc8a56 src/lmi/storage/LMI_LVAllocatedFromStoragePool.py 820f2c3ca88ecdc807b0c65f0be8605ab918c203 src/lmi/storage/LMI_LVBasedOn.py 30c80d9aec6c5d4dba66d1c436918be6d9586aaf src/lmi/storage/LMI_LVStorageCapabilities.py 976c588ee06616c8b508df933e0874e46183ff96 src/lmi/storage/LMI_LVStorageExtent.py 9cb288f206867151f1b402af457fc40bba8e7d60 src/lmi/storage/LMI_LocalFileSystem.py 5e88077f7ef1070d9e7bd27fb54bc634d8ca6a8c src/lmi/storage/LMI_MDRAIDBasedOn.py 4372078363364d06c75e5ceb59605db148f33180 src/lmi/storage/LMI_MDRAIDFormatProvider.py f20678833d077260ab0045f140926e9892f905ae src/lmi/storage/LMI_MDRAIDStorageCapabilities.py c85b611f269379ebeaed858b50f7626bedc169f8 src/lmi/storage/LMI_MDRAIDStorageExtent.py 8a53e5c1092809c243af452919d9372054f92482 src/lmi/storage/LMI_PVFormatProvider.py 7b2d641c4252f3818b4ee5f780255124f2b7335c src/lmi/storage/LMI_PartitionBasedOn.py 2249a7b5602d6ab4b9e23ca8ea661ed677eda78f src/lmi/storage/LMI_StorageConfigurationService.py e7b321e901aa7c3a71dbb398826a4b654df91ea1 src/lmi/storage/LMI_StorageExtent.py ac266bf0efc7605db869336e05ede7e449812397 src/lmi/storage/LMI_SystemStorageDevice.py 1361589db5f287ec571b604c2d9962d7c3b600b6 src/lmi/storage/LMI_TransientFileSystem.py a28b66deab588121f3fb21b1f2f89aeed3e591cb src/lmi/storage/LMI_VGAssociatedComponentExtent.py 8091703cf7181b43096ed61578dd6feed1315d76 src/lmi/storage/LMI_VGStorageCapabilities.py 02c55233481e14c9ed3520b3d75a00afb2853910 src/lmi/storage/LMI_VGStoragePool.py 54c71984344caf0945e869e7c985a0b88941d2f8 src/lmi/storage/LocalFileSystemProvider.py e870d2865a96e20c3b0f4eb633a993c8efac9d06 src/lmi/storage/ProviderManager.py 37624eb7b9c38e063a7c1a969b308d12faaf1491 src/lmi/storage/ServiceProvider.py 1c8d200dcbdd583d36e8a25929411b2b7f335c26 src/lmi/storage/SettingHelper.py d023ed000b0257346788d0ed74af022297867ca3 src/lmi/storage/SettingManager.py 7b3665ebc3f25939d3b742a91b8547b496325773 src/lmi/storage/SettingProvider.py ea89efa934f425ee02c9a1fb2dee2b5bfef1c5a2 src/lmi/storage/StorageConfiguration.py 0f4d2d6dae1ac38e1c7d8dd06159cff858685729 src/lmi/storage/__init__.py 4b7e9e9076d9ffd06e8b7713fe888165811c7dd8 test/unit/config/test_unit_config.py 242433b87f26c606e42d11a45d27ede8ec56c8e9 test/unit/config/test_unit_settings.py aa7a20a21e2eaa33d77e934ec56b9af1aec7b76e test/unit/test_unit_logging.py 639f5d8290e6a9e8ac81939154ebebe5d6a06ecd
Diff: http://reviewboard-openlmi.rhcloud.com/r/507/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/507/ -----------------------------------------------------------
(Updated July 10, 2013, 2:48 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Remove superfluous quote.
Diffs -----
README b6fa062d7fc5957e538d868b216aebf4f2403cd8 mof/LMI_Storage.reg 5a8b1404937aa1cd8e4233d48fe7f145440734da src/lmi/storage/BaseProvider.py b402e49cac75a0180d87f9bb2e3d66af9aaf576e src/lmi/storage/BasedOnProvider.py b9d44c6c2de03c0a5d2f9b666175c0a91338b5a9 src/lmi/storage/CapabilitiesProvider.py 3173bffdce873c5b85bdaa75ded85e13ed5b3be2 src/lmi/storage/DeviceProvider.py 115706bcaee6173c730c94aaee98f7745c57662f src/lmi/storage/ExtentProvider.py 370f47f84f984287c132b68bfe93ac778799a4a6 src/lmi/storage/FormatProvider.py c43ff5cfa5046126333555551ed6498ac8554785 src/lmi/storage/LMI_DataFormatProvider.py a964964f2612db3d2515bf82adcd723538679956 src/lmi/storage/LMI_DiskPartition.py 080e5eb2da1e1a90819ccc8eaca789c1a41fadb6 src/lmi/storage/LMI_DiskPartitionConfigurationCapabilities.py 20be6edec3d81fc1cc85311b287d0e20acd03f18 src/lmi/storage/LMI_DiskPartitionConfigurationSetting.py 6abb2486ba310e43fa88f989fa357f905fdedc95 src/lmi/storage/LMI_DiskPartitioningConfigurationService.py 50887eb51f667d017b755f901bbcacabdfd3ee73 src/lmi/storage/LMI_FileSystemConfigurationCapabilities.py 7be1f067b79dba29d83ccfe0c9c0b317dfa015f3 src/lmi/storage/LMI_FileSystemConfigurationService.py bcf03120e7030d8d6202e171145417bc79dc5476 src/lmi/storage/LMI_GenericDiskPartition.py 501308ed6a72967505378fab99c0bd1f11216fb4 src/lmi/storage/LMI_HostedFileSystem.py 0fd9a645a7d28712844aaf13c735e845344e12ac src/lmi/storage/LMI_HostedStorageService.py 3efc4e4cae69cd91351a409d134f7bf0c813e96d src/lmi/storage/LMI_InstalledPartitionTable.py 7275365a9ac785eeb651d29a452211f093bc8a56 src/lmi/storage/LMI_LVAllocatedFromStoragePool.py 820f2c3ca88ecdc807b0c65f0be8605ab918c203 src/lmi/storage/LMI_LVBasedOn.py 30c80d9aec6c5d4dba66d1c436918be6d9586aaf src/lmi/storage/LMI_LVStorageCapabilities.py 976c588ee06616c8b508df933e0874e46183ff96 src/lmi/storage/LMI_LVStorageExtent.py 9cb288f206867151f1b402af457fc40bba8e7d60 src/lmi/storage/LMI_LocalFileSystem.py 5e88077f7ef1070d9e7bd27fb54bc634d8ca6a8c src/lmi/storage/LMI_MDRAIDBasedOn.py 4372078363364d06c75e5ceb59605db148f33180 src/lmi/storage/LMI_MDRAIDFormatProvider.py f20678833d077260ab0045f140926e9892f905ae src/lmi/storage/LMI_MDRAIDStorageCapabilities.py c85b611f269379ebeaed858b50f7626bedc169f8 src/lmi/storage/LMI_MDRAIDStorageExtent.py 8a53e5c1092809c243af452919d9372054f92482 src/lmi/storage/LMI_PVFormatProvider.py 7b2d641c4252f3818b4ee5f780255124f2b7335c src/lmi/storage/LMI_PartitionBasedOn.py 2249a7b5602d6ab4b9e23ca8ea661ed677eda78f src/lmi/storage/LMI_StorageConfigurationService.py e7b321e901aa7c3a71dbb398826a4b654df91ea1 src/lmi/storage/LMI_StorageExtent.py ac266bf0efc7605db869336e05ede7e449812397 src/lmi/storage/LMI_SystemStorageDevice.py 1361589db5f287ec571b604c2d9962d7c3b600b6 src/lmi/storage/LMI_TransientFileSystem.py a28b66deab588121f3fb21b1f2f89aeed3e591cb src/lmi/storage/LMI_VGAssociatedComponentExtent.py 8091703cf7181b43096ed61578dd6feed1315d76 src/lmi/storage/LMI_VGStorageCapabilities.py 02c55233481e14c9ed3520b3d75a00afb2853910 src/lmi/storage/LMI_VGStoragePool.py 54c71984344caf0945e869e7c985a0b88941d2f8 src/lmi/storage/LocalFileSystemProvider.py e870d2865a96e20c3b0f4eb633a993c8efac9d06 src/lmi/storage/ProviderManager.py 37624eb7b9c38e063a7c1a969b308d12faaf1491 src/lmi/storage/ServiceProvider.py 1c8d200dcbdd583d36e8a25929411b2b7f335c26 src/lmi/storage/SettingHelper.py d023ed000b0257346788d0ed74af022297867ca3 src/lmi/storage/SettingManager.py 7b3665ebc3f25939d3b742a91b8547b496325773 src/lmi/storage/SettingProvider.py ea89efa934f425ee02c9a1fb2dee2b5bfef1c5a2 src/lmi/storage/StorageConfiguration.py 0f4d2d6dae1ac38e1c7d8dd06159cff858685729 src/lmi/storage/__init__.py 4b7e9e9076d9ffd06e8b7713fe888165811c7dd8 test/unit/config/test_unit_config.py 242433b87f26c606e42d11a45d27ede8ec56c8e9 test/unit/config/test_unit_settings.py aa7a20a21e2eaa33d77e934ec56b9af1aec7b76e test/unit/test_unit_logging.py 639f5d8290e6a9e8ac81939154ebebe5d6a06ecd
Diff: http://reviewboard-openlmi.rhcloud.com/r/507/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org