Review Request 1980: lmishell, fix compat indication listener

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-tools


Description
-------

Fix indication delivery when using compat listener. The problem was caused by wrong prefix
prefix present in the indication name.


Diffs
-----

  cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
  cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/


Testing
-------

Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)


Thanks,

Peter Hatina

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/#review3251
-----------------------------------------------------------

Ship it!


Ship It!

- Peter Schiffer


On Aug. 27, 2014, 3:01 p.m., Peter Hatina wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1980/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 27, 2014, 3:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-tools
>  
>  
>  Description
>  -------
>  
>  Fix indication delivery when using compat listener. The problem was caused by wrong
> prefix prefix present in the indication name.
>  
>  
>  Diffs
>  -----
>  
>    cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
>    cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab
>
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/
>  
>  
>  Testing
>  -------
>  
>  Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)
>  
>  
>  Thanks,
>  
>  Peter Hatina
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/#review3252
-----------------------------------------------------------



cli/lmi/shell/compat/CIMIndicationListener.py
<http://reviewboard-openlmi.rhcloud.com/r/1980/#comment1794>

    whole "if" clause could be replaced with
    
        path = path.lstrip('/')
    
    which would also catch multiple slashes


- Alois Mahdal


On Aug. 27, 2014, 3:01 p.m., Peter Hatina wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1980/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 27, 2014, 3:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-tools
>  
>  
>  Description
>  -------
>  
>  Fix indication delivery when using compat listener. The problem was caused by wrong
> prefix prefix present in the indication name.
>  
>  
>  Diffs
>  -----
>  
>    cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
>    cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab
>
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/
>  
>  
>  Testing
>  -------
>  
>  Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)
>  
>  
>  Thanks,
>  
>  Peter Hatina
>  
>

[Stephen Gallagher]

>  On Aug. 28, 2014, 1:20 p.m., Alois Mahdal wrote:
>  > cli/lmi/shell/compat/CIMIndicationListener.py, line 107
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1980/diff/1/?file=11559#file1155...
>  >
>  >     whole "if" clause could be replaced with
>  >     
>  >         path = path.lstrip('/')
>  >     
>  >     which would also catch multiple slashes 
I want to strip only the first symbol. What if someone wants to name the indication (and
url resp.) as "/something"?

The url of delivered indication is prefixed by additional slash, which leads to
"//something" and is obviously wrong.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/#review3252
-----------------------------------------------------------


On Aug. 27, 2014, 1:01 p.m., Peter Hatina wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1980/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 27, 2014, 1:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-tools
>  
>  
>  Description
>  -------
>  
>  Fix indication delivery when using compat listener. The problem was caused by wrong
> prefix prefix present in the indication name.
>  
>  
>  Diffs
>  -----
>  
>    cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
>    cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab
>
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/
>  
>  
>  Testing
>  -------
>  
>  Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)
>  
>  
>  Thanks,
>  
>  Peter Hatina
>  
>

[Stephen Gallagher]

>  On Aug. 28, 2014, 3:20 p.m., Alois Mahdal wrote:
>  > cli/lmi/shell/compat/CIMIndicationListener.py, line 107
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1980/diff/1/?file=11559#file1155...
>  >
>  >     whole "if" clause could be replaced with
>  >     
>  >         path = path.lstrip('/')
>  >     
>  >     which would also catch multiple slashes
>  
>  Peter Hatina wrote:
>      I want to strip only the first symbol. What if someone wants to name the indication
> (and url resp.) as "/something"?
>      
>      The url of delivered indication is prefixed by additional slash, which leads to
> "//something" and is obviously wrong. 
OK, then please ignore the comment; I was confused by the comment *Indication names
aren't prefixed by slash. Drop it.* --- I (mis)interpreted it as if slashes at start
of indication name are somehow illegal but can be stripped safely (and the code assumes
only one to be there).

(Maybe the comment could be clarified?)


- Alois


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/#review3252
-----------------------------------------------------------


On Aug. 28, 2014, 3:33 p.m., Peter Hatina wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1980/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 28, 2014, 3:33 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-tools
>  
>  
>  Description
>  -------
>  
>  Fix indication delivery when using compat listener. The problem was caused by wrong
> prefix prefix present in the indication name.
>  
>  
>  Diffs
>  -----
>  
>    cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
>    cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab
>
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/
>  
>  
>  Testing
>  -------
>  
>  Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)
>  
>  nosetests -v TestIndicationEventStream.py: all tests passed.
>  
>  
>  Thanks,
>  
>  Peter Hatina
>  
>

[Stephen Gallagher]

>  On Aug. 28, 2014, 1:20 p.m., Alois Mahdal wrote:
>  > cli/lmi/shell/compat/CIMIndicationListener.py, line 107
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1980/diff/1/?file=11559#file1155...
>  >
>  >     whole "if" clause could be replaced with
>  >     
>  >         path = path.lstrip('/')
>  >     
>  >     which would also catch multiple slashes
>  
>  Peter Hatina wrote:
>      I want to strip only the first symbol. What if someone wants to name the indication
> (and url resp.) as "/something"?
>      
>      The url of delivered indication is prefixed by additional slash, which leads to
> "//something" and is obviously wrong.
>  
>  Alois Mahdal wrote:
>      OK, then please ignore the comment; I was confused by the comment *Indication names
> aren't prefixed by slash. Drop it.* --- I (mis)interpreted it as if slashes at start
> of indication name are somehow illegal but can be stripped safely (and the code assumes
> only one to be there).
>      
>      (Maybe the comment could be clarified?) 
I will update the comment. Thank you.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/#review3252
-----------------------------------------------------------


On Aug. 28, 2014, 1:33 p.m., Peter Hatina wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1980/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 28, 2014, 1:33 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-tools
>  
>  
>  Description
>  -------
>  
>  Fix indication delivery when using compat listener. The problem was caused by wrong
> prefix prefix present in the indication name.
>  
>  
>  Diffs
>  -----
>  
>    cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
>    cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab
>
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/
>  
>  
>  Testing
>  -------
>  
>  Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)
>  
>  nosetests -v TestIndicationEventStream.py: all tests passed.
>  
>  
>  Thanks,
>  
>  Peter Hatina
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/
-----------------------------------------------------------

(Updated Aug. 28, 2014, 1:33 p.m.)


Review request for OpenLMI Developers.


Changes
-------

Added results of TestIndicationEventStream test.


Repository: openlmi-tools


Description
-------

Fix indication delivery when using compat listener. The problem was caused by wrong prefix
prefix present in the indication name.


Diffs
-----

  cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
  cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/


Testing (updated)
-------

Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)

nosetests -v TestIndicationEventStream.py: all tests passed.


Thanks,

Peter Hatina

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/
-----------------------------------------------------------

(Updated Aug. 29, 2014, 1:13 p.m.)


Review request for OpenLMI Developers.


Changes
-------

Updated the behavior of compat CIMIndicationListener.


Repository: openlmi-tools


Description
-------

Fix indication delivery when using compat listener. The problem was caused by wrong prefix
prefix present in the indication name.


Diffs (updated)
-----

  cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
  cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/


Testing (updated)
-------

Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)

nosetests -v TestIndicationEventStream.py: all tests passed.

Indication with URL of:
"////CIMListener////xxxxxxxxxx////CIMListener/CIMListener/foo/test"
References callback of: "///xxxxxxxxxx////CIMListener/CIMListener/foo/test"
This works well when using LMIWBEM, or PyWBEM.


Thanks,

Peter Hatina

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1980/
-----------------------------------------------------------

(Updated Sept. 1, 2014, 9:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-tools


Description
-------

Fix indication delivery when using compat listener. The problem was caused by wrong prefix
prefix present in the indication name.


Diffs
-----

  cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17 
  cli/lmi/shell/compat/CIMIndicationListener.py 6b8a2d18a5594925942ce79e282879f0e35f35ab 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1980/diff/


Testing
-------

Tested using LMI_FileSystemConfigurationService.SyncLMI_CreateFileSystem(...)

nosetests -v TestIndicationEventStream.py: all tests passed.

Indication with URL of:
"////CIMListener////xxxxxxxxxx////CIMListener/CIMListener/foo/test"
References callback of: "///xxxxxxxxxx////CIMListener/CIMListener/foo/test"
This works well when using LMIWBEM, or PyWBEM.


Thanks,

Peter Hatina