----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
test_enum_instance_names is run before test_enum_instances - so move the package definition there
skip one unrelated test for package-kit
fixed default value of DB_CACHE variable
Diffs -----
src/software/test/test_member_of_software_collection.py 1c4e75d1fdf2d617be6af400d72af63326c0d9cb src/software/test/util.py 09fa0518450a87853e84a4777ded601b4a980b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/1962/diff/
Testing -------
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/#review3229 -----------------------------------------------------------
src/software/test/test_member_of_software_collection.py http://reviewboard-openlmi.rhcloud.com/r/1962/#comment1789
Test order is random. On different machines the order varies. I'd rather copy the lines instead of move. If those tests are run sequentially one after the other, it should be quick no-op.
src/software/test/test_member_of_software_collection.py http://reviewboard-openlmi.rhcloud.com/r/1962/#comment1790
I'd like to have associators cover by our test suite. If installed packages cause problems, I'd just make sure they are uninstalled before this test begins.
- Michal Minar
On Srp. 19, 2014, 12:59 odp., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/
(Updated Srp. 19, 2014, 12:59 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
test_enum_instance_names is run before test_enum_instances - so move the package definition there
skip one unrelated test for package-kit
fixed default value of DB_CACHE variable
Diffs
src/software/test/test_member_of_software_collection.py 1c4e75d1fdf2d617be6af400d72af63326c0d9cb src/software/test/util.py 09fa0518450a87853e84a4777ded601b4a980b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/1962/diff/
Testing
Thanks,
Peter Schiffer
On Aug. 20, 2014, 12:29 p.m., Michal Minar wrote:
src/software/test/test_member_of_software_collection.py, lines 124-129 http://reviewboard-openlmi.rhcloud.com/r/1962/diff/1/?file=11489#file11489line124
Test order is random. On different machines the order varies. I'd rather copy the lines instead of move. If those tests are run sequentially one after the other, it should be quick no-op.
I reverted this change.
On Aug. 20, 2014, 12:29 p.m., Michal Minar wrote:
src/software/test/test_member_of_software_collection.py, line 237 http://reviewboard-openlmi.rhcloud.com/r/1962/diff/1/?file=11489#file11489line237
I'd like to have associators cover by our test suite. If installed packages cause problems, I'd just make sure they are uninstalled before this test begins.
associator_names method is supported and tested, but associators methos is not supported in dbus version of sw provider, therefore it has to be skipped
- Peter
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/#review3229 -----------------------------------------------------------
On Aug. 20, 2014, 3:13 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/
(Updated Aug. 20, 2014, 3:13 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
skip one unrelated test for package-kit
fixed default value of DB_CACHE variable
Diffs
src/software/test/test_member_of_software_collection.py 1c4e75d1fdf2d617be6af400d72af63326c0d9cb src/software/test/util.py 09fa0518450a87853e84a4777ded601b4a980b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/1962/diff/
Testing
Thanks,
Peter Schiffer
On Srp. 20, 2014, 10:29 dop., Michal Minar wrote:
src/software/test/test_member_of_software_collection.py, line 237 http://reviewboard-openlmi.rhcloud.com/r/1962/diff/1/?file=11489#file11489line237
I'd like to have associators cover by our test suite. If installed packages cause problems, I'd just make sure they are uninstalled before this test begins.Peter Schiffer wrote: associator_names method is supported and tested, but associators methos is not supported in dbus version of sw provider, therefore it has to be skipped
You are right, thanks for reminding :).
- Michal
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/#review3229 -----------------------------------------------------------
On Srp. 20, 2014, 1:13 odp., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/
(Updated Srp. 20, 2014, 1:13 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
skip one unrelated test for package-kit
fixed default value of DB_CACHE variable
Diffs
src/software/test/test_member_of_software_collection.py 1c4e75d1fdf2d617be6af400d72af63326c0d9cb src/software/test/util.py 09fa0518450a87853e84a4777ded601b4a980b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/1962/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/ -----------------------------------------------------------
(Updated Aug. 20, 2014, 3:13 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description (updated) -------
skip one unrelated test for package-kit
fixed default value of DB_CACHE variable
Diffs (updated) -----
src/software/test/test_member_of_software_collection.py 1c4e75d1fdf2d617be6af400d72af63326c0d9cb src/software/test/util.py 09fa0518450a87853e84a4777ded601b4a980b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/1962/diff/
Testing -------
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/#review3237 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Srp. 20, 2014, 1:13 odp., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/
(Updated Srp. 20, 2014, 1:13 odp.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
skip one unrelated test for package-kit
fixed default value of DB_CACHE variable
Diffs
src/software/test/test_member_of_software_collection.py 1c4e75d1fdf2d617be6af400d72af63326c0d9cb src/software/test/util.py 09fa0518450a87853e84a4777ded601b4a980b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/1962/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1962/ -----------------------------------------------------------
(Updated Aug. 20, 2014, 4:10 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
skip one unrelated test for package-kit
fixed default value of DB_CACHE variable
Diffs -----
src/software/test/test_member_of_software_collection.py 1c4e75d1fdf2d617be6af400d72af63326c0d9cb src/software/test/util.py 09fa0518450a87853e84a4777ded601b4a980b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/1962/diff/
Testing -------
Thanks,
Peter Schiffer
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher