Review Request 1293: account: Free private indication data after indications are stopped

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1293/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

account: Free private indication data after indications are stopped

...to prevent race of the watcher thread still using data that has been
freed just a moment ago.


Diffs
-----

  src/account/LMI_AccountInstanceCreationIndicationProvider.c
989eaaec3630c72c01494e1407bfbd49bb6f55f3 
  src/account/LMI_AccountInstanceDeletionIndicationProvider.c
ee86e6efba3cd72580180912fb9ef60a04a5c06a 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1293/diff/


Testing
-------


Thanks,

Tomáš Bžatek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1293/#review1801
-----------------------------------------------------------


Autoscan started for review(s) 1293

- scanbot


On Nov. 26, 2013, 2 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1293/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 26, 2013, 2 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  account: Free private indication data after indications are stopped
>  
>  ...to prevent race of the watcher thread still using data that has been
>  freed just a moment ago.
>  
>  
>  Diffs
>  -----
>  
>    src/account/LMI_AccountInstanceCreationIndicationProvider.c
> 989eaaec3630c72c01494e1407bfbd49bb6f55f3 
>    src/account/LMI_AccountInstanceDeletionIndicationProvider.c
> ee86e6efba3cd72580180912fb9ef60a04a5c06a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1293/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1293/#review1806
-----------------------------------------------------------


Autoscan finished OK

Scanned reviews: 1293

- scanbot


On Nov. 26, 2013, 2 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1293/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 26, 2013, 2 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  account: Free private indication data after indications are stopped
>  
>  ...to prevent race of the watcher thread still using data that has been
>  freed just a moment ago.
>  
>  
>  Diffs
>  -----
>  
>    src/account/LMI_AccountInstanceCreationIndicationProvider.c
> 989eaaec3630c72c01494e1407bfbd49bb6f55f3 
>    src/account/LMI_AccountInstanceDeletionIndicationProvider.c
> ee86e6efba3cd72580180912fb9ef60a04a5c06a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1293/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1293/#review1814
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On Nov. 26, 2013, 3 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1293/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 26, 2013, 3 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  account: Free private indication data after indications are stopped
>  
>  ...to prevent race of the watcher thread still using data that has been
>  freed just a moment ago.
>  
>  
>  Diffs
>  -----
>  
>    src/account/LMI_AccountInstanceCreationIndicationProvider.c
> 989eaaec3630c72c01494e1407bfbd49bb6f55f3 
>    src/account/LMI_AccountInstanceDeletionIndicationProvider.c
> ee86e6efba3cd72580180912fb9ef60a04a5c06a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1293/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1293/
-----------------------------------------------------------

(Updated Nov. 28, 2013, 11:15 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

account: Free private indication data after indications are stopped

...to prevent race of the watcher thread still using data that has been
freed just a moment ago.


Diffs
-----

  src/account/LMI_AccountInstanceCreationIndicationProvider.c
989eaaec3630c72c01494e1407bfbd49bb6f55f3 
  src/account/LMI_AccountInstanceDeletionIndicationProvider.c
ee86e6efba3cd72580180912fb9ef60a04a5c06a 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1293/diff/


Testing
-------


Thanks,

Tomáš Bžatek