Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739347
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #1 from Jussi Lehtola jussi.lehtola@iki.fi 2011-09-21 02:55:59 EDT --- Patch0 doesn't have a comment in the spec file. Please document what it does.
Is there any reason why you macroize everything? Why not run just automake, make and so on?
Is SMP build not supported?
Please use cp or install instead of mv in %install, so that shortcutting builds work. Besides, why do you %{__mv} init.d/haveged_fedora %{buildroot}%{_initrddir}/haveged %{__rm} -rf %{buildroot}/etc/init.d since at least on F15 $ rpm --eval %{_initrddir} /etc/rc.d/init.d $ file /etc/init.d /etc/init.d: symbolic link to `rc.d/init.d'