Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: eclipse-phpeclipse
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205
------- Additional Comments From green@redhat.com 2006-09-09 00:27 EST ------- Let's look at the rpmlint output:
E: eclipse-phpeclipse description-line-too-long The PHPeclipse plugin allows developers to write PHP webpages and scripts in Eclipse.
I've never seen this before. Should be easy to fix.
W: eclipse-phpeclipse non-standard-group Text Editors/Integrated Development Environments (IDE)
Please use Development/Tools.
W: eclipse-phpeclipse incoherent-version-in-changelog 1.1.8-6 1.1.8-7
This must be a typo.
W: eclipse-phpeclipse invalid-license Common Public License (CPL) 1.0
Please just use "CPL".
W: eclipse-phpeclipse no-documentation
At a minimum, please add the license text as a %doc in the %files section.
W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.classpath W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.phphelp_1.1.8/.classpath W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.project W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.template W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.classpath W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.ui_1.1.8/.template W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.project W: eclipse-phpeclipse hidden-file-or-dir /usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.template
I've never seen these before. Can we delete them, or are they important?
W: eclipse-phpeclipse one-line-command-in-%post /usr/bin/rebuild-gcj-db W: eclipse-phpeclipse one-line-command-in-%postun /usr/bin/rebuild-gcj-db
Use single lines like this instead: %post -p %{_bindir}/rebuild-gcj-db
The rest are from the SRPM....
E: eclipse-phpeclipse description-line-too-long The PHPeclipse plugin allows developers to write PHP webpages and scripts in Eclipse. W: eclipse-phpeclipse non-standard-group Text Editors/Integrated Development Environments (IDE) W: eclipse-phpeclipse invalid-license Common Public License (CPL) 1.0
All as above.
W: eclipse-phpeclipse mixed-use-of-spaces-and-tabs
I just use the emacs untabify command for this.