https://bugzilla.redhat.com/show_bug.cgi?id=1539116
Iwicki Artur fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #5 from Iwicki Artur fedora@svgames.pl ---
Group: Applications/Engineering
The "Group:" tag is not used in Fedora.
# EPEL7 fails on url tag, so we ignore failure: appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/*.appdata.xml || echo "Ignoring appstream-util failure"
What exactly is the error here? Could we patch the appdata file so the validation doesn't fail?
%post /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun if [ $1 -eq 0 ] ; then /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : fi
%posttrans /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
The icon cache scriplets are no longer used in Fedora. These should be made EPEL-only.
Another minor issue I can see is the mixed use of $RPM_BUILD_ROOT and %buildroot. It is preferred to pick one and stick with it.