[Bug 1539116] New: Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

            Bug ID: 1539116
           Summary: Review Request: grass - GRASS GIS - Geographic
                    Resources Analysis Support System
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: neteler(a)gmail.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org



Spec URL:
https://trac.osgeo.org/grass/browser/grass/branches/releasebranch_7_4/rpm...
SRPM URL: http://data.neteler.org/tmp/grass-7.4.0-1.fc27.src.rpm
Description: New upstream version GRASS GIS 7.4.0. The SPEC file received a
cleanup and also addresses latest FTBS issues.
Fedora Account System Username: neteler

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #1 from markusN <neteler(a)gmail.com&gt; ---
I have made a minor update (included as a patch), now it also compiles on
EPEL7:

http://data.neteler.org/tmp/grass-7.4.0-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Antonio Trande <anto.trande(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.trande(a)gmail.com



--- Comment #2 from Antonio Trande <anto.trande(a)gmail.com&gt; ---
Are you sponsored?
fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #3 from markusN <neteler(a)gmail.com&gt; ---
No, I am not sponsored so far. My goal is to get this update of GRASS GIS into
Fedora which addresses most (all?) of the open bugs:

https://bugzilla.redhat.com/buglist.cgi?component=grass&list_id=83481...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Antonio Trande <anto.trande(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #4 from Antonio Trande <anto.trande(a)gmail.com&gt; ---
- Fix dependencies between packages:

%{name}%{?isa}-libs = %{version}-%{release} becomes
%{name}-libs%{?_isa} = %{version}-%{release}

or

%{name}%{?isa} = %{version}-%{release} becomes
%{name}%{?_isa} = %{version}-%{release}

- '-gui' sub-package already gets 'grass-libs' through 'grass';
line #110 can
be removed.

- appdata.xml files go into '/usr/share/metainfo'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Iwicki Artur <fedora(a)svgames.pl&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora(a)svgames.pl



--- Comment #5 from Iwicki Artur <fedora(a)svgames.pl&gt; ---
> Group: Applications/Engineering 
The "Group:" tag is
not used in Fedora.

> # EPEL7 fails on url tag, so we ignore failure:
> appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/*.appdata.xml ||
> echo "Ignoring appstream-util failure" 
What exactly is the error here?
Could we patch the appdata file so the
validation doesn't fail?

> %post
> /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
>
> %postun
> if [ $1 -eq 0 ] ; then
> 	/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
> 	/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> fi
>
> %posttrans
> /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : 
The
icon cache scriplets are no longer used in Fedora. These should be made
EPEL-only.

Another minor issue I can see is the mixed use of $RPM_BUILD_ROOT and
%buildroot. It is preferred to pick one and stick with it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #6 from markusN <neteler(a)gmail.com&gt; ---
Thanks to both for the quick review.

(In reply to Iwicki Artur from comment #5)
>  >Group: Applications/Engineering
>  The "Group:" tag is not used in Fedora.
>  
>  ># EPEL7 fails on url tag, so we ignore failure:
>  >appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/*.appdata.xml
> || echo "Ignoring appstream-util failure"
>
>  What exactly is the error here? 
This one:

appstream-util validate-relax --nonet
/builddir/build/BUILDROOT/grass-7.4.0-2.el7.centos.x86_64//usr/share/appdata/grass.appdata.xml
/builddir/build/BUILDROOT/grass-7.4.0-2.el7.centos.x86_64//usr/share/appdata/grass.appdata.xml:
GLib-GIO-Message: Using the 'memory' GSettings backend.  Your settings will not
be saved or shared with other applications.
FAILED:
? markup-invalid        : <id> does not have correct extension for kind
Validation of files failed

>  Could we patch the appdata file so the validation doesn't fail?
The "offending" line is this one:

  <id>org.osgeo.grass</id>

Does it need to be
  <id>org.osgeo.grass.desktop</id>
?

>  >%post
>  >/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
>  >
>  >%postun
>  >if [ $1 -eq 0 ] ; then
>  >	/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
>  >	/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
>  >fi
>  >
>  >%posttrans
>  >/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
>  The icon cache scriplets are no longer used in Fedora. These should be made
>  EPEL-only.
>  
>  Another minor issue I can see is the mixed use of $RPM_BUILD_ROOT and
>  %buildroot. It is preferred to pick one and stick with it. 
OK, thanks. I am now testing with an updated SPEC file which includes fixes as
per comment 4.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #7 from Iwicki Artur <fedora(a)svgames.pl&gt; ---
I compared this with a couple of appdata files I have installed on my system
and yes, it seems that the value of the "<id>" tag should end with
".desktop".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #8 from markusN <neteler(a)gmail.com&gt; ---
(In reply to Iwicki Artur from comment #7)
>  I compared this with a couple of appdata files I have installed on my
> system
>  and yes, it seems that the value of the "<id>" tag should end with
>  ".desktop". 
OK, fixed upstream (will then ship with the future GRASS GIS 7.4.1).

The two $RPM_BUILD_ROOT entries needed and not the same as %buildroot
(compilation fails when changing them to %buildroot), so I left them as-is.

All other suggestions are included (new SPEC attached) and compile successfully
on EPEL7 and Fedora:
https://copr.fedorainfracloud.org/coprs/neteler/grass74/build/706613/

Thanks again for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #9 from markusN <neteler(a)gmail.com&gt; ---
Created attachment 1387344
  --> https://bugzilla.redhat.com/attachment.cgi?id=1387344&action=edit
Updated SPEC file for GRASS GIS 7.4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #10 from Antonio Trande <anto.trande(a)gmail.com&gt; ---
Please, post direct links to newest SPEC and SRPM (like
https://copr-be.cloud.fedoraproject.org/results/neteler/grass74/fedora-27...,
we need them for using 'fedora-review' tool)

Explicate all changes in Changelog
(http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs).

This is not correct:

* Sun Jan 28 2018 Markus Neteler <neteler(a)mundialis.de&gt; - 7.4.0-2
- SPEC cleanup as per review in
https://bugzilla.redhat.com/show_bug.cgi?id=1539116

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Peter Lemenkov <lemenkov(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lemenkov(a)gmail.com
             Blocks|177841 (FE-NEEDSPONSOR)     |



--- Comment #11 from Peter Lemenkov <lemenkov(a)gmail.com&gt; ---
Hello Marcus,
Nice to see you there! Certainly Fedora RPM package for GRASS will benefit from
your participation.

I'm going to remove FE-NEEDSPONSOR - I've just sponsored Marcus Neteler.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Peter Lemenkov <lemenkov(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |devrim(a)gunduz.org
              Flags|                            |needinfo?(devrim(a)gunduz.org
                   |                            |)



--- Comment #12 from Peter Lemenkov <lemenkov(a)gmail.com&gt; ---
Devrim, could you please add Markus as a comaintainer?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #13 from markusN <neteler(a)gmail.com&gt; ---
(In reply to Antonio Trande from comment #10)
>  Please, post direct links to newest SPEC and SRPM (like
>  https://copr-be.cloud.fedoraproject.org/results/neteler/grass74/fedora-27-
>  x86_64/00706613-grass/grass.spec, we need them for using 'fedora-review'
>  tool)
>  
>  Explicate all changes in Changelog
>  (http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs).
>  
>  This is not correct:
>  
>  * Sun Jan 28 2018 Markus Neteler <neteler(a)mundialis.de&gt; - 7.4.0-2
>  - SPEC cleanup as per review in
>  https://bugzilla.redhat.com/show_bug.cgi?id=1539116 

Thanks, Antonio, will update accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #14 from markusN <neteler(a)gmail.com&gt; ---
(In reply to Peter Lemenkov from comment #11)
>  Hello Marcus,
>  Nice to see you there! Certainly Fedora RPM package for GRASS will benefit
>  from your participation.
>  
>  I'm going to remove FE-NEEDSPONSOR - I've just sponsored Marcus Neteler. 
Thanks a lot for your support, Peter.

As requested in Comment 10, I expanded the Changelog section in the SPEC file
which is here:

https://copr-be.cloud.fedoraproject.org/results/neteler/grass74/fedora-27...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

https://bugzilla.redhat.com/show_bug.cgi?id=1539116

Peter Lemenkov <lemenkov(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |CURRENTRELEASE
              Flags|needinfo?(devrim(a)gunduz.org |
                   |)                           |
        Last Closed|                            |2018-08-15 06:41:09



--- Comment #15 from Peter Lemenkov <lemenkov(a)gmail.com&gt; ---
(In reply to markusN from comment #14)
>  (In reply to Peter Lemenkov from comment #11)
>  > Hello Marcus,
>  > Nice to see you there! Certainly Fedora RPM package for GRASS will benefit
>  > from your participation.
>  > 
>  > I'm going to remove FE-NEEDSPONSOR - I've just sponsored Marcus Neteler.
>  
>  Thanks a lot for your support, Peter.
>  
>  As requested in Comment 10, I expanded the Changelog section in the SPEC
>  file which is here:
>  
>  https://copr-be.cloud.fedoraproject.org/results/neteler/grass74/fedora-27-
>  x86_64/00707314-grass/grass.spec 
Ok, everything was imported and built, so I'm going to close this ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component