[Bug 1613654] New: Review Request: erlang-bbmustache - Binary pattern match based Mustache template engine for erlang

https://bugzilla.redhat.com/show_bug.cgi?id=1613654

            Bug ID: 1613654
           Summary: Review Request: erlang-bbmustache - Binary pattern
                    match based Mustache template engine for erlang
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: timothee.floure(a)fnux.ch
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/cgit/fnux/public_git/rpm-erlang-bbmustache.git/p...
SRPM URL:
https://fnux.fedorapeople.org/pkg-reviews/erlang-bbmustache/df9baaed9b077...
Description: Binary pattern match based Mustache template engine for erlang.
Fedora Account System Username: fnux

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1613654] Review Request: erlang-bbmustache - Binary pattern match based Mustache template engine for erlang

https://bugzilla.redhat.com/show_bug.cgi?id=1613654

Timothée Floure <timothee.floure(a)fnux.ch&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1615005




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1615005
[Bug 1615005] Review Request: erlang-relx - Release assembler for
Erlang/OTP Releases
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1613654] Review Request: erlang-bbmustache - Binary pattern match based Mustache template engine for erlang

https://bugzilla.redhat.com/show_bug.cgi?id=1613654

Timothée Floure <timothee.floure(a)fnux.ch&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1434779




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1434779
[Bug 1434779] Add package for rebar3
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1613654] Review Request: erlang-bbmustache - Binary pattern match based Mustache template engine for erlang

https://bugzilla.redhat.com/show_bug.cgi?id=1613654

Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m(a)gmail.com
           Assignee|nobody(a)fedoraproject.org    |zebob.m(a)gmail.com
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; ---
Package approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 48 files
have
     unknown license. Detailed output of licensecheck in
     /home/bob/packaging/review/erlang-bbmustache/review-erlang-
     bbmustache/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: erlang-bbmustache-1.5.0-1.fc29.x86_64.rpm
          erlang-bbmustache-1.5.0-1.fc29.src.rpm
erlang-bbmustache.x86_64: E: no-binary
erlang-bbmustache.x86_64: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 1 errors, 1 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1613654] Review Request: erlang-bbmustache - Binary pattern match based Mustache template engine for erlang

https://bugzilla.redhat.com/show_bug.cgi?id=1613654

Peter Lemenkov <lemenkov(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
                 CC|                            |lemenkov(a)gmail.com
         Resolution|---                         |NOTABUG
        Last Closed|                            |2018-08-15 11:08:23



--- Comment #2 from Peter Lemenkov <lemenkov(a)gmail.com&gt; ---
erlang-bbmustache was added to fedora already.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component