[Bug 600227] New: Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Summary: Review Request: maven-repository-plugin - Plugin to
                    create bundles of artifacts that should be manually
                    uploaded to the central Maven repository
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://yyang.fedorapeople.org/maven2/maven-repository-plugin.spec
SRPM URL:
http://yyang.fedorapeople.org/maven2/maven-stage-plugin-1.0-0.1.alpha2.src.r...
Description: This plugin is used to create bundles of artifacts that can be
uploaded to the central repository.

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Alexander Kurtakov  2010-06-04 11:14:23 EDT ---
I'll take this one.

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Alexander Kurtakov  2010-06-04 11:15:21 EDT ---
hmm, it points to stage plugin srpm.

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

--- Comment #3 from Yang Yong  2010-06-06 22:05:05 EDT ---
Fixed srpm url and minor issues:

Spec URL: http://yyang.fedorapeople.org/maven2/maven-repository-plugin.spec
SRPM URL:
http://yyang.fedorapeople.org/maven2/maven-repository-plugin-2.3-1.src.rpm

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

--- Comment #4 from Alexander Kurtakov  2010-06-07 03:42:53 EDT ---
Review:

FIXIT: rpmlint must be run on every package. Output:
maven-repository-plugin.noarch: E: summary-too-long C Plugin to create bundles
of artifacts that should be manually uploaded to the central Maven repository

Fix it.

maven-repository-plugin.noarch: W: no-documentation
maven-repository-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-repository-plugin

False positives.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8.    
OK: Provides/Obsoletes are good.

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

--- Comment #5 from Alexander Kurtakov  2010-06-07 04:03:19 EDT ---
Ooops, I missed the Lisense.txt is shipped in the tarball. Please include it as
%doc

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

--- Comment #6 from Yang Yong  2010-06-07 04:17:20 EDT ---
Changelog:
- Update summary due to length issue
- Add LICENSE.txt

Please review again.

Spec URL: http://yyang.fedorapeople.org/maven2/maven-repository-plugin.spec
SRPM URL:
http://yyang.fedorapeople.org/maven2/maven-repository-plugin-2.3-2.src.rpm

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Alexander Kurtakov  2010-06-07 04:39:38 EDT ---
Thanks,

This package is APPROVED.

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Yang Yong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #8 from Yang Yong  2010-06-07 04:51:01 EDT ---
New Package CVS Request
=======================
Package Name: maven-repository-plugin
Short Description: Plugin to create bundles of artifacts for manual uploaded to
repository
Owners: yyang
Branches: devel
InitialCC: huwang liweinan akurtako dbhole

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #9 from Kevin Fenzi  2010-06-07 17:27:40 EDT ---
cvs done, except liweinan account doesn't exist.

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Yang Yong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #10 from Yang Yong  2010-06-08 07:36:16 EDT ---
Hi Kevin, cvs is not done yet after 12 hours passed, may be caused by wrong CC,
please create cvs again and leave CC blank, thanks.

New Package CVS Request
=======================
Package Name: maven-repository-plugin
Short Description: Plugin to create bundles of artifacts for manual uploaded to
repository
Owners: yyang
Branches: devel
InitialCC:

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 600227] Review Request: maven-repository-plugin - Plugin to create bundles of artifacts that should be manually uploaded to the central Maven repository

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=600227

Yang Yong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #11 from Yang Yong  2010-06-09 02:08:47 EDT ---
http://koji.fedoraproject.org/koji/buildinfo?buildID=177410