https://bugzilla.redhat.com/show_bug.cgi?id=2182542
Bug ID: 2182542 Summary: Review Request: rust-compact_str - Memory efficient string type Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: maxwell@gtmx.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gotmax23.fedorapeople.org/reviews/rust-compact_str/rust-compact_str.... SRPM URL: https://gotmax23.fedorapeople.org/reviews/rust-compact_str/rust-compact_str-...
Description: A memory efficient string type that transparently stores strings on the stack, when possible.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99263674
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/co | |mpact_str
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5721299 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
Maxwell G maxwell@gtmx.me changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|https://crates.io/crates/co | |mpact_str | Doc Type|--- |If docs needed, set a value Depends On| |2182474
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2182474 [Bug 2182474] Review Request: rust-castaway - Safe, zero-cost downcasting for limited compile-time specialization
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (missing dependencies for tests) - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Disabling the test suite is justified, packaging a handful of crates just to run tests in one crate is not necessary.
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-compact_str
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
--- Comment #4 from Maxwell G maxwell@gtmx.me --- https://pagure.io/releng/fedora-scm-requests/issue/52473 https://pagure.io/releng/fedora-scm-requests/issue/52474 https://pagure.io/releng/fedora-scm-requests/issue/52475
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-bd29748c07 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bd29748c07
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-04-03 08:55:16
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-bd29748c07 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-534a134bb2 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8aa6dbb1df has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-534a134bb2 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-534a134bb2
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8aa6dbb1df *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8aa6dbb1df
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8aa6dbb1df has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2182542
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-534a134bb2 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com