https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Bug ID: 2071646 Summary: Review Request: stdman - C++ standard library man pages Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: mohd.akram@outlook.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/mohd-akram/stdman/fedora-... SRPM URL: https://download.copr.fedorainfracloud.org/results/mohd-akram/stdman/fedora-... Description: C++ standard library man pages generated from cppreference.com HTML files Fedora Account System Username: mohd-akram
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |zbyszek@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Hmm, how is the License tag derived? The content is from cppreference.com, but I couldn't find a license specification anywhere.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #2 from Mohamed Akram mohd.akram@outlook.com --- MIT license is for stdman itself, the other two are for cppreference (see https://en.cppreference.com/w/Cppreference:FAQ).
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Ah, the link is https://en.cppreference.com/w/Cppreference:FAQ#What_can_I_do_with_the_materi... Please add that in a comment in the spec file.
So this looks all good, but the license should *not* include MIT [https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...]:
The License: field refers to the licenses of the contents of the binary rpm.
I'd suggest %autorelease+%autochangelog to reduce the maintenance burden: https://docs.pagure.org/fedora-infra.rpmautospec/opting-in.html
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #4 from Mohamed Akram mohd.akram@outlook.com --- Ah, I was wondering about that. Should I also remove the %license from the files?
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Yes.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Mohamed Akram mohd.akram@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/mohd-akram/stdman/fedora-... SRPM URL: https://download.copr.fedorainfracloud.org/results/mohd-akram/stdman/fedora-... Description: C++ standard library man pages generated from cppreference.com HTML files Fedora Account System Username: mohd-akram
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #6 from Mohamed Akram mohd.akram@outlook.com --- Cool, I updated the files with the changes.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #7 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- + package name is OK + license is acceptable (GFDL and CC-BY-SA) + license is specified correctly + builds and installs OK + latest version + R/P/BR look OK
rpmlint complains that there's a number of identical files. Certain files are copied even 5 times. It's not a big deal: the whole package is 4 MB. If you wanted to fix this, it'd be possible to either use symlinks, or to replace the content in duplicate files with '.so <name-of-the-real-file>'. But it's probably not worth the trouble.
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #8 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Maybe the following:
BuildRequires: jdupes
%prep: ... sed -i /gzip/d do_install
%install: ... jdupes -r -l %{buildroot}%{_mandir}
This has also the advantage that the distro compression settings are used. gzip is now used by default, but I think we'll be switching to zstd at some point.
https://bugzilla.redhat.com/show_bug.cgi?id=2071646
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zbyszek@in.waw.pl | |) |
--- Comment #11 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- I can re-review if an update is submitted.
Product: Fedora Version: rawhide Component: Package Review
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl has canceled Package Review package-review@lists.fedoraproject.org's request for Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl's needinfo: Bug 2071646: Review Request: stdman - C++ standard library man pages https://bugzilla.redhat.com/show_bug.cgi?id=2071646
--- Comment #11 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- I can re-review if an update is submitted.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com