[Bug 2141057] New: Review Request: plasma-welcome - Friendly onboarding wizard for KDE Plasma
https://bugzilla.redhat.com/show_bug.cgi?id=2141057
Bug ID: 2141057 Summary: Review Request: plasma-welcome - Friendly onboarding wizard for KDE Plasma Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ngompa13@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/ngompa/kde-oobe-dev/fedor... SRPM URL: https://download.copr.fedorainfracloud.org/results/ngompa/kde-oobe-dev/fedor... Description: The Plasma Welcome Center is the perfect introduction to KDE Plasma! It can help you learn how to connect to the internet, install apps, customize the system, and more!
Fedora Account System Username: ngompa
https://bugzilla.redhat.com/show_bug.cgi?id=2141057
marcdeop@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcdeop@fedoraproject.org Flags| |fedora-review? Assignee|nobody@fedoraproject.org |marcdeop@fedoraproject.org Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2141057
--- Comment #1 from marcdeop@fedoraproject.org --- I attach the output of fedora-review. Notice the "Issues" section and the rpmlint: W: no-version-in-last-changelog
Personal opinion although not critical: replace "BuildRequires: /usr/bin/appstreamcli" by "BuildRequires: appstream"
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file.
===== MUST items =====
C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3
plasma-welcome-debugsource.x86_64: W: no-version-in-last-changelog plasma-welcome.x86_64: W: no-version-in-last-changelog plasma-welcome-debuginfo.x86_64: W: no-version-in-last-changelog plasma-welcome.x86_64: W: no-manual-page-for-binary plasma-welcome plasma-welcome-debugsource.x86_64: W: invalid-license LicenseRef-KDE-Accepted-GPL plasma-welcome.x86_64: W: invalid-license LicenseRef-KDE-Accepted-GPL plasma-welcome-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-GPL 3 packages and 0 specfiles checked; 0 errors, 7 warnings, 0 badness; has taken 0.3 s
Source checksums ---------------- https://invent.kde.org/plasma/plasma-welcome/-/archive/84ffe86d6c4ed545ba473... : CHECKSUM(SHA256) this package : cff5e171c7fded84228d6abcd47f0a67336a784d18819baabd8804c37f49a869 CHECKSUM(SHA256) upstream package : cff5e171c7fded84228d6abcd47f0a67336a784d18819baabd8804c37f49a869
Requires -------- plasma-welcome (rpmlib, GLIBC filtered): libKF5CoreAddons.so.5()(64bit) libKF5DBusAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5KIOGui.so.5()(64bit) libKF5Notifications.so.5()(64bit) libKF5QuickAddons.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5WindowSystem.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Qml.so.5()(64bit) libQt5Qml.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH)
plasma-welcome-debuginfo (rpmlib, GLIBC filtered):
plasma-welcome-debugsource (rpmlib, GLIBC filtered):
Provides -------- plasma-welcome: application() application(org.kde.plasma-welcome.desktop) metainfo() metainfo(org.kde.plasma-welcome.appdata.xml) plasma-welcome plasma-welcome(x86-64) rpm_macro(plasmawelcome_extrapagedir)
plasma-welcome-debuginfo: debuginfo(build-id) plasma-welcome-debuginfo plasma-welcome-debuginfo(x86-64)
plasma-welcome-debugsource: plasma-welcome-debugsource plasma-welcome-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2141057 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Ocaml, Perl, Haskell, Java, fonts, SugarActivity, Python, R, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2141057
marcdeop@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
https://bugzilla.redhat.com/show_bug.cgi?id=2141057
Onuralp Sezer thunderbirdtr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |thunderbirdtr@gmail.com
--- Comment #2 from Onuralp Sezer thunderbirdtr@gmail.com --- Package is already exist (https://src.fedoraproject.org/rpms/plasma-welcome-app)
Please close the ticket
Thank you.
https://bugzilla.redhat.com/show_bug.cgi?id=2141057
marcdeop@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review- |needinfo?(ngompa13@gmail.co | |m) | Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed| |2022-11-08 19:26:02
--- Comment #3 from marcdeop@fedoraproject.org ---
*** This bug has been marked as a duplicate of bug 2124356 ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com