Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217524
Summary: Review Request: libsyncml - SyncML protocol library
Product: Fedora Extras
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: normal
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: laurent.rineau__fedora_extras(a)normalesup.org
QAContact: fedora-package-review(a)redhat.com
Spec URL: http://www-sop.inria.fr/geometrica/team/Laurent.Rineau/Fedora/libsyncml.spec
SRPM URL: http://www-sop.inria.fr/geometrica/team/Laurent.Rineau/Fedora/libsyncml-0.4…
Description:
Libsyncml is a implementation of the SyncML protocol.
Quote from Wikipedia: "SyncML is most commonly thought of as a method to synchronize contact and calendar information between some type of handheld device and a computer (personal, or network-based service), such as between a mobile phone and a personal computer."
Note 1: This library requires wbxml2, which has been unorphaned. See bug #217180.
Note 2: I have not yet managed to build it with mock, because wbxml2 has not been pushed into rawhide. It was build successfully today. See
http://buildsys.fedoraproject.org/build-status/job.psp?uid=22503
Note 3: libopensync-plugin-syncml will follow, blocked by bug #217150.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217180
Summary: Review Request: wbxml2 - WBXML parser and compiler
library
Product: Fedora Extras
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: normal
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: laurent.rineau__fedora_extras(a)normalesup.org
QAContact: fedora-package-review(a)redhat.com
Spec URL: http://www-sop.inria.fr/geometrica/team/Laurent.Rineau/Fedora/wbxml2.spec
SRPM URL: http://www-sop.inria.fr/geometrica/team/Laurent.Rineau/Fedora/wbxml2-0.9.2-…
Description:
The WBXML Library (libwbxml) contains a library and its associated tools to
parse, encode and handle WBXML documents. The WBXML format is a binary
representation of XML, defined by the Wap Forum, and used to reduce
bandwidth in mobile communications.
This library is a required by libsyncml (to be submitted latter).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnu-smalltalk - GNU Smalltalk
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377
------- Additional Comments From bonzini(a)gnu.org 2006-11-28 02:30 EST -------
I can reply as far as the upstream package is concerned...
> * %install section
> - Fix broken Shebangs
> (Please see "timestamp" section below for this).
Should not be necessary anymore.
> - *.st files
> Well, actually I first saw this utility so I don't quite know
> how to use this package, however, are these *.st really required
> for 'minimal' use of smalltalk? Or are these somewhat 'add-on'
> files for smalltalk? (The judgment as of what is 'minimal' use
> is up to you.)
They are needed to load the optional packages (e.g. sockets, GUI bindings, ...).
> - /usr/share/gnu-smalltalk/unsupported/binary.c
> rpmlint complains about this file as 'devel-file-in-non-devel-package'.
> Would you explain why this file should be in main package?
I'm going to remove this from the upstream package too.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnu-smalltalk - GNU Smalltalk
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-11-28 02:22 EST -------
Okay, I will review this package.
0. spec file description :
* %prep
- applying patches
I usually recommend to add some suffix every time you apply
a patch, e.g.
%patch1 -p1 -b .am
* %build section
- export CFLAGS="$RPM_OPT_FLAGS"
This is not necessary because %configure macro sets this.
- make %{?_smp_mflags} LIBTOOL="/usr/bin/libtool"
Use macro. i.e. LIBTOOL="%{_bindir}/libtool"
* %install section
- Fix broken Shebangs
(Please see "timestamp" section below for this).
* %files section
- COPYING
Why does every subpackage have same COPYING file? Only for
rpmlint issue? If so, please remove these as this rpmlint can be
ignored.
- *.st files
Well, actually I first saw this utility so I don't quite know
how to use this package, however, are these *.st really required
for 'minimal' use of smalltalk? Or are these somewhat 'add-on'
files for smalltalk? (The judgment as of what is 'minimal' use
is up to you.)
- /usr/share/gnu-smalltalk/unsupported/binary.c
rpmlint complains about this file as 'devel-file-in-non-devel-package'.
Would you explain why this file should be in main package?
Then:
1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Timestamps
This package contains lots of text files (mainly *.st files), so
keeping timestamps is highly preferable because
- it shows when the file is written by upstream or vendor (as you)
- it may suggest whether vendor (you) have changed original content.
So please keep timestamps for text files included.
Then:
A. Try: 'make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -c -p" install'
B. For "Fix broken Shebangs" section:
B-1 check if this section is still needed.
B-2 If so (i.e. this section is still needed), change the description
of this section so that the files which are actually not needed
to be fixed _WON'T_ change their timestamps.
* File and Directory Ownership
- %{_datadir}/aclocal/
This directory is owned only by automake and so -devel package should
require automake.
2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
(okay)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnu-smalltalk - GNU Smalltalk
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377
mtasaka(a)ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776 |163778
nThis| |
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnu-smalltalk - GNU Smalltalk
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377
mtasaka(a)ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody(a)fedoraproject.org |mtasaka(a)ioa.s.u-tokyo.ac.jp
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217278
Summary: Review Request: tcd-utils - TCD (Tide Constituent
Database) Utils
Product: Fedora Extras
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: normal
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: mtasaka(a)ioa.s.u-tokyo.ac.jp
QAContact: fedora-package-review(a)redhat.com
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/packages/xtide/SPECS/tcd-utils…
SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/packages/xtide/SRPMS/
Description:
TCD Utils includes:
* build_tide_db to convert harmonics.txt, offsets.xml, and NAVO
formats to harmonics.tcd;
* restore_tide_db to generate harmonics.txt and offsets.xml from
harmonics.tcd
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: lurker
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185535
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2006-11-27 02:39 EST -------
Well, what is the current status of this review request?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.