Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470696
--- Comment #3 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> 2008-11-09 11:17:39
EDT ---
By the way some pre-remarks
* BuildRequires
- This package won't build without "BR: rubygem(fastthread)".
- "BR: gcc-c++ findutils" are redundant.
* Requires
- Please check if all needed Requires are correctly added.
It seems that at least "Requires: rubygem(rack)
rubygem(fastthread)" are needed.
* boost dependency
- Well, when I try below to make build log more verbose
(please consider this)
-------------------------------------------------------
%prep
%setup -q -c -T
mkdir BINDIR
cat > BINDIR/rake <<EOF
#!/bin/bash
%{_bindir}/rake -v \$@
EOF
chmod 0755 BINDIR/rake
%build
export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
export PATH=$(pwd)/BINDIR:$PATH
gem install \
......
-------------------------------------------------------
build log shows (attached)
-------------------------------------------------------
1525 DEBUG: cd
/builddir/build/BUILD/rubygem-passenger-2.0.3/usr/lib/ruby/gems/1.8/gems/passenger-2.0.3
1526 DEBUG: rake clean apache2
1527 DEBUG: rm -rf Utils.o Bucket.o Logging.o System.o Configuration.o
Hooks.o mod_passenger.o mod_passenger.so ApplicationPoolSe
rverExecutable
1528 DEBUG: (in
/builddir/build/BUILD/rubygem-passenger-2.0.3/usr/lib/ruby/gems/1.8/gems/passenger-2.0.3)
1529 DEBUG: ### In ext/apache2:
1530 DEBUG: rm -r pkg
1531 DEBUG: make clean
1532 DEBUG: ### In ext/passenger:
1533 DEBUG: rm -f Makefile
1534 DEBUG: rm -f libboost_thread.a *.o
1535 DEBUG: ### In ext/boost/src:
1536 DEBUG: rm -f Apache2ModuleTests *.o
1537 DEBUG: ### In test:
1538 DEBUG: rm -f DummyRequestHandler ApplicationPool
1539 DEBUG: ### In benchmark:
1540 DEBUG: g++ -g -DPASSENGER_DEBUG -fPIC -I../.. -D_REENTRANT -DNDEBUG -c
*.cpp
1541 DEBUG: ### In ext/boost/src:
1542 DEBUG: g++ -g -DPASSENGER_DEBUG -fPIC -I../.. -D_REENTRANT -DNDEBUG -c
pthread/exceptions.cpp
1543 DEBUG: g++ -g -DPASSENGER_DEBUG -fPIC -I../.. -D_REENTRANT -DNDEBUG -c
pthread/once.cpp
1544 DEBUG: g++ -g -DPASSENGER_DEBUG -fPIC -I../.. -D_REENTRANT -DNDEBUG -c
pthread/thread.cpp
1545 DEBUG: ar cru libboost_thread.a *.o
1546 DEBUG: ranlib libboost_thread.a
-------------------------------------------------------
Here
- This package seem to be using internal libboost_thread library.
This should be changed so that mod_passenger.so uses external (system-
widely provided) libboost_thread-mt.so library
- Anyway Fedora specific compilation flags are not correctly honored.
* Redundant output
- I guess the "-v" option of "chmod -v 644 $script" is not
needed...
(Actually you are not using -v option for chmod on the below lines)
- Also I guess rm -r"v"f is redundant...
* Document files
- You don't have to write %doc attribute for files under %_mandir
(as these are automatically regarded as %doc)
* Directory ownership issue
- Please own %{ruby_sitearch}/passenger/
- Please also check the directory ownership issues between subpackages.
! For example
- The directory %{geminstdir}/doc is owned by -doc subpackage
- -devel subpackage has %{geminstdir}/doc/definitions.h
- -devel subpackage does not have "Requires: -doc"
- So when -devel subpackage is installed with_out_ -doc subpackage
installed, %{geminstdir}/doc is not owned by any packages
* %defattr
- is missing on mod_passenger subpackage.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.