Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956669
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@gmail.com Flags| |needinfo+
--- Comment #2 from Antonio Trande anto.trande@gmail.com --- Hi Christopher. Just some initial comments:
- I see some changes about FHS fixes. In my opinion, with a single modification into 'deployment.pri' file, you can resolve all at one time ;)
- .desktop file is already in the source archive; why do you add another one as Source1 ?
- %{_datadir}/%{name} directory must be owned by the package
- In erebus_source.txt file, the developer says:
The source code is released under the GPL v3 or later. Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at ntlworld dot com .
I don't see any license file included, apart from docs/gpl.txt file that is not the GPLv3+ text file.