https://bugzilla.redhat.com/show_bug.cgi?id=1476434
Iwicki Artur <fedora(a)svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora(a)svgames.pl
--- Comment #1 from Iwicki Artur <fedora(a)svgames.pl> ---
Release: 0%{?dist}
The Release: tag should start at 1.
https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning
Group: System Environment/Libraries
Group: Development/Libraries
The Group: tag should not be used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
This will always fetch the latest snapshot of the master branch, which
introduces a risk of the RPM version not matching the software version. Refer
to a git tag or commit instead.
https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Hosting_Services
%{_libdir}/bstrlib/
%{_includedir}/bstrlib/
These directories are unowned. You may want to use the %dir
macro to mark a
directory as owned, without auto-owning all the files inside.
Also, I believe that the use of both %{buildroot} and ${RPM_BUILD_ROOT} is
discouraged; it should be one or the other.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component