[Bug 1427295] Review Request: container-storage-setup - Tool for setting up container runtimes storage
https://bugzilla.redhat.com/show_bug.cgi?id=1427295
--- Comment #4 from Lokesh Mandvekar <lsm5(a)redhat.com> ---
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated". 42 files have
unknown
license. Detailed output of licensecheck in /home/lsm5/1427295
-container-storage-setup/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[!]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define csslibdir
%{_prefix}/lib/container-storage-setup
Could you change %define csslibdir to %global csslibdir?
Also, I think README.md should be included in a %doc.
It'd be nice to have a LICENSE file with ASL 2.0 text in it. Right now there's
just ASL 2.0 text included in the c-s-s.sh file. Just to make our license loud
and clear.
Everything else looks ok and almost ready for approval.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component