Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=444512
--- Comment #5 from Orcan 'oget' Ogetbil <orcanbahri(a)yahoo.com> 2008-12-03
13:21:24 EDT ---
(In reply to comment #4)
(In reply to comment #3)
> eclipse-eclemma.noarch: W: dangling-symlink
>
/usr/share/eclipse/dropins/eclemma/eclipse/plugins/com.mountainminds.eclemma.core_1.3.2/emma.jar
> /usr/share/java/emma.jar
> This can be ignored.
> eclipse-eclemma.noarch: W: symlink-should-be-relative
>
/usr/share/eclipse/dropins/eclemma/eclipse/plugins/com.mountainminds.eclemma.core_1.3.2/emma.jar
> /usr/share/java/emma.jar
> This should be fixed.
I think we'd be better off fixing build-jar-repository. If you want, I'll make
it a big long ln -s ../../../java/emma.jar instead, but build-jar-repository
seems cleaner.
I never saw a usage of build-jar-repository in the %install section before.
Well, the guidelines state that the symlink must be relative. I know it's ugly
but that's the way it should be.
> eclipse-eclemma.src: W: strange-permission get-eclemma.sh 0775
> Please use 644 for source files.
This is a shell script to fetch the source. Do you still want it changed?
I don't think this is a MUST. But I recommend this in reviews. You can always
call the fetch script via
sh get-eclemma.sh
> * The license file says:
> "The user documentation contains example code taken from the Apache
Jakarta
> Commons project, provided under the terms and conditions of the Apache License
> Version 2.0. "
> Shall we include ASL 2.0 in the license tag?
I don't know. I guess it can't hurt :) I've added it.
So this is my biggest concern. The ASL 2.0 license clearly states that (clause
4.1):
"You must give any other recipients of the Work or Derivative Works a copy
of this License"
This package does not include the ASL 2.0 license. I think you should
EITHER
download it and put it as a source in the SPEC file and then include it in the
%doc[1]
OR just remove
com.mountainminds.eclemma.doc/pages/images/annotations.png
and the relevant bits from
com.mountainminds.eclemma.doc/pages/annotations.html
But in either case, upstream should be notified about this issue.
[1]
http://www.apache.org/licenses/LICENSE-2.0
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.