1:31 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1882871
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #9 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
- Please don't mix suse conditionals in the Fedora package
- Add make explicitly as a BR as we are removing it from the default buildroot
- Are the default build flags correctly used during the build, the summary
before the build does not mention them:
flags:
cflag:
ccflag:
cxflag:
mflag:
mmflag:
mxflag:
ldflag:
asflag:
arflag:
shflag:
It seems core/suffix.mak is using non standard flags name so set_build_flags
would have no effect.
# append flags
CFLAGS += $(CFLAG) $(CFLAGS-y)
CXFLAGS += $(CXFLAG) $(CXFLAGS-y)
CCFLAGS += $(CCFLAG) $(CCFLAGS-y)
MFLAGS += $(MFLAG) $(MFLAGS-y)
MMFLAGS += $(MMFLAG) $(MMFLAGS-y)
MXFLAGS += $(MXFLAG) $(MXFLAGS-y)
LDFLAGS += $(LDFLAG) $(LDFLAGS-y)
ASFLAGS += $(ASFLAG) $(ASFLAGS-y)
ARFLAGS += $(ARFLAG) $(ARFLAGS-y)
SHFLAGS += $(SHFLAG) $(SHFLAGS-y)
I'd use this:
%build
export CFLAG="%{optflags}"
export CXFLAG="%{optflags}"
export CCFLAG="%{optflags}"
export LDFLAG="%{build_ldflags}"
%make_build
- Use %global instead of %define:
%define xmake_revision 2f6e5e72cb9527bad1b417ef9c48ea0ecfae53b7
%define tbox_revision 6e5fb77c5ab5c0d712871c52c42a5bc7843cd780
%define sv_revision 9a3cf7c8e589de4f70378824329882c4a047fffc
%define lua_cjson_revision 515bab6d6d80b164b94db73af69609ea02f3a798
%define luajit_revision e9af1abec542e6f9851ff2368e7f196b6382a44c
%define _binaries_in_noarch_packages_terminate_build
- This is not ok: %define _binaries_in_noarch_packages_terminate_build 0
Your package shouldn't be noarch as you are shipping binary code. Also it needs
to properly provide debug info:
xmake.noarch: E: arch-independent-package-contains-binary-or-object
/usr/bin/xmake
- You description line are too long, split them to stay under 80 characters
per line.
xmake.noarch: E: description-line-too-long C It uses xmake.lua to maintain
project builds. Compared with makefile/CMakeLists.txt,
xmake.noarch: E: description-line-too-long C generate project files like
CMake/Meson, and it also has a built-in package management
- the version in the changelog does not match the header:
xmake.noarch: W: incoherent-version-in-changelog 2.3.8-1 ['2.5.1-1.fc34',
'2.5.1-1']
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License
2.0",
"Apache License 2.0", "zlib/libpng license", "BSD 3-clause
"New" or
"Revised" License Apache License 2.0", "GNU General Public
License
v2.0 or later", "Boost Software License 1.0". 179 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/xmake/review-xmake/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[!]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define xmake_revision
2f6e5e72cb9527bad1b417ef9c48ea0ecfae53b7, %define tbox_revision
6e5fb77c5ab5c0d712871c52c42a5bc7843cd780, %define sv_revision
9a3cf7c8e589de4f70378824329882c4a047fffc, %define lua_cjson_revision
515bab6d6d80b164b94db73af69609ea02f3a798, %define luajit_revision
e9af1abec542e6f9851ff2368e7f196b6382a44c, %define
_binaries_in_noarch_packages_terminate_build 0
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: xmake-2.5.1-1.fc34.noarch.rpm
xmake-2.5.1-1.fc34.src.rpm
xmake.noarch: W: spelling-error %description -l en_US makefile -> make file,
make-file, filmmaker
xmake.noarch: W: spelling-error %description -l en_US txt -> text, ext, tit
xmake.noarch: E: description-line-too-long C It uses xmake.lua to maintain
project builds. Compared with makefile/CMakeLists.txt,
xmake.noarch: E: description-line-too-long C generate project files like
CMake/Meson, and it also has a built-in package management
xmake.noarch: W: incoherent-version-in-changelog 2.3.8-1 ['2.5.1-1.fc34',
'2.5.1-1']
xmake.noarch: E: arch-independent-package-contains-binary-or-object
/usr/bin/xmake
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/scripts/find_cudadevices.cpp
xmake.noarch: E: non-executable-script
/usr/share/xmake/scripts/update-script.sh 644 /bin/sh
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/console/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.console/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.quickapp/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.quickapp_static/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.shared/project/src/demo.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.shared/project/src/demo.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.shared/project/src/demo_global.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.static/project/src/demo.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.static/project/src/demo.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.widgetapp/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.widgetapp/project/src/mainwindow.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.widgetapp/project/src/mainwindow.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.widgetapp_static/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.widgetapp_static/project/src/mainwindow.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/qt.widgetapp_static/project/src/mainwindow.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/shared/project/src/interface.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/shared/project/src/interface.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/shared/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/static/project/src/interface.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/static/project/src/interface.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/static/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/tbox.console/project/src/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/tbox.shared/project/src/_demo/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/tbox.shared/project/src/_library/interface.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/tbox.shared/project/src/_library/interface.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/tbox.static/project/src/_demo/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/tbox.static/project/src/_library/interface.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/tbox.static/project/src/_library/interface.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c++/xmake.cli/project/src/lni/main.cpp
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/console/project/src/main.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/shared/project/src/interface.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/shared/project/src/interface.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/shared/project/src/main.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/static/project/src/interface.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/static/project/src/interface.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/static/project/src/main.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/tbox.console/project/src/main.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/tbox.shared/project/src/_demo/main.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/tbox.shared/project/src/_library/interface.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/tbox.shared/project/src/_library/interface.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/tbox.static/project/src/_demo/main.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/tbox.static/project/src/_library/interface.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/tbox.static/project/src/_library/interface.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/c/xmake.cli/project/src/lni/main.c
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc++/bundle/project/src/test.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc++/framework/project/src/test.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/bundle/project/src/test.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/framework/project/src/test.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/iosapp/project/src/AppDelegate.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/iosapp/project/src/SceneDelegate.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/iosapp/project/src/ViewController.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/iosapp_with_framework/project/src/app/AppDelegate.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/iosapp_with_framework/project/src/app/SceneDelegate.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/iosapp_with_framework/project/src/app/ViewController.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/iosapp_with_framework/project/src/framework/test.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/macapp/project/src/AppDelegate.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/macapp/project/src/ViewController.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/macapp_with_framework/project/src/app/AppDelegate.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/macapp_with_framework/project/src/app/ViewController.h
xmake.noarch: W: devel-file-in-non-devel-package
/usr/share/xmake/templates/objc/macapp_with_framework/project/src/framework/test.h
xmake.noarch: W: no-manual-page-for-binary xmake
xmake.noarch: W: no-manual-page-for-binary xrepo
xmake.src: W: spelling-error %description -l en_US lua -> la, luau, lea
xmake.src: W: spelling-error %description -l en_US makefile -> make file,
make-file, filmmaker
xmake.src: W: spelling-error %description -l en_US txt -> text, ext, tit
xmake.src: E: description-line-too-long C It uses xmake.lua to maintain project
builds. Compared with makefile/CMakeLists.txt,
xmake.src: E: description-line-too-long C generate project files like
CMake/Meson, and it also has a built-in package management
2 packages and 0 specfiles checked; 6 errors, 69 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component