Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=807476
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org AssignedTo|nobody@fedoraproject.org |misc@zarb.org Flag| |fedora-review?
--- Comment #2 from Michael Scherer misc@zarb.org 2012-03-31 06:42:19 EDT --- Hi,
- is the package intended for EPEL 5 or 6 ? If no, you should remove %defattr, BuildRoot and %clean, as they are no longer needed ( the less cruft we have, the better we are ).
- if the license is empty, can you make sure to warn upstream about it ( you likely already did but just to be sure ) ?
- It would be nice to have the command used to generate the tarball in comment. While I expect everybody to know how to use git archive, it doesn't cost much to add some doc in case someone do not know.
- Also, it would be nice to have a more detailed description ( again I guess people who will use it will know this is for the integrity subsystem, but that look better if there is less terse description )
- Still on the nitpicking side, I think BuildRequires on separate line help when reviewing patches. That's not blocking for the review but would make a nicer spec.
- I see there is some tests, I assume there is no pratical way to run them in %check without being root ?
Aside from that, I will start soon the formal review.