[Bug 1601186] Review Request: wpewebkit - A WebKit port optimized for low-end devices

https://bugzilla.redhat.com/show_bug.cgi?id=1601186



--- Comment #36 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; ---
Following this cmake script:

# Use ld.gold if it is available and isn't disabled explicitly
CMAKE_DEPENDENT_OPTION(USE_LD_GOLD "Use GNU gold linker" ON
                       "NOT CXX_ACCEPTS_MFIX_CORTEX_A53_835769;NOT
ARM_TRADITIONAL_DETECTED;NOT WIN32;NOT APPLE" OFF)
if (USE_LD_GOLD)
    execute_process(COMMAND ${CMAKE_C_COMPILER} -fuse-ld=gold -Wl,--version
ERROR_QUIET OUTPUT_VARIABLE LD_VERSION)
    if ("${LD_VERSION}" MATCHES "GNU gold")
        set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=gold
-Wl,--disable-new-dtags")
        set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=gold
-Wl,--disable-new-dtags")
    else ()
        message(WARNING "GNU gold linker isn't available, using the default
system linker.")
        set(USE_LD_GOLD OFF)
    endif ()
endif ()


we can see that CMAKE_SHARED_LINKER_FLAGS is not set to
${CMAKE_EXE_LINKER_FLAGS} om ARM arches.

Thus you should add it in your cmake call:

%cmake \
  -DPORT=WPE \
  -DCMAKE_BUILD_TYPE=Release \
  -DENABLE_MINIBROWSER=ON \
  -DCMAKE_EXE_LINKER_FLAGS="${CMAKE_EXE_LINKER_FLAGS} -lrt" \
  -DCMAKE_SHARED_LINKER_FLAGS="${CMAKE_SHARED_LINKER_FLAGS} -lrt" \
%ifarch s390 aarch64
  -DUSE_LD_GOLD=OFF \
%endif
%ifarch s390 s390x ppc %{power64}
  -DENABLE_JIT=OFF \
  -DUSE_SYSTEM_MALLOC=ON \
%endif

See successful build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=28909553

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component