https://bugzilla.redhat.com/show_bug.cgi?id=2271737
--- Comment #3 from Xavier Delaruelle <xavier.delaruelle(a)cea.fr> ---
Hello,
Many thanks Dominique for this review. I have released a new version (0.2.1)
that fix the issues you have spotted.
Spec URL:
https://xdelaruelle.fedorapeople.org/mogui.spec
SRPM URL:
https://xdelaruelle.fedorapeople.org/mogui-0.2.1-2.fc38.src.rpm
Details of the changes made:
(In reply to Dominique Martinet from comment #2)
> mogui.noarch: W: python-leftover-require python3-qt5
I couldn't find any documentation about this warning as it appears to be
new.. The commit that added the warning (
https://github.com/rpm-software-management/rpmlint/pull/1022/commits/
76a091814a85e13a75cea16cc862911c5b9cf6c1 ) seems to say it compares
requirements.txt with requires in the rpm?
given rpmbuild automatically adds the following you can drop python3 and
python3-qt5 from the requires altogether:
python(abi) = 3.12
python3.12dist(pyqt5)
fixed
Given it's a gui I guess it's not too unusual not to have a
man page, but I
didn't make a difference between mogui-cmd and mogui so it might warrant
some documentation?
mogui.noarch: W: files-duplicate /usr/bin/mogui-cmd /usr/bin/mogui
Ah, it's the same file, that's explain why I didn't make a difference.. Do
we need both?
The README doesn't mention mogui-cmd, so I'd keep just the former.
I have removed "mogui". The profile.d script defines a "mogui" shell
function
(like environment-modules does). This shell function relies on the "mogui-cmd"
script (cannot call "mogui" otherwise the shell function will call itself
recursively)
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /etc/profile.d, /usr, /usr/lib/python3.12,
/usr/share, /usr/bin, /usr/share/licenses, /usr/lib,
/usr/lib/python3.12/site-packages, /usr/share/doc, /etc,
/usr/share/fish, /usr/share/fish/vendor_conf.d
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/licenses,
/etc/profile.d, /usr/share/doc, /etc, /usr/share, /usr/share/fish,
/usr/share/fish/vendor_conf.d, /usr, /usr/lib/python3.12, /usr/lib,
/usr/lib/python3.12/site-packages, /usr/bin
I don't see other packages adding these directories so it's probably fine?
yes, this package cannot own directories used by many other packages
[ ]: Package contains desktop file if it is a GUI application.
There's none -- should we add one?
I have added one
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
I assume no signature upstream ?
No signature upstream
[ ]: %check is present and all tests pass.
no check, but it's hard to check a gui...
The basic "%pyproject_check_import" test is there
[ ]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define srcname modules-gui
I guess that one should be changed to %global.
Fixed
Best regards,
Xavier
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2271737
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...