Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739347
--- Comment #4 from Jiri Hladky <hladky.jiri(a)gmail.com> 2011-09-21 19:17:56 EDT ---
(In reply to comment #1)
Hi Jussi,
please see my comments bellow:
Patch0 doesn't have a comment in the spec file. Please document
what it does.
It's coming update to the version 1.3 of haveged. I have documented it now in
the SPEC file.
Is there any reason why you macroize everything? Why not run just
automake,
make and so on?
Not really. I was not sure which way is preferred. I have changed
it now to rm,
make, install and so on.
Is SMP build not supported?
It's supported. I have just
added it.
Please use cp or install instead of mv in %install, so that
shortcutting builds
work.
Done.
Besides, why do you
%{__mv} init.d/haveged_fedora %{buildroot}%{_initrddir}/haveged
%{__rm} -rf %{buildroot}/etc/init.d
since at least on F15
$ rpm --eval %{_initrddir}
/etc/rc.d/init.d
$ file /etc/init.d
/etc/init.d: symbolic link to `rc.d/init.d'
Changed it to
rm -rf %{buildroot}/etc/init.d
install -m755 -D init.d/haveged_fedora %{buildroot}%{_initrddir}/haveged
Since /etc/init.d is a symbolic link I believe it's better to install files
into the master directory %{_initrddir} == /etc/rc.d/init.d
Besides that, I prefer to use MACRO %{_initddir} instead of
%{_sysconfdir}/init.d (which would expand to /etc/init.d)
Please let me know your opinion on this. Is there a reason to prefer
/etc/init.d over /etc/rc.d/init.d? Is there a macro that expands to /etc/init.d
??
New SPEC File and SRPM:
Spec URL:
http://jhladky.fedorapeople.org/hwloc-1.0.2-1.spec
SRPM URL:
http://jhladky.fedorapeople.org/haveged-1.2-1.fc14.src.rpm
Scratch build:
koji build --scratch dist-f15 SRPMS/haveged-1.2-1.fc14.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=3369279
Thanks for the input!
Jirka
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.