[Bug 1429804] Review Request: parfait - Java libraries for Performance Co-Pilot (PCP)

https://bugzilla.redhat.com/show_bug.cgi?id=1429804

gil cattaneo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from gil cattaneo  ---
These ifile are not admitted in Fedora. Please, remove

BuildRequires: maven-shade-plugin

%pom_remove_plugin -r :maven-shade-plugin

pushd parfait-agent/target
install -m 644 parfait-agent-jar-with-dependencies.jar \
            %{buildroot}%{_javadir}/parfait/parfait.jar
popd
# special install of with-all-dependencies sample jar files
for example in acme sleep counter
do
    pushd examples/${example}/target
    install -m 644 example-${example}-jar-with-dependencies.jar \
                %{buildroot}%{_javadir}/parfait/${example}.jar
    popd
done

Please, remove also:
"Requires: java-headless >= 1.8" already listed as requirement by our java
tools by default
"%dir %{_javadir}/parfait" already listed in

"Group: ..." not MORE necessary

Please, change "%global disable_dropwizard 1" with "%bcond_with metrics". and
%if !%{disable_dropwizard}
BuildRequires: mvn(com.codahale.metrics:metrics-core)
%endif

with

%if %{with metrics}
BuildRequires: mvn(com.codahale.metrics:metrics-core)
%endif

and

%if %{disable_dropwizard}
%pom_disable_module parfait-dropwizard
%endif

with

%if %{without metrics}
%pom_disable_module parfait-dropwizard
%endif