[Bug 666726] New: Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: Amide - A Medical Image Data Examiner:

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Summary: Review Request: Amide - A Medical Image Data Examiner:
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://susmit.fedorapeople.org/packaging/amide/amide.spec
SRPM URL:
http://susmit.fedorapeople.org/packaging/amide/amide-0.9.2-1.fc14.src.rpm
Description: Amide's a Medical Image Data Examiner: Amide is a tool for
viewing, registering, and analyzing anatomical and functional volumetric
medical imaging data sets.

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #1 from Susmit  2011-01-02 11:50:01 EST ---
Note:
Contact upstream about the patch.

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Christoph Wickert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |673841(fedora-medical)

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Christoph Wickert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Christoph Wickert  2011-01-30 16:19:00 EST ---
The package build-requires ffmpeg-devel, so there is no chance to have it in
Fedora. Let's see if we can build it without ffmpeg.

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Christoph Wickert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #3 from Christoph Wickert  2011-01-30 18:44:47 EST ---
Live from FUDCon Tempe here are new packages with a ton of review fixes:

SRPM: http://cwickert.fedorapeople.org/review/amide-0.9.2-2.fc15.src.rpm
SPEC: http://cwickert.fedorapeople.org/review/amide.spec

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Christoph Wickert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #4 from Christoph Wickert  2011-01-30 18:47:19 EST ---
OK - MUST: pmlint /var/lib/mock/fedora-rawhide-x86_64/result/amide-*
4 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines
OK - MUST: License field in spec file matches the actual license: GPLv2+
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5
0d40364f35011fd8a1a2e87512aceb1d
OK - MUST: successfully compiles and builds into binary rpms on x86_64
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
OK - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Package does not bundle copies of system libraries.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK- MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: library files that end in .so are in the -devel package.
OK - MUST: devel packages must require the base package using a fully versioned
dependency
OK - MUST: The package does not contain any .la libtool archives.
OK - MUST: The package contains a GUI application and includes a
%{name}.desktop file, and that file is properly installed with
desktop-file-install in the %install section.
OK - MUST: package does not own files or directories already owned by other
packages.
OK - Should: at the beginning of %install, the package runs rm -rf
$RPM_BUILD_ROOT
OK - MUST: all filenames valid UTF-8

SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
OK - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
N/A - SHOULD: Scriptlets are sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
OK - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
OK - SHOULD: package should contain man pages for binaries/scripts.

Other items:
OK - latest stable version
OK - SourceURL valid
OK - Compiler flags ok
OK - Debuginfo complete
OK - SHOULD: package has a %clean section, which contains rm -rf
$RPM_BUILD_ROOT
N/A - SHOULD: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.

APPROVED!

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #5 from Susmit  2011-01-30 18:48:06 EST ---
Great, Thanks a lot Christoph.

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Susmit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #6 from Susmit  2011-02-01 12:44:52 EST ---
New Package SCM Request
=======================
Package Name: amide
Short Description: A Medical Image Data Examiner
Owners: Susmit
Branches: f14
InitialCC:

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #7 from Bill Nottingham  2011-02-02 17:34:56 EST ---
Please fix the package owner to match the FAS account name.

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #8 from Susmit  2011-02-02 17:41:00 EST ---
My user name *is* susmit, is it case sensitive?

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #9 from Susmit  2011-02-02 17:41:11 EST ---
New Package SCM Request
=======================
Package Name: amide
Short Description: A Medical Image Data Examiner
Owners: susmit
Branches: f14
InitialCC:

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #10 from Christoph Wickert  2011-02-02 17:44:33 EST ---
(In reply to comment #8)
> My user name *is* susmit, is it case sensitive?

Yes.

[Bug 666726] Review Request: Amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #11 from Kevin Fenzi  2011-02-03 15:22:34 EST ---
Also, is the package amide or Amide? The summary and the package name don't
match. ;(

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Susmit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: Amide - A   |Review Request: amide - A
                   |Medical Image Data          |Medical Image Data
                   |Examiner:                   |Examiner:

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #12 from Susmit  2011-02-03 15:37:45 EST ---
I have updated the wiki with the information. It was no where mentioned in the
wiki that these fields are case sensitive.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #13 from Susmit  2011-02-03 15:37:58 EST ---
New Package SCM Request
=======================
Package Name: amide
Short Description: A Medical Image Data Examiner
Owners: susmit
Branches: f14
InitialCC:

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Susmit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #14 from Kevin Fenzi  2011-02-06 17:50:41 EST ---
Git done (by process-git-requests).

Sorry on the case sensitive fields.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Susmit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2011-02-06 21:45:31

--- Comment #15 from Susmit  2011-02-06 21:45:31 EST ---
Thank you very much. It has been pushed to koji.
CLosing as NEXTRELEASE.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Andreas Loening  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
                 CC|                            |[e-mail]
         Resolution|NEXTRELEASE                 |
           Keywords|                            |Reopened

--- Comment #16 from Andreas Loening  2011-02-08 00:14:11 EST ---
Hi Susmit,

Sorry, but I would prefer if you did not push this into Fedora at the current
time.

AMIDE is dependent on both the dcmtk and xmedcon libraries that are not
currently in Fedora. Even though you can build amide without these libraries,
it's close to useless without these libraries. It'd be like distributing a
version of GIMP that couldn't read/write jpeg, png, or tiff. This is not the
user experience that I want people to have with this application. I've been
holding off on submitting this package myself for that very reason.

There's ongoing work to get DCMTK properly packaged for Fedora.
https://bugzilla.redhat.com/show_bug.cgi?id=573910

If somebody wants to take on packaging xmedcon (http://xmedcon.sf.net), that'd
also be useful.

Andy

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #17 from Susmit  2011-02-27 23:21:19 EST ---
Retired for time being.
Will take up again once xmedcon and DCMTK is packaged.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Depends on|                            |573910(dcmtk)

--- Comment #18 from Peter Lemenkov  2011-04-22 04:00:25 EDT ---
DCMTK is available in Fedora finally, so it's time to continue.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #19 from Susmit  2011-04-22 23:37:54 EDT ---
Thanks for the heads up, but xmedcon is still not.
I am not sure is that would be useful without it.
Andy?

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Ankur Sinha  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Alias|                            |amide

Bug 666726 depends on bug 573910, which changed state.

Bug 573910 Summary: Review Request: dcmtk - Offis DICOM Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=573910

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Ankur Sinha  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |714328(xmedcon)

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #20 from Andreas Loening  2011-06-18 18:09:19 EDT ---
Hey Susmit. I think getting AMIDE into Fedora should still wait on getting
xmedcon into Fedora. Till then, people can just download the rpm package
directly off the AMIDE website.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Bug 666726 depends on bug 714328, which changed state.

Bug 714328 Summary: Review Request: xmedcon - A medical image conversion utility and library
https://bugzilla.redhat.com/show_bug.cgi?id=714328

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |MODIFIED
         Resolution|                            |CURRENTRELEASE
             Status|MODIFIED                    |CLOSED

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #21 from Ankur Sinha  2011-08-10 13:51:17 EDT ---
Hello,

xmedcon has been packaged in fedora. Susmit, would you continue with this
package? If you don't want to, please close this ticket. I shall open a fresh
ticket.

Thanks,
Ankur

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #22 from Christoph Wickert  2011-08-26 05:45:11 EDT ---
I have built amide with xmedcon and dcmtk now, see
http://koji.fedoraproject.org/koji/taskinfo?taskID=3302474

Ankur, please push xmedcon to F14-F15 updates released so I can build the other
releases and then close this bug.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #23 from Fedora Update System  2011-10-06 18:57:14 EDT ---
amide-0.9.2-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/amide-0.9.2-4.fc14

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #24 from Fedora Update System  2011-10-06 18:57:27 EDT ---
amide-0.9.2-4.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/amide-0.9.2-4.fc16

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

--- Comment #25 from Fedora Update System  2011-10-06 18:58:26 EDT ---
amide-0.9.2-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/amide-0.9.2-4.fc15

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Christoph Wickert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|2011-02-06 21:45:31         |2011-10-06 18:59:57

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |amide-1.0.0-1.fc16
         Resolution|NEXTRELEASE                 |ERRATA

--- Comment #26 from Fedora Update System  2011-10-19 00:28:06 EDT ---
amide-1.0.0-1.fc16 has been pushed to the Fedora 16 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|amide-1.0.0-1.fc16          |amide-1.0.0-1.fc15

--- Comment #27 from Fedora Update System  2011-10-20 05:56:22 EDT ---
amide-1.0.0-1.fc15 has been pushed to the Fedora 15 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 666726] Review Request: amide - A Medical Image Data Examiner:

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666726

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|amide-1.0.0-1.fc15          |amide-1.0.0-1.fc14

--- Comment #28 from Fedora Update System  2011-10-20 06:00:01 EDT ---
amide-1.0.0-1.fc14 has been pushed to the Fedora 14 stable repository.