https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Bug ID: 2279594 Summary: Review Request: ptyxis - A container oriented terminal Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nmontero@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://nmontero.fedorapeople.org/ SRPM URL: https://nmontero.fedorapeople.org/ Description: Ptyxis is a terminal which attempts to simplify what it means to be a terminal in the age of operating systems which are themselves containers. Fedora Account System Username: nmontero
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Cannot find any valid SRPM URL for this ticket. Common causes are:
- You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Nieves nmontero@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|medium |low Severity|medium |low
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com
--- Comment #3 from Parag AN(पराग) panemade@gmail.com --- Spec URL: https://nmontero.fedorapeople.org/ptyxis.spec SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.1-1.fc41.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #4 from Parag AN(पराग) panemade@gmail.com --- Nieves, package is not building because of missing build dependency on libportal-gtk4 package. You may want to add it as in SPEC file
%global libportal_gtk4_version 0.7.1 BuildRequires: pkgconfig(libportal-gtk4) >= %{libportal_gtk4_version}
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #5 from Nieves nmontero@redhat.com --- (In reply to Parag AN(पराग) from comment #4)
Nieves, package is not building because of missing build dependency on libportal-gtk4 package. You may want to add it as in SPEC file
%global libportal_gtk4_version 0.7.1 BuildRequires: pkgconfig(libportal-gtk4) >= %{libportal_gtk4_version}
Sorry for that. I added the lines, let me know if there's something else should be added/modified.
Thanks
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Nieves nmontero@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://nmontero.fedorapeople.org/ptyxis.spec SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.1-1.fc41.src.rpm Description: Ptyxis is a terminal which attempts to simplify what it means to be a terminal in the age of operating systems which are themselves containers. Fedora Account System Username: nmontero
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- You need to update SRPM file also. Always update SPEC and SRPM at same time. I tried new updated SRPM file and found its failing to build.
See this rawhide scratch build -> https://koji.fedoraproject.org/koji/taskinfo?taskID=117469363
You may want to fix the compilation errors.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- This also needs "Requires: hicolor-icon-theme".
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #8 from Michael Catanzaro mcatanza@redhat.com --- Please also build with -Dgeneric=terminal to remove the Ptyxis branding, so we can use it as the default terminal in Fedora Workstation. (And no need to use -Ddevelopment=false, because that's already the upstream default setting.)
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #9 from Nieves nmontero@redhat.com --- (In reply to Michael Catanzaro from comment #8)
Please also build with -Dgeneric=terminal to remove the Ptyxis branding, so we can use it as the default terminal in Fedora Workstation. (And no need to use -Ddevelopment=false, because that's already the upstream default setting.)
Sure, I will modify it.
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
--- Comment #10 from Nieves nmontero@redhat.com --- Both spec and srpm files are already updated on fedora people: Spec URL: https://nmontero.fedorapeople.org/ptyxis.spec SRPM URL: https://nmontero.fedorapeople.org/ptyxis-46.1-1.fc41.src.rpm
The package is already building and ready to continue
https://bugzilla.redhat.com/show_bug.cgi?id=2279594
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://gitlab.gnome.org/ch | |ergert/ptyxis
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7671470 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org