https://bugzilla.redhat.com/show_bug.cgi?id=1728746
Bug ID: 1728746 Summary: Review Request: apache-mime4j - Apache JAMES Mime4j Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/packages/apache-mime4j.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/apache-mime4j-0.8.1-4.fc30.src....
Description: Java stream based MIME message parser.
Fedora Account System Username: decathorpe
NOTE: This is a re-review for a previously retired package. The packaging is based on the original package before it was retired, including some cleanups.
https://bugzilla.redhat.com/show_bug.cgi?id=1728746
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mhroncok@redhat.com Assignee|nobody@fedoraproject.org |mhroncok@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1728746
--- Comment #1 from Miro Hrončok mhroncok@redhat.com --- Running a couple of scratchbuilds on various arches...
If they are build, this will get approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1728746
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Great!
By the way, 0.8.1 is not the latest version, but the last version that was available in fedora. I think updating the package to 0.8.3 at the same time as un-retiring it just is asking for trouble. I can submit a pull request (and do test rebuilds) for the version update after it's available in fedora again.
https://bugzilla.redhat.com/show_bug.cgi?id=1728746
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- Package Review ==============
This package is APPROVED, assuming this armv7hl build finishes OK (it takes ages and I gotta go, but please wait for it).
https://koji.fedoraproject.org/koji/taskinfo?taskID=36169514
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Java: [x]: Bundled jar/class files should be removed before build
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: apache-mime4j-0.8.1-4.fc31.noarch.rpm apache-mime4j-javadoc-0.8.1-4.fc31.noarch.rpm apache-mime4j-0.8.1-4.fc31.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Source checksums ---------------- http://archive.apache.org/dist/james/mime4j/0.8.1/james-mime4j-sources-0.8.1... : CHECKSUM(SHA256) this package : 99ac2aac5ebea6dafca20039ae679e99916209f65f3359b00a9f708140621129 CHECKSUM(SHA256) upstream package : 99ac2aac5ebea6dafca20039ae679e99916209f65f3359b00a9f708140621129
Requires -------- apache-mime4j (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(com.google.guava:guava:18.0) mvn(commons-io:commons-io) mvn(commons-logging:commons-logging) mvn(org.slf4j:slf4j-api)
apache-mime4j-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem
Provides -------- apache-mime4j: apache-mime4j mvn(org.apache.james:apache-mime4j-benchmark) mvn(org.apache.james:apache-mime4j-benchmark:pom:) mvn(org.apache.james:apache-mime4j-core) mvn(org.apache.james:apache-mime4j-core:pom:) mvn(org.apache.james:apache-mime4j-dom) mvn(org.apache.james:apache-mime4j-dom:pom:) mvn(org.apache.james:apache-mime4j-examples) mvn(org.apache.james:apache-mime4j-examples:pom:) mvn(org.apache.james:apache-mime4j-james-utils) mvn(org.apache.james:apache-mime4j-james-utils:pom:) mvn(org.apache.james:apache-mime4j-mbox-iterator) mvn(org.apache.james:apache-mime4j-mbox-iterator:pom:) mvn(org.apache.james:apache-mime4j-project:pom:) mvn(org.apache.james:apache-mime4j-storage) mvn(org.apache.james:apache-mime4j-storage:pom:) osgi(org.apache.james.apache-mime4j-benchmark) osgi(org.apache.james.apache-mime4j-core) osgi(org.apache.james.apache-mime4j-dom) osgi(org.apache.james.apache-mime4j-examples) osgi(org.apache.james.apache-mime4j-james-utils) osgi(org.apache.james.apache-mime4j-mbox-iterator) osgi(org.apache.james.apache-mime4j-storage)
apache-mime4j-javadoc: apache-mime4j-javadoc
https://bugzilla.redhat.com/show_bug.cgi?id=1728746
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- I've been watching that build already :) If it passes, I'll request the package unretirement. Thanks for the quick review!
https://bugzilla.redhat.com/show_bug.cgi?id=1728746
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |apache-mime4j-0.8.1-4.fc31 Resolution|--- |RAWHIDE Last Closed| |2019-07-11 11:23:06
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Built for rawhide. Thanks!
https://koji.fedoraproject.org/koji/buildinfo?buildID=1311647
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com