[Bug 2281487] New: Review Request: logdetective - Uses LLM AI to search for build/test failure and provide ideas how to fix it
7:39 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Bug ID: 2281487
Summary: Review Request: logdetective - Uses LLM AI to search
for build/test failure and provide ideas how to fix it
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: msuchy(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://download.copr.fedorainfracloud.org/results/msuchy/package-review/...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/msuchy/package-review/...
Description:
A Python tool to analyze logs using a Language Model (LLM) and Drain template
miner.
Fedora Account System Username:
msuchy
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
2:47 p.m.
New subject: [Bug 2281487] Review Request: logdetective - Uses LLM AI to search
for build/test failure and provide ideas how to fix it
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Fedora Review Service <fedora-review-bot(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://pypi.org/project/lo
| |gdetective/
Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org> ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7461865
(succeeded)
Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...
Please take a look if any issues were found.
---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
10:15 a.m.
New subject: [Bug 2281487] Review Request: logdetective - Uses LLM AI to search
for build/test failure and provide ideas how to fix it
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Tomas Tomecek <ttomecek(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ttomecek(a)redhat.com
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |ttomecek(a)redhat.com
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
10:16 a.m.
New subject: [Bug 2281487] Review Request: logdetective - Uses LLM AI to search
for build/test failure and provide ideas how to fix it
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Tomas Tomecek <ttomecek(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
10:40 a.m.
New subject: [Bug 2281487] Review Request: logdetective - Uses LLM AI to search
for build/test failure and provide ideas how to fix it
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Tomas Tomecek <ttomecek(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Tomas Tomecek <ttomecek(a)redhat.com> ---
Very nice work, approved.
Just one question: why not name the package just logdetective instead of
python3-logdetective?
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* Apache License 2.0", "Unknown or
generated",
"*No copyright* Apache License". 3 files have unknown license.
Detailed output of licensecheck in
~/2281487-python-logdetective/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 1970 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-logdetective-0.2.0-1.fc41.noarch.rpm
python-logdetective-0.2.0-1.fc41.src.rpm
====================================================================================================================
rpmlint session starts
====================================================================================================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpgxw2a3le')]
checks: 32, packages: 2
python-logdetective.spec:26: W: unversioned-explicit-provides logdetective
python3-logdetective.noarch: W: no-manual-page-for-binary logdetective
==============================================================================
2 packages and 0 specfiles checked; 0 errors, 2 warnings, 12 filtered, 0
badness; has taken 0.5 s
===============================================================================
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1
python3-logdetective.noarch: W: no-manual-page-for-binary logdetective
1 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0
badness; has taken 0.1 s
Source checksums
----------------
https://files.pythonhosted.org/packages/source/l/logdetective/logdetectiv...
:
CHECKSUM(SHA256) this package :
547c3c4e4c6edd4ef2362f63456f6634ffd3a24c20c3427f531d31d657ae4fe7
CHECKSUM(SHA256) upstream package :
547c3c4e4c6edd4ef2362f63456f6634ffd3a24c20c3427f531d31d657ae4fe7
Requires
--------
python3-logdetective (rpmlib, GLIBC filtered):
(python3.12dist(drain3) < 0.10~~ with python3.12dist(drain3) >= 0.9.11)
(python3.12dist(llama-cpp-python) < 0.3~~ with
python3.12dist(llama-cpp-python) >= 0.2.56)
(python3.12dist(requests) < 3~~ with python3.12dist(requests) >= 2.31)
(python3.12dist(tiktoken) < 0.7~~ with python3.12dist(tiktoken) >= 0.6)
/usr/bin/python3
python(abi)
python3.12dist(progressbar2)
Provides
--------
python3-logdetective:
logdetective
python-logdetective
python3-logdetective
python3.12-logdetective
python3.12dist(logdetective)
python3dist(logdetective)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2281487
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: Ocaml, R, PHP, Haskell, Java, fonts, C/C++, SugarActivity,
Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
6:34 a.m.
New subject: [Bug 2281487] Review Request: logdetective - Uses LLM AI to search
for build/test failure and provide ideas how to fix it
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
--- Comment #3 from Miroslav Suchý <msuchy(a)redhat.com> ---
Just one question: why not name the package just logdetective instead
of python3-logdetective?
I thought about it and:
python3-logtective
Pro: it is on Pypi, lets use the python-foo notation as mandated in
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming
Cons: hard to find if people tries to `dnf install logdetective` - but this can
be resolved by added provides. (I did that).
logtective
Pro: it is leaf package, likely does not need to follow python guidelines
regarding naming, easier for people trying to `dnf install`
Cons: can confuse other contributor that finds pypi module and looking for
python-logdetective in fedora.
In the end, I went with the first option. But I was about 50:50 about this.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
8:59 a.m.
New subject: [Bug 2281487] Review Request: python-logdetective - Uses LLM AI to
search for build/test failure and provide ideas how to fix it
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Miroslav Suchý <msuchy(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review Request: |Review Request:
|logdetective - Uses LLM AI |python-logdetective - Uses
|to search for build/test |LLM AI to search for
|failure and provide ideas |build/test failure and
|how to fix it |provide ideas how to fix it
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
9:01 a.m.
New subject: [Bug 2281487] Review Request: python-logdetective - Uses LLM AI to
search for build/test failure and provide ideas how to fix it
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
--- Comment #4 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org> ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-logdetective
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
3:01 a.m.
New subject: [Bug 2281487] Review Request: python-logdetective - Uses LLM AI to
search for build/test failure and provide ideas how to fix it
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Miroslav Suchý <msuchy(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2024-05-23 08:01:56
--- Comment #5 from Miroslav Suchý <msuchy(a)redhat.com> ---
https://koji.fedoraproject.org/koji/taskinfo?taskID=118032638
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2281487
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
34
days inactive
38
days old
package-review@lists.fedoraproject.org
8 comments
1 participants
participants (1)
-
bugzilla＠redhat.com