[Bug 513775] New: Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pyfuzzy - Python framework for fuzzy sets

https://bugzilla.redhat.com/show_bug.cgi?id=513775

           Summary: Review Request: pyfuzzy - Python framework for fuzzy
                    sets
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: fabian(a)bernewireless.net
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy-0.0.2-1.fc11.src.rpm

Project URL: https://sourceforge.net/projects/pyfuzzy/

Description:
pyfuzzy is a framework to work with fuzzy sets and process them with
operations of fuzzy logic.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1513784

rpmlint output:
[fab@laptop09 SRPMS]$ rpmlint pyfuzzy-0.0.2-1.fc11.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop09 noarch]$ rpmlint pyfuzzy-0.0.2-1.fc11.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775


Mads Kiilerich <mads(a)kiilerich.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mads(a)kiilerich.com




--- Comment #1 from Mads Kiilerich <mads(a)kiilerich.com&gt;  2009-07-25 20:29:41 EDT
---
After a briew review I wanted to point out that the license is GPL, not GPL+
... but ... you are right, GPL is GPL+.

Sligtly annoying that the rpm with the name pyfuzzy and with a pyfuzzy egg
occupies the name fuzzy from the namespace. IMHO python-fuzzy would have been
more appropriate, but who cares ...

nuff said

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775


Jason Tibbitts <tibbs(a)math.uh.edu&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody(a)fedoraproject.org    |tibbs(a)math.uh.edu
               Flag|                            |fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #2 from Jason Tibbitts <tibbs(a)math.uh.edu&gt;  2009-07-29 20:24:40 EDT ---
Well, the name is correct according to the guidelines.  The upstream project is
'pyfuzzy', the tarball is 'pyfuzy', and it has 'py' in the name so
no 'python-'
prefix is necessary.  'python-fuzzy', on the other hand, would be against the
guidelines.  Perl at least has this handled with the 'perl(Foo::Bar)' automatic
dependencies.

Also, GPL and GPL+ are not the same thing, as the author could choose not to
use the "any later version" option.  Of course, they didn't actually
specify
anything but "GPL" in one place, but Fabian has already requested that upstream
fix that up so in the meantime we assume GPL+.  Of course, upstream seems to be
completely idle for the past six years, so...

There's a test suite.  You can call the individual tests with:
  %check
  cd test
  export PYTHONPATH=%{buildroot}/%{python_sitelib}
  ./test_defuzzyfication.py
  ./test_merge.py
  ./test_norm.py
  ./test_set.py
(or you could use a loop or something).  However, only test_defuzzyfication
seems to work.  It looks like there may be an issue with outdated python
syntax.  Could you double-check?  If the module has issues with python 2.6 then
it would be better to know that up front instead of after it gets imported and
built.


* source files match upstream.  sha256sum:            
   c3cc76ad5283e38b540db29b1cb56fff671fbe0d94a2808fa219896833f5a417
   pyfuzzy-0.0.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   pyfuzzy = 0.0.2-1.fc12
  =
   gnuplot
   python(abi) = 2.6

? %check is not present, but there seem to be some tests.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.


The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #3 from Fabian Affolter <fabian(a)bernewireless.net&gt;  2009-07-31 09:22:40
EDT ---
I reported all issues upstream.  It's right that there was no release in the
last 6 years but there was some action in the VCS in January.

All issues are reported upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #4 from Fabian Affolter <fabian(a)bernewireless.net&gt;  2009-07-31 09:24:01
EDT ---
http://sourceforge.net/tracker/?group_id=59160&atid=490101

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775


Fabian Affolter <fabian(a)bernewireless.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |NotReady




--- Comment #5 from Fabian Affolter <fabian(a)bernewireless.net&gt;  2009-10-07 10:09:12
EDT ---
According to upstream a new release will come out soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #6 from Jason Tibbitts <tibbs(a)math.uh.edu&gt;  2009-11-03 10:37:49 EDT ---
Any update?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #7 from Fabian Affolter <fabian(a)bernewireless.net&gt;  2009-11-13 15:32:42
EDT ---
The guy from upstream is still working on a new release.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #8 from René Liebscher <R.Liebscher(a)gmx.de&gt;  2009-11-14 08:46:43 EDT
---
Hi, I am always working on new releases, but you might have missed the last one
from 2009-10-18, see https://sourceforge.net/projects/pyfuzzy/files/.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #9 from Fabian Affolter <fabian(a)bernewireless.net&gt;  2009-11-14 11:44:13
EDT ---
Hmmm, I missed that. I will provide a new package soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #10 from Fabian Affolter <fabian(a)bernewireless.net&gt;  2009-11-20 17:05:59
EDT ---
Here are the updated files

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy-0.1.0-1.fc11.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1820590

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775





--- Comment #11 from Jason Tibbitts <tibbs(a)math.uh.edu&gt;  2010-01-07 18:29:29 EDT
---
I seem to have let this fall through the cracks, sorry about that.  The current
version builds fine and rpmlint is silent.

The license of the code seems to be LGPLv3+.  LICENSE.txt has the LGPLv3 text,
and the source files all seem to have the proper LGPLv3 license block with the
"any later version" text, and setup.py says "LGPL".  Did I miss
something?

I don't see any mention of the test suite in your comments, but the test files
seem to have disappeared in the latest source so I suppose that's OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775

--- Comment #12 from Fabian Affolter <fabian(a)bernewireless.net&gt; 2010-02-24 16:06:44
EST ---
(In reply to comment #11)
>  The license of the code seems to be LGPLv3+.  LICENSE.txt has the
> LGPLv3 text,
>  and the source files all seem to have the proper LGPLv3 license block with the
>  "any later version" text, and setup.py says "LGPL".  Did I miss
> something? 
The license is LGPLv3+

>  I don't see any mention of the test suite in your comments, but
> the test files
>  seem to have disappeared in the latest source so I suppose that's OK.     
Starting with 0.1.0 the test suite is no longer included. 

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/pyfuzzy-0.1.0-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775

Fabian Affolter <fabian(a)bernewireless.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|NotReady                    |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775

Jason Tibbitts <tibbs(a)math.uh.edu&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #13 from Jason Tibbitts <tibbs(a)math.uh.edu&gt; 2010-11-18 08:52:13 EST ---
Looks good, thanks.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775

Fabian Affolter <fabian(a)bernewireless.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #14 from Fabian Affolter <fabian(a)bernewireless.net&gt; 2010-11-20 08:05:14
EST ---
New Package SCM Request
=======================
Package Name: pyfuzzy
Short Description: Python framework for fuzzy sets
Owners: fab
Branches: F-14 F-13
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775

--- Comment #15 from Jason Tibbitts <tibbs(a)math.uh.edu&gt; 2010-11-22 08:43:49 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775

--- Comment #16 from Jason Tibbitts <tibbs(a)math.uh.edu&gt; 2010-12-22 12:33:42 EST ---
Is there any reason why this ticket is still open?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 513775] Review Request: pyfuzzy - Python framework for fuzzy sets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513775

Fabian Affolter <fabian(a)bernewireless.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2011-01-03 15:40:24

--- Comment #17 from Fabian Affolter <fabian(a)bernewireless.net&gt; 2011-01-03 15:40:24
EST ---
No

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.