[Bug 606071] New: Review Request: vinetto - A forensics tool to examine Thumbs.db files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: vinetto - A forensics tool to examine Thumbs.db files

https://bugzilla.redhat.com/show_bug.cgi?id=606071

           Summary: Review Request: vinetto - A forensics tool to examine
                    Thumbs.db files
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: fabian(a)bernewireless.net
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL: http://fab.fedorapeople.org/packages/SRPMS/vinetto.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/vinetto-0.07-1.beta.fc13.src.rpm

Project URL: http://vinetto.sourceforge.net/

Description:
Vinetto is a forensics tool to examine Thumbs.db files.  It is
a console program to extract thumbnail images and their metadata
from those thumbs.db files generated under Microsoft Windows

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2259799

rpmlint output:
[fab@laptop011 SRPMS]$ rpmlint vinetto-0.07-1.beta.fc13.src.rpm 
vinetto.src: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsus
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[fab@laptop011 noarch]$ rpmlint vinetto-0.07-1.beta.fc13.noarch.rpm 
vinetto.noarch: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsus
vinetto.noarch: W: no-manual-page-for-binary vinetto
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

Fabian Affolter <fabian(a)bernewireless.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |563471(FE-SECLAB)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

Fabian Affolter <fabian(a)bernewireless.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |vinetto

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

Michael Schwendt <mschwendt(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mschwendt(a)gmail.com

--- Comment #1 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2010-06-22 06:34:01 EDT
---
* The --version arg and program output report 0.06 (r59) which doesn't match
RPM package version. // egg-info even refers to 0.06alpha


* The --help arg and Usage output claim that the  -o DIR  arg is optional, but
when omitting -o DIR, the program crashes:

$ vinetto Thumbs.db 
/usr/bin/vinetto:35: DeprecationWarning: the md5 module is deprecated; use
hashlib instead
  import md5
Traceback (most recent call last):
  File "/usr/bin/vinetto", line 114, in <module>
    tDBfname, outputdir, htmlrep, utf8encoding, symlinks = getargs()
  File "/usr/bin/vinetto", line 77, in getargs
    os.system("mkdir " + opts.outputdir + "/" + NUMBERED_THUMBS_DIR)
TypeError: cannot concatenate 'str' and 'NoneType' objects


* Something else is wrong with the -o DIR arg, too. If the target directory
doesn't exist, vinetto creates only half of the target dirs and then fails.
os.system("mkdir",...) is insufficient, and it should either bail out sooner or
use os.makedirs(...) properly.


* For such a small program with no manual, no examples in the README, and a
warning that only one type of Thumbs.db files is understood, I think the
software isn't ready yet.

| SHOULD: The reviewer should test that the package functions as
| described. A package should not segfault instead of running,
| for example.


* The good news: The packaging is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

--- Comment #2 from Fabian Affolter <fabian(a)bernewireless.net&gt; 2010-06-22 14:41:05
EDT ---
My bad.  Next time I should check the upstream bug tracker first and not let
the reviewer find bugs. Sorry for that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

Fabian Affolter <fabian(a)bernewireless.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |NotReady

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

Fabian Affolter <fabian(a)bernewireless.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |WONTFIX
        Last Closed|                            |2011-01-03 15:39:13

--- Comment #3 from Fabian Affolter <fabian(a)bernewireless.net&gt; 2011-01-03 15:39:13
EST ---
Upstream seems to be dead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.