3:53 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
Bug ID: 1424632
Summary: Review Request: python-iso3166 - Self-contained ISO
3166-1 country definitions
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: pikachu.2014(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://melmorabity.fedorapeople.org/packages/python-iso3166/python-iso31...
SRPM URL:
https://melmorabity.fedorapeople.org/packages/python-iso3166/python-iso31...
Description:
ISO 3166-1 defines two-letter, three-letter, and three-digit country
codes. python-iso3166 is a self-contained module that converts between these
codes and the corresponding country name.
Fedora Account System Username: melmorabity
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:36 a.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
Athos Ribeiro <athoscribeiro(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |athoscribeiro(a)gmail.com
Assignee|nobody(a)fedoraproject.org |athoscribeiro(a)gmail.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:54 a.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
Athos Ribeiro <athoscribeiro(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Athos Ribeiro <athoscribeiro(a)gmail.com> ---
Hello Mohamed,
For python3 packages, it os not a good idea to have
%{python3_sitelib}/*
because you may end up owning directories that you should not own.
This is not the case for your package though, but I suggest you be more
specific there since the package may change.
Is there any reason for not running the test suite for the package (upstream
does provide one)? If not, it would be nice to run the test suite in %check.
Package looks good. Approved.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python2-iso3166-0.8-1.fc26.noarch.rpm
python3-iso3166-0.8-1.fc26.noarch.rpm
python-iso3166-0.8-1.fc26.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires
--------
python3-iso3166 (rpmlib, GLIBC filtered):
python(abi)
python2-iso3166 (rpmlib, GLIBC filtered):
python(abi)
Provides
--------
python3-iso3166:
python3-iso3166
python3.6dist(iso3166)
python3dist(iso3166)
python2-iso3166:
python-iso3166
python2-iso3166
python2.7dist(iso3166)
python2dist(iso3166)
Source checksums
----------------
https://files.pythonhosted.org/packages/source/i/iso3166/iso3166-0.8.tar.gz :
CHECKSUM(SHA256) this package :
fbeb17bed90d15b1f6d6794aa2ea458e5e273a1d29b6f4939423c97640e14933
CHECKSUM(SHA256) upstream package :
fbeb17bed90d15b1f6d6794aa2ea458e5e273a1d29b6f4939423c97640e14933
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:09 a.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
--- Comment #2 from Mohamed El Morabity <pikachu.2014(a)gmail.com> ---
Hello Athos,
many thanks for your review!
(In reply to Athos Ribeiro from comment #1)
For python3 packages, it os not a good idea to have
%{python3_sitelib}/*
because you may end up owning directories that you should not own.
This is not the case for your package though, but I suggest you be more
specific there since the package may change.
I just followed the spec template on
the Python packaging guidelines page. But
you're right anyway. I'll be careful for further updates, I promise ;)
Is there any reason for not running the test suite for the package
(upstream
does provide one)? If not, it would be nice to run the test suite in %check.
Tests
are not available in the Pypi tarball. They're available on the Github
upstream repo. Unfortunately, there's no release tag published on this repo.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:35 p.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
--- Comment #3 from Jon Ciesla <limburgher(a)gmail.com> ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-iso3166
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:51 p.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
--- Comment #4 from Fedora Update System <updates(a)fedoraproject.org> ---
python-iso3166-0.8-1.fc25 python-streamlink-0.3.2-1.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c32857ef03
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:51 p.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:51 p.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org> ---
python-iso3166-0.8-1.fc24 python-streamlink-0.3.2-1.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1b050a4daf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:53 p.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
python-iso3166-0.8-1.fc24, python-streamlink-0.3.2-1.fc24 has been pushed to
the Fedora 24 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1b050a4daf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:08 p.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
python-iso3166-0.8-1.fc25, python-streamlink-0.3.2-1.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c32857ef03
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:50 p.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2017-03-02 22:50:02
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
python-iso3166-0.8-1.fc24, python-streamlink-0.3.2-1.fc24 has been pushed to
the Fedora 24 stable repository. If problems still persist, please make note of
it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:54 p.m.
New subject: [Bug 1424632] Review Request:
python-iso3166 - Self-contained ISO 3166-1 country definitions
https://bugzilla.redhat.com/show_bug.cgi?id=1424632
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
python-iso3166-0.8-1.fc25, python-streamlink-0.3.2-1.fc25 has been pushed to
the Fedora 25 stable repository. If problems still persist, please make note of
it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2647
days inactive
2661
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
bugzilla＠redhat.com