[Bug 1327979] New: Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

            Bug ID: 1327979
           Summary: Review Request: python-jupyter-notebook - A web-based
                    notebook environment for interactive computing
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: tomspur(a)fedoraproject.org
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org



Spec URL:
https://tomspur.fedorapeople.org/review/python-jupyter-notebook/python-ju...
SRPM URL:
https://tomspur.fedorapeople.org/review/python-jupyter-notebook/python-ju...
Description:
The Jupyter Notebook is a web application that allows you to create and
share
documents that contain live code, equations, visualizations, and
explanatory
text. The Notebook has support for multiple programming
languages, sharing, and
interactive widgets.

Fedora Account System Username: tomspur

This is the work in procress version of the python-jupyter-notebook as some
dependencies need to be reviewed first and will be added to this ticket as
dependency.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #1 from Thomas Spura <tomspur(a)fedoraproject.org&gt; ---
Should this package be named python-jupyter-notebook or simply python-notebook?
On pypi it is also just named notebook:
https://pypi.python.org/pypi/notebook

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Thomas Spura <tomspur(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1327981




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327981
[Bug 1327981] Review Request: python-ipykernel - IPython Kernel for Jupyter
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Thomas Spura <tomspur(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1327989




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327989
[Bug 1327989] Review Request: python-jupyter-client - Jupyter protocol
implementation and client libraries
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek(a)in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; ---
I think python-jupyter-notebook meshes better with python-jupyter-client and
python-jupyter-core. Easier to see that those packages go together.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Philippe Makowski <makowski.fedora(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |makowski.fedora(a)gmail.com



--- Comment #3 from Philippe Makowski <makowski.fedora(a)gmail.com&gt; ---
for info, here how I spitted the package in Mageia, like Debian did)
http://svnweb.mageia.org/packages/cauldron/jupyter-notebook/current/SPECS...

doc is not build yet, but should come later.

I think that the patch is needed (came from Debian) : 
http://svnweb.mageia.org/packages/cauldron/ipython/current/SOURCES/0001-u...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody(a)fedoraproject.org    |zbyszek(a)in.waw.pl
              Flags|                            |fedora-review?



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; ---
BR: python-sphinx_rtd_theme

Links in /bin/ should be updated similarly to python-jupyter-client.

%license.

Suggestion to use "%global _docdir_fmt %{name}".

%description should be word wrapped to 80 columns.
And since the description is longer than two sentences, it's nice to define a
%_description and then use '%description [subpackage ] %_description' to avoid
repeating the text.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Elliott Sales de Andrade <quantum.analyst(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |quantum.analyst(a)gmail.com



--- Comment #5 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com&gt; ---
This spec depends on python(3)-ipython-genutils, but the package is named
python(3)-ipython_genutils.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #6 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com&gt; ---
Also depends on python(3)-nbconvert for which I see no package request yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1327989, which changed state.

Bug 1327989 Summary: Review Request: python-jupyter-client - Jupyter protocol
implementation and client libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1327989

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1327989, which changed state.

Bug 1327989 Summary: Review Request: python-jupyter-client - Jupyter protocol
implementation and client libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1327989

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ON_QA
         Resolution|RAWHIDE                     |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Mukundan Ragavan <nonamedotc(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nonamedotc(a)gmail.com
         Depends On|                            |1379096



--- Comment #7 from Mukundan Ragavan <nonamedotc(a)gmail.com&gt; ---
(In reply to Elliott Sales de Andrade from comment #6)
>  Also depends on python(3)-nbconvert for which I see no package
> request yet. 
I have submitted a python-nbconvert review request but that depends on some
other stuff which I have also submitted,

https://bugzilla.redhat.com/show_bug.cgi?id=1379096



Added depends on.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1379096
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter
Notebooks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #8 from Thomas Spura <tomspur(a)fedoraproject.org&gt; ---
(In reply to Mukundan Ragavan from comment #7)
>  (In reply to Elliott Sales de Andrade from comment #6)
>  > Also depends on python(3)-nbconvert for which I see no package request yet.
>  
>  I have submitted a python-nbconvert review request but that depends on some
>  other stuff which I have also submitted, 

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1379096, which changed state.

Bug 1379096 Summary: Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1327989, which changed state.

Bug 1327989 Summary: Review Request: python-jupyter-client - Jupyter protocol
implementation and client libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1327989

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1327981, which changed state.

Bug 1327981 Summary: Review Request: python-ipykernel - IPython Kernel for Jupyter
https://bugzilla.redhat.com/show_bug.cgi?id=1327981

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; ---
Review update:

(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
>  Links in /bin/ should be updated similarly to python-jupyter-client.
Links are still reversed. It should be like this:
mv %{buildroot}/%{_bindir}/jupyter-nbextension
%{buildroot}/%{_bindir}/jupyter-nbextension-%{python3_version}
ln -s jupyter-nbextension-%{python3_version}
%{buildroot}/%{_bindir}/jupyter-nbextension-%{python3_pkgversion}
mv %{buildroot}/%{_bindir}/jupyter-serverextension
%{buildroot}/%{_bindir}/jupyter-serverextension-%{python3_version}
ln -s jupyter-serverextension-%{python3_version}
%{buildroot}/%{_bindir}/jupyter-serverextension-%{python3_pkgversion}
mv %{buildroot}/%{_bindir}/jupyter-notebook
%{buildroot}/%{_bindir}/jupyter-notebook-%{python3_version}
ln -s jupyter-notebook-%{python3_version}
%{buildroot}/%{_bindir}/jupyter-notebook-%{python3_pkgversion}

and similarly for the python2 version.

>  %license. 
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING.md is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

>  Suggestion to use "%global _docdir_fmt %{name}".
>  
>  %description should be word wrapped to 80 columns.
>  And since the description is longer than two sentences, it's nice to define
>  a %_description and then use '%description [subpackage ] %_description' to
>  avoid repeating the text. 
Still valid.

Can you post an updated spec file? It would be great to get this wrapped up
some time
before F26, leaving enough time for testing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Miro Hrončok <mhroncok(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mhroncok(a)redhat.com



--- Comment #10 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
I didn't have time to examine this closely, but a quick question:

What's the benefit of having both python2 and python3 notebooks?

Isn't it possible to just have the Python 3 version and install the Python 2
kernel to use it inside?

(I really don't know)

If the above is true but the notebook module is to be imported form other
packages, then keep the package split, but just include the executable in the
Python 3 subpackage.

Guidelines:

If the executables provide the same functionality independent of whether they
are run on top of Python 2 or Python 3, then only the Python 3 version of the
executable should be packaged. Transitioning from python2 to python3 is left to
individual package maintainers except for packages in Fedora's critical path.
For these, we want to port to python3 versions in the same Fedora release if
possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #11 from Thomas Spura <tomspur(a)fedoraproject.org&gt; ---
(In reply to Miro Hrončok from comment #10)
>  I didn't have time to examine this closely, but a quick
> question:
>  
>  What's the benefit of having both python2 and python3 notebooks?
>  
>  Isn't it possible to just have the Python 3 version and install the Python 2
>  kernel to use it inside?
>  
>  (I really don't know) 
This is true, but you could still use both base versions of the notebook and
decide between py3 vs py2. Debian also has both versions:
- https://packages.debian.org/de/sid/python3-notebook
- https://packages.debian.org/de/sid/python-notebook

>  If the above is true but the notebook module is to be imported form
> other
>  packages, then keep the package split, but just include the executable in
>  the Python 3 subpackage.
>  
>  Guidelines:
>  
>  If the executables provide the same functionality independent of whether
>  they are run on top of Python 2 or Python 3, then only the Python 3 version
>  of the executable should be packaged. Transitioning from python2 to python3
>  is left to individual package maintainers except for packages in Fedora's
>  critical path. For these, we want to port to python3 versions in the same
>  Fedora release if possible. 
I removed the executable from the python2-notebook.


(In reply to Zbigniew Jędrzejewski-Szmek from comment #9)
>  Review update:
>  
>  (In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
>  > Links in /bin/ should be updated similarly to python-jupyter-client.
>  
>  Links are still reversed. It should be like this:
>  mv %{buildroot}/%{_bindir}/jupyter-nbextension
>  %{buildroot}/%{_bindir}/jupyter-nbextension-%{python3_version}
>  ln -s jupyter-nbextension-%{python3_version}
>  %{buildroot}/%{_bindir}/jupyter-nbextension-%{python3_pkgversion}
>  mv %{buildroot}/%{_bindir}/jupyter-serverextension
>  %{buildroot}/%{_bindir}/jupyter-serverextension-%{python3_version}
>  ln -s jupyter-serverextension-%{python3_version}
>  %{buildroot}/%{_bindir}/jupyter-serverextension-%{python3_pkgversion}
>  mv %{buildroot}/%{_bindir}/jupyter-notebook
>  %{buildroot}/%{_bindir}/jupyter-notebook-%{python3_version}
>  ln -s jupyter-notebook-%{python3_version}
>  %{buildroot}/%{_bindir}/jupyter-notebook-%{python3_pkgversion} 
Changed.

>  and similarly for the python2 version. 
Removed (see above).

>  > %license. 
Added

>  - If (and only if) the source package includes the text of the
> license(s)
>    in its own file, then that file, containing the text of the license(s)
>    for the package is included in %license.
>    Note: License file COPYING.md is not marked as %license
>    See:
>    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
>  
>  > Suggestion to use "%global _docdir_fmt %{name}". 
Added

>  > %description should be word wrapped to 80 columns.
>  > And since the description is longer than two sentences, it's nice to define
>  > a %_description and then use '%description [subpackage ] %_description' to
>  > avoid repeating the text.
>  
>  Still valid. 
Changed

>  Can you post an updated spec file? It would be great to get this
> wrapped up
>  some time
>  before F26, leaving enough time for testing. 
Sorry for the delay... I would welcome (co-)maintainers as I find increasingly
less time to work on this, but want to have ipython updated in Fedora...


I would remove the -doc package altogether as it uses intersphinx during the
build.

%changelog
- rename to python-notebook
- only ship python3 executables
- update to 4.4.1

Spec URL:
https://tomspur.fedorapeople.org/review/python-jupyter-notebook/python-no...
SRPM URL:
https://tomspur.fedorapeople.org/review/python-jupyter-notebook/python-no...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Miro Hrončok <mhroncok(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1421610




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1421610
[Bug 1421610] Python Classroom Lab
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #12 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; ---
Links give 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #13 from Thomas Spura <tomspur(a)fedoraproject.org&gt; ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #12)
>  Links give 404. 
Sorry. It should work now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #14 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
(In reply to Thomas Spura from comment #11)
>  > If the above is true but the notebook module is to be imported
> form other
>  > packages, then keep the package split, but just include the executable in
>  > the Python 3 subpackage.
>  > 
>  > Guidelines:
>  > 
>  > If the executables provide the same functionality independent of whether
>  > they are run on top of Python 2 or Python 3, then only the Python 3 version
>  > of the executable should be packaged. Transitioning from python2 to python3
>  > is left to individual package maintainers except for packages in Fedora's
>  > critical path. For these, we want to port to python3 versions in the same
>  > Fedora release if possible.
>  
>  I removed the executable from the python2-notebook. 
Thanks. In that case, I think the mv + ln section in %install is not necessary
and providing only the unversioned executables is enough.

More importantly, running %py2_install after %py3_install is overwriting the
executables with the py2 version.

$ LANG=C.utf-8 rpm -qlvp python3-notebook-4.4.1-1.fc26.noarch.rpm | grep bin
-rwxr-xr-x 1 root root 101 Feb 14 01:01 /usr/bin/jupyter-nbextension
lrwxrwxrwx 1 root root  23 Feb 14 01:01 /usr/bin/jupyter-nbextension-3 ->
jupyter-nbextension-3.6
-rwxr-xr-x 1 root root 101 Feb 14 01:01 /usr/bin/jupyter-nbextension-3.6
-rwxr-xr-x 1 root root 100 Feb 14 01:01 /usr/bin/jupyter-notebook
lrwxrwxrwx 1 root root  20 Feb 14 01:01 /usr/bin/jupyter-notebook-3 ->
jupyter-notebook-3.6
-rwxr-xr-x 1 root root 100 Feb 14 01:01 /usr/bin/jupyter-notebook-3.6
-rwxr-xr-x 1 root root 105 Feb 14 01:01 /usr/bin/jupyter-serverextension
lrwxrwxrwx 1 root root  27 Feb 14 01:01 /usr/bin/jupyter-serverextension-3 ->
jupyter-serverextension-3.6
-rwxr-xr-x 1 root root 105 Feb 14 01:01 /usr/bin/jupyter-serverextension-3.6

$ rpm -qp --requires python3-notebook-4.4.1-1.fc26.noarch.rpm | grep bin
/usr/bin/python2
/usr/bin/python3

$ head -n1 usr/bin/jupyter-notebook
#!/usr/bin/python2 -s

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #15 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
I'm taking over here as agreed with Thomas, as he lacks time to do it.

Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-notebook.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-notebook-4.4.1-2.fc25.sr...

* Tue Feb 21 2017 Miro Hrončok <mhroncok(a)redhat.com&gt; - 4.4.1-2
- Make sure the Python 3 executables are really Python 3
- Build the docs
- Try to run tests (not yet ready)
- Use python2- where possible


Note that there are warnings when building docs:

/builddir/build/BUILD/notebook-4.4.1/docs/source/extending/contents.rst:185:
WARNING: failed to import ContentsManager.get
/builddir/build/BUILD/notebook-4.4.1/docs/source/extending/contents.rst:185:
WARNING: failed to import ContentsManager.save
/builddir/build/BUILD/notebook-4.4.1/docs/source/extending/contents.rst:185:
WARNING: failed to import ContentsManager.delete_file
/builddir/build/BUILD/notebook-4.4.1/docs/source/extending/contents.rst:185:
WARNING: failed to import ContentsManager.rename_file
/builddir/build/BUILD/notebook-4.4.1/docs/source/extending/contents.rst:185:
WARNING: failed to import ContentsManager.file_exists
/builddir/build/BUILD/notebook-4.4.1/docs/source/extending/contents.rst:185:
WARNING: failed to import ContentsManager.dir_exists
/builddir/build/BUILD/notebook-4.4.1/docs/source/extending/contents.rst:185:
WARNING: failed to import ContentsManager.is_hidden

I don't know why yet.


Also, I've tried run the tests and so far i'm failing. There's a missing
dependency that we'll package soon, but the test suite cannot locate the python
and python3 kernels. I'd appreciate help here. The tests are there, commented
out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Miro Hrončok <mhroncok(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1219662




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1219662
[Bug 1219662] Review Request: python-terminado - Terminals served to
term.js using Tornado websockets
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #16 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; ---
%description -n python3-%{pypi_name}
should also use %_description.

I'm not quite convinced about the drop of python2 executables. But they can
always be added back, so let's continue on the presumption that python2 and
python3 executables are interchangeable.

Provides: bundled(jquery)
Provides: bundled(jquery-ui)
Provides: bundled(jquery-typeahead)
Provides: bundled(mathjax)
+ a bunch of other js stuff. I don't know if it's worthwhile to unbundle those.
Maybe mathjax?

Some fonts could be unbundled easily:
Requires: fontawesome-fonts
Requires: fontawesome-fonts-web
ln -vfs /usr/share/fonts/fontawesome/fontawesome-webfont.woff
%{python3_sitepackages}/notebook/static/components/font-awesome/fonts/fontawesome-webfont.woff
etc.

loading intersphinx inventory from
http://ipython.org/ipython-doc/dev/objects.inv...
loading intersphinx inventory from
https://nbconvert.readthedocs.io/en/latest/objects.inv...
loading intersphinx inventory from
https://nbformat.readthedocs.io/en/latest/objects.inv...
loading intersphinx inventory from
https://jupyter.readthedocs.io/en/latest/objects.inv...
→ those will fail in koji. It might be worth putting those objects.inv files in
sources and installing them into the cache for the build. But that's a minor
thing, can be fixed up once the package is in.

Looks good otherwise. I'll finish the review when the tornado dep is available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #17 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; ---
python-terminado is in QA state. Miro, are you planning an update?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #18 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
Yes, I am, but I was kept busy with the testable deadline for Fedora Changes.

Will look at this sometimes during the week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Miro Hrončok <mhroncok(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |python-jupyter-notebook - A |python-notebook - A
                   |web-based notebook          |web-based notebook
                   |environment for interactive |environment for interactive
                   |computing                   |computing



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #19 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
I believe that the tests does not see the python2 and python3 kernels, because
those kernels first need to get installed with:

pythonX -m ipykernel install

(Where X is 2 and 3.)

This command shall create a directory with kernel.json in it. I believe that
python-ipykernel package shall create those directories and install them to 
/usr/share/jupyter/kernels in order to make them discoverable for our tests
here and maybe also for installed python-notebook. Another problem is that the
above command will fail with our python-ipykernel with:

    ImportError: No module named 'IPython.paths'

as our ipython is old and does not have the paths submodule yet.

I was able to generate the file from a virtualenv and it looks like this:

    {
     "argv": [
      "/home/churchyard/tmp/venv36/bin/python",
      "-m",
      "ipykernel",
      "-f",
      "{connection_file}"
     ],
     "display_name": "Python 3",
     "language": "python"
    }

I will try to modify the python-ipykernel package to install similar files for
/usr/bin/python2 and /usr/bin/python3 and see if it solves the problem.

See
https://ipython.readthedocs.io/en/latest/install/kernel_install.html#kern...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #20 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
Ok, taht fixes the problem but the tests here are throwing a lots of:

ModuleNotFoundError: No module named 'IPython.paths'

So i guess we need newer ipython anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Miro Hrončok <mhroncok(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1426799




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1426799
[Bug 1426799] ipython-5.3.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Miro Hrončok <mhroncok(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1430093




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1430093
[Bug 1430093] Package the kernel json files into python*-ipykernel
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #21 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
Idea: Backport IPython.paths.get_ipython_dir() for now to speed things up.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #22 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
That brings us to:

Traceback (most recent call last):
  File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/lib/python3.6/site-packages/ipykernel/__main__.py", line 2, in
<module>
    from ipykernel import kernelapp as app
  File "/usr/lib/python3.6/site-packages/ipykernel/kernelapp.py", line 100, in
<module>
    ConnectionFileMixin):
TypeError: metaclass conflict: the metaclass of a derived class must be a
(non-strict) subclass of the metaclasses of all its bases


That's an ipykernel class inheriting from an ipython class.

So as i thought: our ipykernel does not work without newer ipython.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #23 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
Meanwhile, I looked at the bundling:

Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-notebook.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-notebook-4.4.1-2.fc25.sr...

Ended up with:
Requires:       fontawesome-fonts
Requires:       fontawesome-fonts-web
Requires:       mathjax >= 2.4
Requires:       js-backbone >= 1.2
Requires:       js-marked >= 0.3
Requires:       js-moment >= 2.8
Requires:       js-underscore >= 1.5

# Versions from bower.json
Provides:       bundled(bootstrap) = 3.3
Provides:       bundled(bootstrap-tour) = 0.9.0
Provides:       bundled(codemirror) = 5.22.2
Provides:       bundled(es6-promise) = 1.0
Provides:       bundled(google-caja) = 5669
Provides:       bundled(jquery) = 2.0
Provides:       bundled(jquery-typeahead) = 2.0.0
Provides:       bundled(jquery-ui) = 1.10
Provides:       bundled(requirejs) = 2.1
Provides:       bundled(text-encoding) = 0.1
Provides:       bundled(xterm.js) = 2.1.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1219662, which changed state.

Bug 1219662 Summary: Review Request: python-terminado - Terminals served to term.js using
Tornado websockets
https://bugzilla.redhat.com/show_bug.cgi?id=1219662

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #24 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
With bz1426799 and bz1430093 the tests pass!

Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-notebook.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-notebook-4.4.1-2.fc25.sr...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #25 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; ---
I have neglected mathjax terribly. Great the packaged version is still OK.

+ package name is OK (I still think python-jupyter-notebook would be better,
like I said in comment #c2, but it's a bike shedding issue)
+ latest version (5.0.0b2 is tagged, but it seems better to target the stable
release)
+ %check is present and passes
+ BR/R/P are correct, afaict
+ modern python packaging template is used
+ %python_provide is present
+ builds and installs OK
+ seems to run OK
+ various stuff has been unbundled, we can unbundle more later (jquery, etc)
+ license is acceptable (3-clause BSD)
+ license is specified correctly

rpmlint:

python2-notebook.noarch: W: dangling-symlink
/usr/lib/python2.7/site-packages/notebook/static/components/MathJax
/usr/share/javascript/mathjax
python2-notebook.noarch: W: dangling-symlink
/usr/lib/python2.7/site-packages/notebook/static/components/backbone
/usr/share/javascript/backbone
python2-notebook.noarch: W: dangling-symlink
/usr/lib/python2.7/site-packages/notebook/static/components/font-awesome/fonts
/usr/share/fonts/fontawesome
python2-notebook.noarch: W: dangling-symlink
/usr/lib/python2.7/site-packages/notebook/static/components/marked/lib
/usr/share/javascript/marked
python2-notebook.noarch: W: dangling-symlink
/usr/lib/python2.7/site-packages/notebook/static/components/moment
/usr/share/javascript/moment
python2-notebook.noarch: W: dangling-symlink
/usr/lib/python2.7/site-packages/notebook/static/components/underscore
/usr/share/javascript/underscore
python3-notebook.noarch: W: dangling-symlink
/usr/lib/python3.6/site-packages/notebook/static/components/MathJax
/usr/share/javascript/mathjax
python3-notebook.noarch: W: dangling-symlink
/usr/lib/python3.6/site-packages/notebook/static/components/backbone
/usr/share/javascript/backbone
python3-notebook.noarch: W: dangling-symlink
/usr/lib/python3.6/site-packages/notebook/static/components/font-awesome/fonts
/usr/share/fonts/fontawesome
python3-notebook.noarch: W: dangling-symlink
/usr/lib/python3.6/site-packages/notebook/static/components/marked/lib
/usr/share/javascript/marked
python3-notebook.noarch: W: dangling-symlink
/usr/lib/python3.6/site-packages/notebook/static/components/moment
/usr/share/javascript/moment
python3-notebook.noarch: W: dangling-symlink
/usr/lib/python3.6/site-packages/notebook/static/components/underscore
/usr/share/javascript/underscore
Bogus, those symlinks all point to unbundled deps.

python3-notebook.noarch: W: no-manual-page-for-binary jupyter-nbextension
python3-notebook.noarch: W: no-manual-page-for-binary jupyter-notebook
python3-notebook.noarch: W: no-manual-page-for-binary jupyter-serverextension
Yeah, would be nice to add those, at least with some pointers to html docs...

python-notebook-doc.noarch: W: summary-not-capitalized C notebook documentation
"notebook" is the name, so it's OK.

3 packages and 0 specfiles checked; 0 errors, 16 warnings.

Package is APPROVED.

Two nitpicks: there's a blank line at start of %description for
python2-notebook subpackage.
The %description for python3-notebook should use %_description.

OK, let's get this pushed out and iron out any integration issues in
rawhide/F26. I this is more likely to work than trying to get everything
perfect in bugzilla attachments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #26 from Miro Hrončok <mhroncok(a)redhat.com&gt; ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #25)
>  I have neglected mathjax terribly. Great the packaged version is
> still OK. 
Still needs some smoke-testing.

>  + package name is OK (I still think python-jupyter-notebook would be
> better,
>  like I said in comment #c2, but it's a bike shedding issue) 
Let's provide
that as well maybe?

>  Two nitpicks: there's a blank line at start of %description for
>  python2-notebook subpackage.
>  The %description for python3-notebook should use %_description. 
Will change.

Thank you. Now we need to wait for the other 2 BZs.

Not to self: Will need to provide and obsolete python*-ipython-notebook.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #27 from Jon Ciesla <limburgher(a)gmail.com&gt; ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-notebook

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Miro Hrončok <mhroncok(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |python-notebook-4.4.1-2.fc2
                   |                            |7



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #28 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
python-notebook-4.4.1-2.fc26 ipython-5.3.0-2.fc26 python-ipykernel-4.5.2-6.fc26
has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #29 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
ipython-5.3.0-3.fc26, python-ipykernel-4.5.2-6.fc26,
python-notebook-4.4.1-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #30 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
ipython-5.3.0-4.fc26 python-ipykernel-4.5.2-6.fc26 python-notebook-4.4.1-3.fc26
has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #31 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
ipython-5.3.0-4.fc26, python-ipykernel-4.5.2-6.fc26,
python-notebook-4.4.1-3.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2017-04-01 13:11:29



--- Comment #32 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
ipython-5.3.0-4.fc26, python-ipykernel-4.5.2-6.fc26,
python-notebook-4.4.1-3.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1426799, which changed state.

Bug 1426799 Summary: ipython-5.3.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1426799

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1430093, which changed state.

Bug 1430093 Summary: Package the kernel json files into python*-ipykernel
https://bugzilla.redhat.com/show_bug.cgi?id=1430093

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component