[Bug 1409802] New: Review Request: python-leather - Python charting for 80% of humans

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

            Bug ID: 1409802
           Summary: Review Request: python-leather - Python charting for
                    80% of humans
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: jujens(a)jujens.eu
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org



Spec URL: http://dl.jujens.eu/SPECS/python-leather.spec
SRPM URL:
http://dl.jujens.eu/SRPMS/python-leather-0.3.3-1.gite85dd30.fc25.src.rpm

Description:
Leather is the Python charting library for those who need charts now and don’t
care if they’re perfect.

Leather isn’t picky. It’s rough. It gets dirty. It looks sexy just hanging on 
the back of a chair. Leather doesn’t need your accessories. Leather is how 
Snake Plissken would make charts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Julien Enselme <jujens(a)jujens.eu&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1431420




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1431420
[Bug 1431420] Review Request: python-agate - Data analysis library that is
optimized for humans instead of machines
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Dhanesh B. Sabane <dhanesh95(a)disroot.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dhanesh95(a)disroot.org



--- Comment #1 from Dhanesh B. Sabane <dhanesh95(a)disroot.org&gt; ---
(In reply to Julien Enselme from comment #0)
>  Spec URL: http://dl.jujens.eu/SPECS/python-leather.spec
>  SRPM URL:
>  http://dl.jujens.eu/SRPMS/python-leather-0.3.3-1.gite85dd30.fc25.src.rpm
>   
Disclaimer : I'm not a packager yet. So this is an unofficial review.

Here's what fedora-review tells me:

* Rpmlint output:

Rpmlint
-------
Checking: python2-leather-0.3.3-1.gite85dd30.fc24.noarch.rpm
          python3-leather-0.3.3-1.gite85dd30.fc24.noarch.rpm
          python-leather-doc-0.3.3-1.gite85dd30.fc24.noarch.rpm
          python-leather-0.3.3-1.gite85dd30.fc24.src.rpm
python2-leather.noarch: W: spelling-error %description -l en_US isn -> sin,
ins, ism
python2-leather.noarch: W: spelling-error %description -l en_US doesn -> does,
does n
python3-leather.noarch: W: spelling-error %description -l en_US isn -> sin,
ins, ism
python3-leather.noarch: W: spelling-error %description -l en_US doesn -> does,
does n
python-leather-doc.noarch: W: spelling-error %description -l en_US isn -> sin,
ins, ism
python-leather-doc.noarch: W: spelling-error %description -l en_US doesn ->
does, does n
python-leather-doc.noarch: W: file-not-utf8
/usr/share/doc/python-leather-doc/html/objects.inv
python-leather.src: W: spelling-error %description -l en_US isn -> sin, ins,
ism
python-leather.src: W: spelling-error %description -l en_US doesn -> does, does
n
4 packages and 0 specfiles checked; 0 errors, 9 warnings.



Rpmlint (installed packages)
----------------------------
python-leather-doc.noarch: W: spelling-error %description -l en_US isn -> sin,
ins, ism
python-leather-doc.noarch: W: spelling-error %description -l en_US doesn ->
does, does n
python-leather-doc.noarch: W: file-not-utf8
/usr/share/doc/python-leather-doc/html/objects.inv
python3-leather.noarch: W: spelling-error %description -l en_US isn -> sin,
ins, ism
python3-leather.noarch: W: spelling-error %description -l en_US doesn -> does,
does n
python2-leather.noarch: W: spelling-error %description -l en_US isn -> sin,
ins, ism
python2-leather.noarch: W: spelling-error %description -l en_US doesn -> does,
does n
3 packages and 0 specfiles checked; 0 errors, 7 warnings.

Typos.

Everything else seems good. fedora-review does throw an issue regarding the
license :

Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.txt is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

But I think this can be safely ignored. COPYING is already a part of %license.
Also, there is no file named license.txt in the source. So I don't see why this
is an issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #2 from Julien Enselme <jujens(a)jujens.eu&gt; ---
>  Disclaimer : I'm not a packager yet. So this is an unofficial
> review. 
I hope you will be soon!

>  But I think this can be safely ignored. COPYING is already a part of
> %license. Also, there is no file named license.txt in the source. 
I think this is a false positive. Some projects put their license in
license.txt others in LICENSE and others in COPYING. And the COPYING file I
include with %license is the license: BuildRequires:  python2-sphinx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #3 from Dhanesh B. Sabane <dhanesh95(a)disroot.org&gt; ---
(In reply to Julien Enselme from comment #2)
>  I hope you will be soon! 
Thanks!

>  I think this is a false positive. Some projects put their license in
>  license.txt others in LICENSE and others in COPYING. And the COPYING file I
>  include with %license is the license: BuildRequires:  python2-sphinx 
I think so too. There is a license.rst file in the source though, but from the
discussion I had on IRC with other devs tells me that it will be processed by
the make in docs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek(a)in.waw.pl



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl&gt; ---
No need to specify "BuildArch:      noarch" more than once.

Those loops ("for file in leather/*.py; do...") are not necessary, sed takes
multiple arguments.

I like minimalism, I'd also replace "pushd docs, popd" with a '-C
docs'
argument to make...

I also think the description could be a bit more down-to-earth. I *do* think
the text you have is funny, but OTOH, it doesn't say too much about the package
;)
E.g. the stuff from the documentation, "produces scale-invariant SVGs", etc, is
pretty useful.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #5 from Julien Enselme <jujens(a)jujens.eu&gt; ---
>  No need to specify "BuildArch:      noarch" more than once.
Fixed.

>  Those loops ("for file in leather/*.py; do...") are not
> necessary, sed takes multiple arguments. 
Indeed, fixed.

>  I like minimalism, I'd also replace "pushd docs, popd"
> with a '-C docs' argument to make... 
I didn't know about this option. I fine with the pushd/popd so I'll let it as
is if you are fine with it.

>  I also think the description could be a bit more down-to-earth.
Agreed. I took it from the readme. Improve with passage from the documentation
(http://leather.readthedocs.io/en/0.3.3/about.html).

Spec URL: http://dl.jujens.eu/SPECS/python-leather.spec
SRPM URL:
http://dl.jujens.eu/SRPMS/python-leather-0.3.3-2.gite85dd30.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Dhanesh B. Sabane <dhanesh95(a)disroot.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|nobody(a)fedoraproject.org    |dhanesh95(a)disroot.org



--- Comment #6 from Dhanesh B. Sabane <dhanesh95(a)disroot.org&gt; ---
(In reply to Julien Enselme from comment #5)
>  Spec URL: http://dl.jujens.eu/SPECS/python-leather.spec
>  SRPM URL:
>  http://dl.jujens.eu/SRPMS/python-leather-0.3.3-2.gite85dd30.fc25.src.rpm 
+ Package name - OK
+ Builds and installs - OK
+ License is acceptable
+ Latest version - OK
+ BuildRequires look sane
+ python macros are used
+ %python_provide is used

Package is APPROVED.


(In reply to Julien Enselme from comment #2)
>  > Disclaimer : I'm not a packager yet. So this is an
> unofficial review.
>  
>  I hope you will be soon!
>   
Thank you for your well wishes again. I'm now a packager. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Dhanesh B. Sabane <dhanesh95(a)disroot.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #7 from Julien Enselme <jujens(a)jujens.eu&gt; ---
>  Thank you for your well wishes again. I'm now a packager. :)
Thanks for the review and welcome to the club!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #8 from Gwyn Ciesla <limburgher(a)gmail.com&gt; ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-leather

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
python-leather-0.3.3-2.gite85dd30.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ceb5bfa9b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
python-leather-0.3.3-2.gite85dd30.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c04a15f2b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
python-leather-0.3.3-2.gite85dd30.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ceb5bfa9b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
python-leather-0.3.3-2.gite85dd30.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c04a15f2b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2017-03-26 04:19:29



--- Comment #13 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
python-leather-0.3.3-2.gite85dd30.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #14 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
python-leather-0.3.3-2.gite85dd30.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component