[Bug 2174763] New: Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763

            Bug ID: 2174763
           Summary: Review Request: lujavrite - Lua library for calling
                    Java code
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: mizdebsk(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Spec URL: https://mizdebsk.fedorapeople.org/review/lujavrite/lujavrite.spec
SRPM URL:
https://mizdebsk.fedorapeople.org/review/lujavrite/lujavrite-1.0.1-1.fc39...
Description: LuJavRite is a rock-solid Lua library that allows calling Java
code from Lua code. It does so by launching embedded Java Virtual Machine and
using JNI interface to invoke Java methods.
Fedora Account System Username: mizdebsk


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174763

[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763

Jakub Kadlčík <jkadlcik(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/mizdebsk
                   |                            |/lujavrite



--- Comment #1 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5586049
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174763

[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763

Marián Konček <mkoncek(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mkoncek(a)redhat.com
              Flags|                            |fedora-review?
           Assignee|nobody(a)fedoraproject.org    |mkoncek(a)redhat.com




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174763

[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763



--- Comment #2 from Mikolaj Izdebski <mizdebsk(a)redhat.com&gt; ---
Updated packages:
Spec URL: https://mizdebsk.fedorapeople.org/review/lujavrite/lujavrite.spec
SRPM URL:
https://mizdebsk.fedorapeople.org/review/lujavrite/lujavrite-1.0.2-1.fc39...


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174763

[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763



--- Comment #3 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
Created attachment 1947669
  --> https://bugzilla.redhat.com/attachment.cgi?id=1947669&action=edit
The .spec file difference from Copr build 5586049 to 5589119


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174763

[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763



--- Comment #4 from Jakub Kadlčík <jkadlcik(a)redhat.com&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5589119
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174763

[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763

Marián Konček <mkoncek(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Marián Konček <mkoncek(a)redhat.com&gt; ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License
2.0",
     "Apache License 2.0". 2 files have unknown license. Detailed output of
     licensecheck in /home/mkoncek/Work/Fedora-
     packages/lujavrite/2174763-lujavrite/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

===== NOTES =====
%check, i.e. test.sh does not contain `assert` or any other mechanism of
detecting errors but it does execute some functionality of the library but
manual review is needed


Package review passed, granting +.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2174763

[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763



--- Comment #6 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/lujavrite


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174763

[Bug 2174763] Review Request: lujavrite - Lua library for calling Java code

https://bugzilla.redhat.com/show_bug.cgi?id=2174763

Mikolaj Izdebski <mizdebsk(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |RAWHIDE
             Status|ASSIGNED                    |CLOSED
        Last Closed|                            |2023-03-03 15:13:40



--- Comment #7 from Mikolaj Izdebski <mizdebsk(a)redhat.com&gt; ---
Package was added to rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-7ae81b4ed5
Closing this review.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2174763