[Bug 2279440] New: Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

            Bug ID: 2279440
           Summary: Review Request: python-pytest-lazy-fixtures - Library
                    to use fixtures in @pytest.mark.parametrize
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: iwienand(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Spec URL:
https://iwienand.fedorapeople.org/pytest-lazy-fixtures/python-pytest-lazy...
SRPM URL:
https://iwienand.fedorapeople.org/pytest-lazy-fixtures/python-pytest-lazy...
Description: Library to use fixtures in @pytest.mark.parametrize
Fedora Account System Username: iwienand

Note this is distinct from python-pytest-lazy-fixture (no s!)
(https://packages.fedoraproject.org/pkgs/python-pytest-lazy-fixture/). 
pytest-lazy-fixtures (with the s!) supports pytest >= 8, which the original
(without the s) does not.  This package is a dependency of prettytable since
it's 3.10.0 release
(https://github.com/jazzband/prettytable/releases/tag/3.10.0)

Mock built package @
https://iwienand.fedorapeople.org/pytest-lazy-fixtures/python3-pytest-laz...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #1 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7422594
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #2 from Ian Wienand <iwienand(a)redhat.com&gt; ---
[fedora-review-service-build]


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/dev-petr
                   |                            |ov/pytest-lazy-fixtures



--- Comment #3 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7422660
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Found issues:

- License file LICENSE is not marked as %license
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidel...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #4 from Ian Wienand <iwienand(a)redhat.com&gt; ---
[fedora-review-service-build]


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #5 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; ---
Created attachment 2031790
  --> https://bugzilla.redhat.com/attachment.cgi?id=2031790&action=edit
The .spec file difference from Copr build 7422660 to 7422703


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #6 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7422703
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Found issues:

- Upstream MD5sum check error, diff is in
/var/lib/copr-rpmbuild/results/python-pytest-lazy-fixtures/diff.txt
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #7 from Ian Wienand <iwienand(a)redhat.com&gt; ---
[fedora-review-service-build]


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #8 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7422722
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #9 from Ian Wienand <iwienand(a)redhat.com&gt; ---
[fedora-review-service-build]


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #10 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt;
---
Created attachment 2031794
  --> https://bugzilla.redhat.com/attachment.cgi?id=2031794&action=edit
The .spec file difference from Copr build 7422722 to 7422770


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged



--- Comment #11 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt;
---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7422770
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Bruno Meneguele <brdeoliv(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|nobody(a)fedoraproject.org    |brdeoliv(a)redhat.com
                 CC|                            |brdeoliv(a)redhat.com




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Bruno Meneguele <brdeoliv(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #12 from Bruno Meneguele <brdeoliv(a)redhat.com&gt; ---
Package Review: PASS
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 3872 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Binary eggs must be removed in %prep
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: "spelling-error" for "parametrize" is OK, since upstream
     does call it as-is.

Rpmlint
-------
Checking: python3-pytest-lazy-fixtures-1.0.7-1.fc41.noarch.rpm
          python-pytest-lazy-fixtures-1.0.7-1.fc41.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpmxu679ot')]
checks: 32, packages: 2

python-pytest-lazy-fixtures.src: E: spelling-error ('parametrize',
'Summary(en_US) parametrize -> parameterize, parametric, parameter')
python-pytest-lazy-fixtures.src: E: spelling-error ('parametrize',
'%description -l en_US parametrize -> parameterize, parametric, parameter')
python3-pytest-lazy-fixtures.noarch: E: spelling-error ('parametrize',
'Summary(en_US) parametrize -> parameterize, parametric, parameter')
python3-pytest-lazy-fixtures.noarch: E: spelling-error ('parametrize',
'%description -l en_US parametrize -> parameterize, parametric, parameter')
 2 packages and 0 specfiles checked; 4 errors, 0 warnings, 8 filtered, 4
badness; has taken 0.3 s 

^---- THESE AREN'T ERRORS, THEY'RE OK


Rpmlint (installed packages)
----------------------------
$ rpmlint -i python3-pytest-lazy-fixtures
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

python3-pytest-lazy-fixtures.noarch: E: spelling-error ('parametrize',
'Summary(en_US) parametrize -> parameterize, parametric, parameter')
python3-pytest-lazy-fixtures.noarch: E: spelling-error ('parametrize',
'%description -l en_US parametrize -> parameterize, parametric, parameter')

^----- THESE ARE ALSO OK


Source checksums
----------------
https://files.pythonhosted.org/packages/source/p/pytest-lazy-fixtures/pyt...
:
  CHECKSUM(SHA256) this package     :
87ef7424dc0229ff9cb72d482f49b7806535c3500641f612c13ddf243c9adacb
  CHECKSUM(SHA256) upstream package :
87ef7424dc0229ff9cb72d482f49b7806535c3500641f612c13ddf243c9adacb


Requires
--------
python3-pytest-lazy-fixtures (rpmlib, GLIBC filtered):
    python(abi)
    python3.12dist(pytest)



Provides
--------
python3-pytest-lazy-fixtures:
    python-pytest-lazy-fixtures
    python3-pytest-lazy-fixtures
    python3.12-pytest-lazy-fixtures
    python3.12dist(pytest-lazy-fixtures)
    python3dist(pytest-lazy-fixtures)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Bruno Meneguele <brdeoliv(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Ian Wienand <iwienand(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|brdeoliv(a)redhat.com         |bmeneg(a)heredoc.io




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Bruno Meneguele <brdeoliv(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bmeneg(a)heredoc.io           |brdeoliv(a)redhat.com




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440



--- Comment #13 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pytest-lazy-fixtures


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2279440] Review Request: python-pytest-lazy-fixtures - Library to use fixtures in @pytest.mark.parametrize

https://bugzilla.redhat.com/show_bug.cgi?id=2279440

Ian Wienand <iwienand(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2024-05-09 01:32:12




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2279440