[Bug 448205] New: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=448205

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network
                    calculations and validation
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://www.alphatek.info/divers/php-pear-Net-IPv4.spec
SRPM URL: http://www.alphatek.info/divers/php-pear-Net-IPv4-1.3.0-1.fc9.src.rpm
Description: PHP library used for calculating IPv4 (AF_INET family) address information such as network as network address, broadcast address, and IP address.

It's my first package (with https://bugzilla.redhat.com/show_bug.cgi?id=448204), I'm looking for a sponsor.

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |177841
              nThis|                            |

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

https://bugzilla.redhat.com/show_bug.cgi?id=448205

------- Additional Comments From [e-mail]  2008-06-18 15:16 EST -------
I can't sponsor you, I'm currently in the same boat as you currently but I did
review the package.  rpmlint showed no issues except for the lack of
documentation.  I don't see any issues with the packaging.

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

https://bugzilla.redhat.com/show_bug.cgi?id=448205

------- Additional Comments From [e-mail]  2008-06-18 15:42 EST -------
There is no documentation in the upstream code, so this should be normal.

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |pear-Net-IPv4
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

------- Additional Comments From [e-mail]  2008-07-03 15:36 EST -------
New files:

Spec URL: http://www.alphatek.info/divers/php-pear-Net-IPv4.spec
SRPM URL: http://www.alphatek.info/divers/php-pear-Net-IPv4-1.3.0-2.fc9.src.rpm

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]       |[e-mail]

------- Additional Comments From [e-mail]  2008-07-13 03:42 EST -------
As agreed with Chris, i take this review and will do steven spondoring

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-07-13 11:12 EST -------
REVIEW :
* rpmlint :
W: no-documentation
* The package is named according to the Package Naming Guidelines.
* source files match upstream:
35ee77683b4fd34d7a9aa77c199b2eda  Net_IPv4-1.3.0.tgz
* The spec file name match the base package
* The package must the PHP Packaging Guidelines
* License field in the package spec file match the actual license 
* license is open source-compatible (PHP)
* latest version is being packaged.
* The spec file is written in American English
* The spec file is legible
* build in mock (F-9, noarch)
* All build dependencies are listed in BuildRequires
* no locales
* no shared library files
* package own all directories that it creates
* Package don't own files or directories already owned by other packages
* no duplicate files
* Permissions on files are set properly
* %clean section
* package consistently use macros
* The package contain code
* no documentation
* no library
* no desktop file
* %install, start with rm -rf %{buildroot}
* All filenames are valid UTF-8
* scriptlets are sane
* Final Provides ok
php-pear(Net_IPv4) = 1.3.0
php-pear-Net-IPv4 = 1.3.0-2.fc9
* Final Requires ok
/usr/bin/pear  
php-pear(PEAR)  
* install ok
* work ok, with litle test case

<?php
require ("Net/IPv4.php");
$ip = Net_IPv4::parseAddress("192.168.0.4/24");
if ($ip) print_r($ip);
else echo "failed\n";
?>

Should just change Remy to Remi in the changelog ;)

APPROVED

Please wait for you sponsoring before doing the CVS request.

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-07-14 04:07 EST -------
New Package CVS Request
=======================
Package Name: pear-Net-IPv4
Short Description: Class used for calculating IPv4 address information
Owners: moixs
Branches: F-9
InitialCC: moixs, remi
Cvsextras Commits: yes

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-07-14 12:05 EST -------
cvs done.

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

------- Additional Comments From [e-mail]  2008-07-14 13:29 EST -------
Sorry but I messed up, I used the alias instead of the real package name to
create the CVS access. Could you destroy pear-Net-IPv4 CVS and create the
following instead:

New Package CVS Request
=======================
Package Name: php-pear-Net-IPv4
Short Description: Class used for calculating IPv4 address information
Owners: moixs
Branches: F-9
InitialCC: moixs, remi
Cvsextras Commits: yes

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-07-14 16:06 EST -------
cvs done

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

------- Additional Comments From [e-mail]  2008-07-21 12:15 EST -------
php-pear-Net-IPv4-1.3.0-2.fc9 has been submitted as an update for Fedora 9

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

------- Additional Comments From [e-mail]  2008-07-23 03:17 EST -------
php-pear-Net-IPv4-1.3.0-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pear-Net-IPv4'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-6636

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

------- Additional Comments From [e-mail]  2008-07-31 21:49 EST -------
php-pear-Net-IPv4-1.3.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation
Alias: pear-Net-IPv4

https://bugzilla.redhat.com/show_bug.cgi?id=448205

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |CURRENTRELEASE
   Fixed In Version|                            |1.3.0-2.fc9

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=448205

Remi Collet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #13 from Remi Collet  2012-04-02 10:00:15 EDT ---
Taking ownership according to 
http://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Cla...

Package Change Request
======================
Package Name: php-pear-Net-IPv4
Owners: remi

[Bug 448205] Review Request: php-pear-Net-IPv4 - IPv4 network calculations and validation

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=448205

--- Comment #14 from Jon Ciesla  2012-04-02 10:09:36 EDT ---
Unretired, take ownership.