[Bug 1659709] New: Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Bug ID: 1659709
           Summary: Review Request: dymo-cups-drivers - DYMO LabelWriter
                    Drivers for CUPS
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Fedora Account System Username: kni

Spec URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/dymo-cups-dr...

SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/4214/31474214/dymo-cups-drive...

Description
------------
DYMO LabelWriter and DYMO LabelMANAGER series drivers for CUPS

RPMLint Output
--------------
$ rpmlint /var/lib/mock/fedora-29-x86_64/result/*.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #1 from Andrew Bauer  ---
There is an unofficial github repo here: 
https://github.com/matthiasbock/dymo-cups-drivers

I have taken a few patches from that repo, to fix a bug and a couple warnings.
See the specfile for details.

Updated SPEC URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/dymo-cups-dr...
Updated SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/6932/31476932/dymo-cups-drive...

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Nikola Forró  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Nikola Forró  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Nikola Forró  ---
The SRPM is no longer available.

Where does that ".5" in the version come from? AFAICS, the latest upstream
version is just "1.4.0".

Couldn't you simply use "autoreconf --force --install" in %build?

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #3 from Andrew Bauer  ---
Wow, I had no idea fedora removed scratch builds so quickly.
Unfortunately, I am unable to access all the patch files needed from my dayjob,
so I'll post a new source rpm this evening when I get home.

The official version of the tarball is 1.4.0.5 as indicated by VERSION=1.4.0.5
in configure.ac. However, the download filename is just
dymo-cups-drivers-1.4.0.tar.gz. Creating a macro called "short_version" allows
me to manage the rpm package version (and download url) in just one place in
the specfile, rather than two.

I use cmake so often these days my autotools has gone rusty. There might very
well be a more efficient way to do things in %build. 
Can you be more specific as to what you are suggesting?

Replace all these commands: 
%{__libtoolize}
%{__aclocal}
%{__autoheader}
%{__automake} --force-missing --add-missing
%{__autoconf}

with just this?

autoreconf --force --install

Or did you mean something different?

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #4 from Nikola Forró  ---
(In reply to Andrew Bauer from comment #3)
> Wow, I had no idea fedora removed scratch builds so quickly.

Yes, scratch builds only last for a week or so. You can try Copr instead.
> The official version of the tarball is 1.4.0.5 as indicated by
> VERSION=1.4.0.5 in configure.ac. However, the download filename is just
> dymo-cups-drivers-1.4.0.tar.gz. Creating a macro called "short_version"
> allows me to manage the rpm package version (and download url) in just one
> place in the specfile, rather than two.

Ok, that makes sense. But for example Debian and Ubuntu use 1.4.0.
> Replace all these commands: 
> %{__libtoolize}
> %{__aclocal}
> %{__autoheader}
> %{__automake} --force-missing --add-missing
> %{__autoconf}
>
> with just this?
>
> autoreconf --force --install
>
> Or did you mean something different?

Exactly that.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #5 from Andrew Bauer  ---
I updated the specfile to use autoreconf. Strange, there was no rpm macro for
it.

Update Specfile:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/dymo-cups-dr...

Updated source rpm:
https://copr-be.cloud.fedoraproject.org/results/kni/DymoCupsDrivers/fedora-r...

I just noticed several autotools related warnings in the build output (they
were there previously. I only now noticed the warnings):
> src/lm/Makefile.am:22: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
> src/lm/Makefile.am:26: warning: source file '../common/CupsPrintEnvironment.cpp' is in a subdirectory,
> src/lm/Makefile.am:26: but option 'subdir-objects' is disabled
> src/lm/Makefile.am:26: warning: source file '../common/Halftoning.cpp' is in a subdirectory,
> src/lm/Makefile.am:26: but option 'subdir-objects' is disabled
> src/lm/Makefile.am:26: warning: source file '../common/ErrorDiffusionHalftoning.cpp' is in a subdirectory,
> src/lm/Makefile.am:26: but option 'subdir-objects' is disabled
> src/lm/Makefile.am:26: warning: source file '../common/NonLinearLaplacianHalftoning.cpp' is in a subdirectory,
> src/lm/Makefile.am:26: but option 'subdir-objects' is disabled

If you think these are serious, I can certainly look into these. I can attest,
however, that this package works just fine as it is currently. I've been using
it on a Raspberry Pi with a Dymo 450 label printer attached for several months
now.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #6 from Nikola Forró  ---
I don't think those warnings are serious, but it would be nice to fix them.
It's not a review blocker though.

There are two license files, LICENSE and COPYING, that are identical except for
whitespace differences. I don't think it's necessary to package both of them.

/usr/lib/cups/filter, /usr/share/cups and /usr/share/cups/model directories are
owned by cups-filesystem, so this package shouldn't own them.
This should do the trick:

%files
...
%{_cups_serverbin}/filter/*
%{_datadir}/cups/model/*

Otherwise I believe the package is fine.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #7 from Andrew Bauer  ---
(In reply to Nikola Forró from comment #6)
> I don't think those warnings are serious, but it would be nice to fix them.
> It's not a review blocker though.

Done.
My anal retentive side took over and I fixed all the warnings that were
appearing in the build output.
PR sent to unofficial upstream repository:
https://github.com/matthiasbock/dymo-cups-drivers/pull/7
> There are two license files, LICENSE and COPYING, that are identical except
> for whitespace differences. I don't think it's necessary to package both of
> them.

Done.
> /usr/lib/cups/filter, /usr/share/cups and /usr/share/cups/model directories
> are owned by cups-filesystem, so this package shouldn't own them.
> This should do the trick:
>
> %files
> ...
> %{_cups_serverbin}/filter/*
> %{_datadir}/cups/model/*

Done.

Updated Spec URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/dymo-cups-dr...

Updated Source RPM:
https://copr-be.cloud.fedoraproject.org/results/kni/DymoCupsDrivers/fedora-r...

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #8 from Nikola Forró  ---
> %{_datadir}/cups/*

This still makes the package own /usr/share/cups/model directory.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #9 from Andrew Bauer  ---
Oh, right. I did not notice the specfile was missing "model" in the path name.
This has been fixed.

Updated Spec URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/dymo-cups-dr...

Updated Source RPM:
https://copr-be.cloud.fedoraproject.org/results/kni/DymoCupsDrivers/fedora-r...

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Nikola Forró  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #10 from Nikola Forró  ---
Package approved.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #11 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/dymo-cups-drivers

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #12 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-193d5d724b

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #13 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-debbd9d9a2

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #14 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-389348b102

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #15 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-389348b102

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #16 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-debbd9d9a2

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #17 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.fc29 has been pushed to the Fedora 29 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-193d5d724b

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Zdenek Dohnal  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |zonexpertconsulting@outlook
                   |                            |.com
              Flags|                            |needinfo?(zonexpertconsulti
                   |                            |[e-mail])

--- Comment #18 from Zdenek Dohnal  ---
Hi Andrew!

I'm Zdenek, maintainer of CUPS and several printer driver packages. I saw your
review request on devel list and thank you for packaging the project! I checked
the spec file and the project briefly and I would like to ask you make two
changes:

1) I checked several source files and they mention the source file can be
distributed with 'GPL version 2 or any later', so the project should have
GPLv2+ license

2) It is not defined in any FPG (since nobody wrote the chapter about it yet,
although it is used for long time...), but printer driver packages should have:

BuildRequires: python3-cups

in the spec file (see other printer driver packages, f.e. gutenprint, hplip,
foomatic-db). The part of python3-cups package, which printer drivers need, is
rpm postscript driver tag generator, which creates postscriptdriver tags based
on 1284DeviceID attribute in ppd files. These tags is used for automatic
printer driver installation.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2019-01-19 01:54:41

--- Comment #19 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #20 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.fc29 has been pushed to the Fedora 29 stable
repository. If problems still persist, please make note of it in this bug
report.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

--- Comment #21 from Fedora Update System  ---
dymo-cups-drivers-1.4.0.5-4.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

[Bug 1659709] Review Request: dymo-cups-drivers - DYMO LabelWriter Drivers for CUPS

https://bugzilla.redhat.com/show_bug.cgi?id=1659709

Andrew Bauer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(zonexpertconsulti |
                   |[e-mail])             |