https://bugzilla.redhat.com/show_bug.cgi?id=1659709
Zdenek Dohnal zdohnal@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zdohnal@redhat.com, | |zonexpertconsulting@outlook | |.com Flags| |needinfo?(zonexpertconsulti | |ng@outlook.com)
--- Comment #18 from Zdenek Dohnal zdohnal@redhat.com --- Hi Andrew!
I'm Zdenek, maintainer of CUPS and several printer driver packages. I saw your review request on devel list and thank you for packaging the project! I checked the spec file and the project briefly and I would like to ask you make two changes:
1) I checked several source files and they mention the source file can be distributed with 'GPL version 2 or any later', so the project should have GPLv2+ license
2) It is not defined in any FPG (since nobody wrote the chapter about it yet, although it is used for long time...), but printer driver packages should have:
BuildRequires: python3-cups
in the spec file (see other printer driver packages, f.e. gutenprint, hplip, foomatic-db). The part of python3-cups package, which printer drivers need, is rpm postscript driver tag generator, which creates postscriptdriver tags based on 1284DeviceID attribute in ppd files. These tags is used for automatic printer driver installation.