7:21 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
Bug ID: 1424788
Summary: Review Request: nodejs-safe-buffer - Node.js module
for a safer buffer API
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: piotr1212(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://piotrp.fedorapeople.org/nodejs-safe-buffer.spec
SRPM URL:
https://piotrp.fedorapeople.org/nodejs-safe-buffer-5.0.1-1.fc26.src.rpm
Description: Node.js module for a safer buffer API
Fedora Account System Username: piotrp
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:23 a.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
Piotr Popieluch <piotr1212(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |956806 (nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:04 a.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade(a)gmail.com
Assignee|nobody(a)fedoraproject.org |panemade(a)gmail.com
Flags| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files
have
unknown license. Detailed output of licensecheck in
/home/parag/1424788-nodejs-safe-buffer/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: nodejs-safe-buffer-5.0.1-1.fc26.noarch.rpm
nodejs-safe-buffer-5.0.1-1.fc26.src.rpm
nodejs-safe-buffer.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-safe-buffer.noarch: W: spelling-error %description -l en_US js -> dis,
ks, j
nodejs-safe-buffer.noarch: W: only-non-binary-in-usr-lib
nodejs-safe-buffer.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-safe-buffer.src: W: spelling-error %description -l en_US js -> dis, ks,
j
2 packages and 0 specfiles checked; 0 errors, 5 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
nodejs-safe-buffer.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-safe-buffer.noarch: W: spelling-error %description -l en_US js -> dis,
ks, j
nodejs-safe-buffer.noarch: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Requires
--------
nodejs-safe-buffer (rpmlib, GLIBC filtered):
nodejs(engine)
Provides
--------
nodejs-safe-buffer:
nodejs-safe-buffer
npm(safe-buffer)
Source checksums
----------------
https://github.com/feross/safe-buffer/archive/v5.0.1/nodejs-safe-buffer-5...
:
CHECKSUM(SHA256) this package :
35baea811f63bc59bdaf85ad48e4ddce28b22ef0a5a2d1665a55053c6230b2ce
CHECKSUM(SHA256) upstream package :
35baea811f63bc59bdaf85ad48e4ddce28b22ef0a5a2d1665a55053c6230b2ce
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1424788 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:05 a.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
--- Comment #2 from Parag AN(पराग) <panemade(a)gmail.com> ---
Thank you Piotr for packaging this module and helping for nodejs-got package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:46 a.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
--- Comment #3 from Jon Ciesla <limburgher(a)gmail.com> ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-safe-buffer
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:59 p.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
--- Comment #4 from Fedora Update System <updates(a)fedoraproject.org> ---
nodejs-safe-buffer-5.0.1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-da67d96119
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:59 p.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:13 p.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
Piotr Popieluch <piotr1212(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2017-02-21 15:13:30
--- Comment #5 from Piotr Popieluch <piotr1212(a)gmail.com> ---
in rawhide
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:08 p.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |ON_QA
Resolution|RAWHIDE |---
Keywords| |Reopened
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
nodejs-safe-buffer-5.0.1-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-da67d96119
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:49 p.m.
New subject: [Bug 1424788] Review Request:
nodejs-safe-buffer - Node.js module for a safer buffer API
https://bugzilla.redhat.com/show_bug.cgi?id=1424788
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed|2017-02-21 15:13:30 |2017-03-03 16:49:23
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
nodejs-safe-buffer-5.0.1-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2655
days inactive
2667
days old
package-review@lists.fedoraproject.org
9 comments
1 participants
participants (1)
-
bugzilla＠redhat.com