[Bug 1424721] New: Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721

            Bug ID: 1424721
           Summary: Review Request: php-maennchen-zipstream-php - A fast
                    and simple streaming zip file downloader for PHP
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: randy(a)electronsweatshop.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org



Spec URL: https://bowlofeggs.fedorapeople.org/php-maennchen-zipstream-php.spec
SRPM URL:
https://bowlofeggs.fedorapeople.org/php-maennchen-zipstream-php-0.4.1-1.f...
Description: A fork of pablotron's zip streaming library, a fast and simple
streaming
zip file downloader for PHP.
Fedora Account System Username: bowlofeggs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721

Remi Collet <fedora(a)famillecollet.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |fedora(a)famillecollet.com
           Assignee|nobody(a)fedoraproject.org    |fedora(a)famillecollet.com



--- Comment #1 from Remi Collet <fedora(a)famillecollet.com&gt; ---
Created attachment 1255673
  --> https://bugzilla.redhat.com/attachment.cgi?id=1255673&action=edit
phpci.log

     Note: phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017
     09:56:36 CET static analyze results

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721



--- Comment #2 from Remi Collet <fedora(a)famillecollet.com&gt; ---
Created attachment 1255674
  --> https://bugzilla.redhat.com/attachment.cgi?id=1255674&action=edit
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1424721
Buildroot used: fedora-rawhide-x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721

Remi Collet <fedora(a)famillecollet.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #3 from Remi Collet <fedora(a)famillecollet.com&gt; ---
[!]: Package complies to the Packaging Guidelines

    From PHP Guildelines
    A PSR-4 [2] compliant library would put its PHP files in
/usr/share/php/<Vendor Name> in a PSR-0 compliant tree. 

    So should be /usr/share/php/ZipStream

    BTW, as "vendor" is missing, To avoid possible conflict
    with a too generic name, I'm fine with :

        /usr/share/php/maennchen/ZipStream
        /usr/share/php/maennchen/zipstream-php

    => Packager choice.

[!]: Requires correct, justified where necessary.

    From composer.json

    "require": {
        "php": ">= 5.6",
        "ext-mbstring": "*"
    },
    From phpcompatinfo report

    Requires PHP 5.3.0 (min), PHP 5.3.0 (all)

    This usually means upstream don't want to support EOL PHP version.
    => packager choise

    Do you need it in EPEL ? (build ok en epel-6 and epel-7)



Tips:

--bootstrap is not needed when the value in already defined in phpunit.xml
--no-coverage avoid the "Error: No code coverage driver is available" (but
requires phpunit > 4)


No blocker, please just confirm PHP minimal version you want to support and
file location.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721



--- Comment #4 from Randy Barlow <randy(a)electronsweatshop.com&gt; ---
(In reply to Remi Collet from comment #3)
>  [!]: Package complies to the Packaging Guidelines
>  
>  	From PHP Guildelines
>  	A PSR-4 [2] compliant library would put its PHP files in
>  /usr/share/php/<Vendor Name> in a PSR-0 compliant tree. 
>  
>  	So should be /usr/share/php/ZipStream 
Hello Remi!

Oh I didn't realize that the string "ZipStream" inside the
composer.json's psr
section was a clue about where the package should be installed. I assumed that
the vendor from packagist should be used. Now I understand better, thanks! I've
opted to go with ZipStream as you suggested above. If we hit a conflict later,
we can fix it at that time I believe.

>  [!]: Requires correct, justified where necessary.
>  
>  	From composer.json
>  
>  	"require": {
>  		"php": ">= 5.6",
>  		"ext-mbstring": "*"
>  	},
>  	From phpcompatinfo report
>  
>  	Requires PHP 5.3.0 (min), PHP 5.3.0 (all)
>  
>  	This usually means upstream don't want to support EOL PHP version.
>  	=> packager choise
>  
>  	Do you need it in EPEL ? (build ok en epel-6 and epel-7) 
I've updated it to be 5.6 to reflect upstream's wishes. I don't plan to put
Ampache into EPEL 6 or 7 at this time, so this package doesn't need to go there
either (but I'm willing to add it later if requested).

>  Tips:
>  
>  --bootstrap is not needed when the value in already defined in phpunit.xml
>  --no-coverage avoid the "Error: No code coverage driver is available" (but
>  requires phpunit > 4) 
I've made both of these changes as well. New files here:

Spec URL: https://bowlofeggs.fedorapeople.org/php-maennchen-zipstream-php.spec
SRPM URL:
https://bowlofeggs.fedorapeople.org/php-maennchen-zipstream-php-0.4.1-2.f...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721

Remi Collet <fedora(a)famillecollet.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Remi Collet <fedora(a)famillecollet.com&gt; ---
-%{_datadir}/php/maennchen
+%{_datadir}/php/ZipStream

[x]: Package complies to the Packaging Guidelines

-Requires:   php(language) >= 5.3.0
+Requires:   php(language) >= 5.6.0

[x]: Requires correct, justified where necessary.


=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721



--- Comment #6 from Jon Ciesla <limburgher(a)gmail.com&gt; ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-maennchen-zipstrea...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721



--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
php-maennchen-zipstream-php-0.4.1-2.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9280fac9c0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721

Randy Barlow <randy(a)electronsweatshop.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |php-maennchen-zipstream-php
                   |                            |-0.4.1-2.fc26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721



--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
php-maennchen-zipstream-php-0.4.1-2.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2d576b8eb4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721



--- Comment #9 from Remi Collet <fedora(a)famillecollet.com&gt; ---
Damn, I miss, this package must be "noarch"

Please fix before pushing to repo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721



--- Comment #10 from Remi Collet <fedora(a)famillecollet.com&gt; ---
Forget, and sorry for the noise

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
php-maennchen-zipstream-php-0.4.1-2.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2d576b8eb4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721



--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
php-maennchen-zipstream-php-0.4.1-2.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9280fac9c0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1424721] Review Request: php-maennchen-zipstream-php - A fast and simple streaming zip file downloader for PHP

https://bugzilla.redhat.com/show_bug.cgi?id=1424721

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2017-03-03 16:49:28



--- Comment #13 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
php-maennchen-zipstream-php-0.4.1-2.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component