Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: php-gettext - Gettext emulation in php
https://bugzilla.redhat.com/show_bug.cgi?id=544821
Summary: Review Request: php-gettext - Gettext emulation in php Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: david@gnsa.us QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://ke4qqq.fedorapeople.org/php-gettext.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-gettext-1.0.9-1.fc12.src.rpm Description: This library provides PHP functions to read MO files even when gettext is not compiled in or when appropriate locale is not present on the system.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #1 from David Nalley david@gnsa.us 2009-12-06 12:32:40 EDT --- Incorrect license specified:
Spec URL: http://ke4qqq.fedorapeople.org/php-gettext.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-gettext-1.0.9-2.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
Felix Kaechele felix@fetzig.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |felix@fetzig.org AssignedTo|nobody@fedoraproject.org |felix@fetzig.org Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #2 from Felix Kaechele felix@fetzig.org 2009-12-06 12:43:41 EDT --- Fresh review from FUDCon Toronto Room A:
[+] source files match upstream: [felix@delta SPECS]$ sha256sum php-gettext-1.0.9.tar.gz ../SOURCES/php-gettext-1.0.9.tar.gz b3aac9dd13971cabd2474cc93abfc665752f1f732646f4c911928b4323a70319 php-gettext-1.0.9.tar.gz b3aac9dd13971cabd2474cc93abfc665752f1f732646f4c911928b4323a70319 ../SOURCES/php-gettext-1.0.9.tar.gz [+] package meets naming and versioning guidelines. [+] spec is properly named, cleanly written, and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible. [+] license text included in package. [+] latest version is being packaged. [NA] BuildRequires are proper. [NA] compiler flags are appropriate. [+] %clean is present. [+] package builds in mock. [+] package installs properly. [NA] debuginfo package looks complete. [+] rpmlint is silent. [+] final provides and requires are sane [NA] %check is present and all tests pass: [+] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [NA] scriptlets match those on ScriptletSnippets page. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no headers. [+] no pkgconfig files. [NA] no libtool .la droppings. [NA] desktop files valid and installed properly.
APPROVED!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
Felix Kaechele felix@fetzig.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
David Nalley david@gnsa.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from David Nalley david@gnsa.us 2009-12-06 12:50:10 EDT --- Thanks for the review, Felix!!!
New Package CVS Request ======================= Package Name: php-gettext Short Description: Gettext emulation in php Owners: ke4qqq Branches: F-11, F-12, EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2009-12-06 18:20:53 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2009-12-06 23:17:16 EDT --- php-gettext-1.0.9-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/php-gettext-1.0.9-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-12-06 23:17:21 EDT --- php-gettext-1.0.9-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-gettext-1.0.9-2.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-12-06 23:17:26 EDT --- php-gettext-1.0.9-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-gettext-1.0.9-2.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-12-08 02:43:45 EDT --- php-gettext-1.0.9-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-gettext'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12876
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-12-08 02:47:38 EDT --- php-gettext-1.0.9-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-gettext'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12903
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-12-09 23:00:45 EDT --- php-gettext-1.0.9-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-gettext'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0984
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
Eric Christensen eric@christensenplace.us changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@christensenplace.us Blocks| |508817
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-02-01 20:16:10 EST --- php-gettext-1.0.9-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |1.0.9-2.fc11 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-02-01 20:18:49 EST --- php-gettext-1.0.9-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.0.9-2.fc11 |1.0.9-2.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544821
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-07-31 17:23:21 EDT --- php-gettext-1.0.11-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php-gettext-1.0.11-1.el5
package-review@lists.fedoraproject.org