[Bug 226285] Merge Review: perl-XML-Grove
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226285
Stepan Kasal <skasal(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #12 from Stepan Kasal <skasal(a)redhat.com> 2008-10-14 06:56:43 EDT ---
(In reply to comment #11)
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#NonNumericRelease
As mentioned in comment #10, I'm convinced the non-standard version tag should
stay in this case.
> - source matches upstream FAIL -> source at upstream is in tar.gz format
Fixed in release 34.
> - no unnecessary BR FAIL
> [...]
> Please fix the source and useless dependency.
??? BuildRequires: perl-libxml-perl perl(ExtUtils::MakeMaker)
I see no problem here.
(In reply to comment #10)
> perl-XML-Grove.noarch: E: useless-explicit-provides perl(XML::Grove)
> This package provides 2 times the same capacity. It should only provide it
> once.
No explicit provides.
Both "perl(XML::Grove)" and "perl(XML::Grove) = 0.46" are generated.
It might be a bug in rpmlint or the dependency generator, but not in this
package.
> perl-XML-Grove.noarch: W: doc-file-dependency
> /usr/share/doc/perl-XML-Grove-0.46alpha/examples/my-html.pl
> perl(XML::Parser::PerlSAX)
> An included file marked as %doc creates a possible additional dependency in
> the package. Usually, this is not wanted and may be caused by eg. example
> scripts with executable bits set included in the package's documentation.
>
> (the latter is repeated twice)
Again, these are bogus. The *.pl files in doc do not have their executable bit
set, and the require "perl(XML::Parser::PerlSAX)" is justified by other *.pm
files in the package.
To sum up, the review passed.
Several issues about rpmlint and/or the dependency generator are due to be
filed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 6 months
Broken dependencies in EPEL - 2008-10-13
by Fedora Koji Build System
Your following packages in the repository suffer from broken dependencies:
======================================================================
The results in this summary consider Test Updates!
======================================================================
package: amavisd-new - 2.4.5-1.el5.noarch from fedora-epel-5-ppc
unresolved deps:
perl(Archive::Zip)
package: cpanspec - 1.77-1.el5.noarch from fedora-epel-5-ppc
unresolved deps:
perl(Archive::Zip)
package: perl-CPANPLUS - 0.82-1.el5.noarch from fedora-epel-testing-5-ppc
unresolved deps:
perl(Package::Constants)
15 years, 6 months
Broken dependencies in EPEL - 2008-10-13
by Fedora Koji Build System
Your following packages in the repository suffer from broken dependencies:
======================================================================
The results in this summary consider Test Updates!
======================================================================
package: perl-CPANPLUS - 0.82-1.el5.noarch from fedora-epel-testing-5-x86_64
unresolved deps:
perl(Package::Constants)
15 years, 6 months
Broken dependencies in EPEL - 2008-10-13
by Fedora Koji Build System
Your following packages in the repository suffer from broken dependencies:
======================================================================
The results in this summary consider Test Updates!
======================================================================
package: perl-CPANPLUS - 0.82-1.el5.noarch from fedora-epel-testing-5-i386
unresolved deps:
perl(Package::Constants)
15 years, 6 months
rpms/perl-IO-Socket-SSL/devel .cvsignore, 1.11, 1.12 perl-IO-Socket-SSL.spec, 1.14, 1.15 sources, 1.11, 1.12
by Paul Howarth
Author: pghmcfc
Update of /cvs/pkgs/rpms/perl-IO-Socket-SSL/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv23178
Modified Files:
.cvsignore perl-IO-Socket-SSL.spec sources
Log Message:
Update to latest upstream version: 1.17
Index: .cvsignore
===================================================================
RCS file: /cvs/pkgs/rpms/perl-IO-Socket-SSL/devel/.cvsignore,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- .cvsignore 22 Sep 2008 09:26:31 -0000 1.11
+++ .cvsignore 13 Oct 2008 16:23:05 -0000 1.12
@@ -1 +1 @@
-IO-Socket-SSL-1.16.tar.gz
+IO-Socket-SSL-1.17.tar.gz
Index: perl-IO-Socket-SSL.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-IO-Socket-SSL/devel/perl-IO-Socket-SSL.spec,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- perl-IO-Socket-SSL.spec 22 Sep 2008 09:26:31 -0000 1.14
+++ perl-IO-Socket-SSL.spec 13 Oct 2008 16:23:05 -0000 1.15
@@ -4,7 +4,7 @@
#
Name: perl-IO-Socket-SSL
-Version: 1.16
+Version: 1.17
Release: 1%{?dist}
Summary: Perl library for transparent SSL
Group: Development/Libraries
@@ -60,6 +60,9 @@
%{_mandir}/man3/*.3*
%changelog
+* Mon Oct 13 2008 Paul Howarth <paul(a)city-fan.org> - 1.17-1
+- Update to latest upstream version: 1.17
+
* Mon Sep 22 2008 Paul Howarth <paul(a)city-fan.org> - 1.16-1
- Update to latest upstream version: 1.16
Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/perl-IO-Socket-SSL/devel/sources,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- sources 22 Sep 2008 09:26:31 -0000 1.11
+++ sources 13 Oct 2008 16:23:05 -0000 1.12
@@ -1 +1 @@
-9dbd4e23bdf1aaaf3c263015f1a43a42 IO-Socket-SSL-1.16.tar.gz
+6bbc8d3a0645d789734511665b3c524e IO-Socket-SSL-1.17.tar.gz
15 years, 6 months
rpms/perl-JSON/F-9 perl-JSON.spec,1.8,1.9 sources,1.7,1.8
by Chris Weyl
Author: cweyl
Update of /cvs/extras/rpms/perl-JSON/F-9
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv12888
Modified Files:
perl-JSON.spec sources
Log Message:
* Sun Oct 12 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 2.12-1
- update to 2.12
Index: perl-JSON.spec
===================================================================
RCS file: /cvs/extras/rpms/perl-JSON/F-9/perl-JSON.spec,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- perl-JSON.spec 10 Mar 2008 03:19:50 -0000 1.8
+++ perl-JSON.spec 13 Oct 2008 04:28:59 -0000 1.9
@@ -1,5 +1,5 @@
Name: perl-JSON
-Version: 2.07
+Version: 2.12
Release: 1%{?dist}
Summary: Parse and convert to JSON (JavaScript Object Notation)
License: GPL+ or Artistic
@@ -78,6 +78,15 @@
%{_mandir}/man3/*
%changelog
+* Sun Oct 12 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 2.12-1
+- update to 2.12
+
+* Wed Jun 25 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 2.11-1
+- update to 2.11
+
+* Wed May 28 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 2.09-1
+- update to 2.09
+
* Sun Mar 09 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 2.07-1
- update to 2.x series before F9
Index: sources
===================================================================
RCS file: /cvs/extras/rpms/perl-JSON/F-9/sources,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- sources 10 Mar 2008 03:19:50 -0000 1.7
+++ sources 13 Oct 2008 04:28:59 -0000 1.8
@@ -1 +1 @@
-1ca7b2851f1a8e835eec46d013da8a2b JSON-2.07.tar.gz
+5719ba98f607003295d99952c2ac2ea7 JSON-2.12.tar.gz
15 years, 6 months
rpms/perl-JSON/devel .cvsignore, 1.8, 1.9 perl-JSON.spec, 1.9, 1.10 sources, 1.8, 1.9
by Chris Weyl
Author: cweyl
Update of /cvs/extras/rpms/perl-JSON/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv11867
Modified Files:
.cvsignore perl-JSON.spec sources
Log Message:
* Sun Oct 12 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 2.12-1
- update to 2.12
Index: .cvsignore
===================================================================
RCS file: /cvs/extras/rpms/perl-JSON/devel/.cvsignore,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- .cvsignore 26 Jun 2008 03:03:42 -0000 1.8
+++ .cvsignore 13 Oct 2008 04:26:45 -0000 1.9
@@ -1 +1 @@
-JSON-2.11.tar.gz
+JSON-2.12.tar.gz
Index: perl-JSON.spec
===================================================================
RCS file: /cvs/extras/rpms/perl-JSON/devel/perl-JSON.spec,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- perl-JSON.spec 26 Jun 2008 03:03:42 -0000 1.9
+++ perl-JSON.spec 13 Oct 2008 04:26:45 -0000 1.10
@@ -1,5 +1,5 @@
Name: perl-JSON
-Version: 2.11
+Version: 2.12
Release: 1%{?dist}
Summary: Parse and convert to JSON (JavaScript Object Notation)
License: GPL+ or Artistic
@@ -78,6 +78,9 @@
%{_mandir}/man3/*
%changelog
+* Sun Oct 12 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 2.12-1
+- update to 2.12
+
* Wed Jun 25 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 2.11-1
- update to 2.11
Index: sources
===================================================================
RCS file: /cvs/extras/rpms/perl-JSON/devel/sources,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- sources 26 Jun 2008 03:03:42 -0000 1.8
+++ sources 13 Oct 2008 04:26:45 -0000 1.9
@@ -1 +1 @@
-80c23fa3332f644274b7ec83cb86cbfd JSON-2.11.tar.gz
+5719ba98f607003295d99952c2ac2ea7 JSON-2.12.tar.gz
15 years, 6 months
rpms/perl-MooseX-Types/F-9 import.log, NONE, 1.1 perl-MooseX-Types.spec, NONE, 1.1 sources, 1.1, 1.2
by Chris Weyl
Author: cweyl
Update of /cvs/extras/rpms/perl-MooseX-Types/F-9
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv5306
Modified Files:
sources
Added Files:
import.log perl-MooseX-Types.spec
Log Message:
pseudo-branch of perl-MooseX-Types to F-9
--- NEW FILE import.log ---
perl-MooseX-Types-0_04-1_fc9:HEAD:perl-MooseX-Types-0.04-1.fc9.src.rpm:1223870375
--- NEW FILE perl-MooseX-Types.spec ---
Name: perl-MooseX-Types
Version: 0.04
Release: 2%{?dist}
# see Makefile.PL, lib/MooseX/Types.pm
License: GPL+ or Artistic
Group: Development/Libraries
Summary: Organise your Moose types in libraries
Source: http://search.cpan.org/CPAN/authors/id/P/PH/PHAYLON/MooseX-Types-%{versio...
Url: http://search.cpan.org/dist/MooseX-Types
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
BuildArch: noarch
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Carp)
BuildRequires: perl(Carp::Clan)
BuildRequires: perl(Class::MOP)
BuildRequires: perl(FindBin)
BuildRequires: perl(Moose) >= 0.24
BuildRequires: perl(namespace::clean) >= 0.04
BuildRequires: perl(Sub::Install) >= 0.922
BuildRequires: perl(Sub::Uplevel) >= 0.14
BuildRequires: perl(Test::More) >= 0.62
%description
The types provided with the Moose manpage are by design global. This
package helps you to organise and selectively import your own and the
built-in types in libraries. As a nice side effect, it catches typos at
compile-time too.
However, the main reason for this module is to provide an easy way to not
have conflicts with your type names, since the internal fully qualified
names of the types will be prefixed with the library's name.
This module will also provide you with some helper functions to make it
easier to use Moose types in your code.
%prep
%setup -q -n MooseX-Types-%{version}
# make sure doc/tests don't generate provides
cat << \EOF > %{name}-prov
#!/bin/sh
%{__perl_provides} `perl -p -e 's|\S+%{_docdir}/%{name}-%{version}\S+||'`
EOF
%define __perl_provides %{_builddir}/MooseX-Types-%{version}/%{name}-prov
chmod +x %{__perl_provides}
cat << \EOF > %{name}-req
#!/bin/sh
%{__perl_requires} `perl -p -e 's|\S+%{_docdir}/%{name}-%{version}\S+||'`
EOF
%define __perl_requires %{_builddir}/MooseX-Types-%{version}/%{name}-req
chmod +x %{__perl_requires}
%build
%{__perl} Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
rm -rf %{buildroot}
make pure_install PERL_INSTALL_ROOT=%{buildroot}
find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
%{_fixperms} %{buildroot}/*
%check
make test
%clean
rm -rf %{buildroot}
%files
%defattr(-,root,root,-)
%doc Changes README t/
%{perl_vendorlib}/*
%{_mandir}/man3/*.3*
%changelog
* Sun Oct 12 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 0.04-2
- bump
* Tue Oct 07 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 0.04-1
- initial RPM packaging
- generated with cpan2dist (CPANPLUS::Dist::RPM version 0.0.1)
Index: sources
===================================================================
RCS file: /cvs/extras/rpms/perl-MooseX-Types/F-9/sources,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- sources 13 Oct 2008 02:14:26 -0000 1.1
+++ sources 13 Oct 2008 04:07:16 -0000 1.2
@@ -0,0 +1 @@
+f8ac0ad1bb431a3dfae25e5ade184619 MooseX-Types-0.04.tar.gz
15 years, 6 months
rpms/perl-MooseX-Types/F-8 import.log, NONE, 1.1 perl-MooseX-Types.spec, NONE, 1.1 sources, 1.1, 1.2
by Chris Weyl
Author: cweyl
Update of /cvs/extras/rpms/perl-MooseX-Types/F-8
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv3694
Modified Files:
sources
Added Files:
import.log perl-MooseX-Types.spec
Log Message:
pseudo-branch of perl-MooseX-Types to F-8
--- NEW FILE import.log ---
perl-MooseX-Types-0_04-1_fc9:HEAD:perl-MooseX-Types-0.04-1.fc9.src.rpm:1223870375
--- NEW FILE perl-MooseX-Types.spec ---
Name: perl-MooseX-Types
Version: 0.04
Release: 2%{?dist}
# see Makefile.PL, lib/MooseX/Types.pm
License: GPL+ or Artistic
Group: Development/Libraries
Summary: Organise your Moose types in libraries
Source: http://search.cpan.org/CPAN/authors/id/P/PH/PHAYLON/MooseX-Types-%{versio...
Url: http://search.cpan.org/dist/MooseX-Types
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
BuildArch: noarch
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Carp)
BuildRequires: perl(Carp::Clan)
BuildRequires: perl(Class::MOP)
BuildRequires: perl(FindBin)
BuildRequires: perl(Moose) >= 0.24
BuildRequires: perl(namespace::clean) >= 0.04
BuildRequires: perl(Sub::Install) >= 0.922
BuildRequires: perl(Sub::Uplevel) >= 0.14
BuildRequires: perl(Test::More) >= 0.62
%description
The types provided with the Moose manpage are by design global. This
package helps you to organise and selectively import your own and the
built-in types in libraries. As a nice side effect, it catches typos at
compile-time too.
However, the main reason for this module is to provide an easy way to not
have conflicts with your type names, since the internal fully qualified
names of the types will be prefixed with the library's name.
This module will also provide you with some helper functions to make it
easier to use Moose types in your code.
%prep
%setup -q -n MooseX-Types-%{version}
# make sure doc/tests don't generate provides
cat << \EOF > %{name}-prov
#!/bin/sh
%{__perl_provides} `perl -p -e 's|\S+%{_docdir}/%{name}-%{version}\S+||'`
EOF
%define __perl_provides %{_builddir}/MooseX-Types-%{version}/%{name}-prov
chmod +x %{__perl_provides}
cat << \EOF > %{name}-req
#!/bin/sh
%{__perl_requires} `perl -p -e 's|\S+%{_docdir}/%{name}-%{version}\S+||'`
EOF
%define __perl_requires %{_builddir}/MooseX-Types-%{version}/%{name}-req
chmod +x %{__perl_requires}
%build
%{__perl} Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
rm -rf %{buildroot}
make pure_install PERL_INSTALL_ROOT=%{buildroot}
find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
%{_fixperms} %{buildroot}/*
%check
make test
%clean
rm -rf %{buildroot}
%files
%defattr(-,root,root,-)
%doc Changes README t/
%{perl_vendorlib}/*
%{_mandir}/man3/*.3*
%changelog
* Sun Oct 12 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 0.04-2
- bump
* Tue Oct 07 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 0.04-1
- initial RPM packaging
- generated with cpan2dist (CPANPLUS::Dist::RPM version 0.0.1)
Index: sources
===================================================================
RCS file: /cvs/extras/rpms/perl-MooseX-Types/F-8/sources,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- sources 13 Oct 2008 02:14:26 -0000 1.1
+++ sources 13 Oct 2008 04:02:36 -0000 1.2
@@ -0,0 +1 @@
+f8ac0ad1bb431a3dfae25e5ade184619 MooseX-Types-0.04.tar.gz
15 years, 6 months
