[Bug 475242] Review Request: perl-Data-Dump-Streamer - Accurately serialize a data structure as Perl code
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=475242
manuel wolfshant <wolfy(a)nobugconsulting.ro> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #4 from manuel wolfshant <wolfy(a)nobugconsulting.ro> 2008-12-09 04:32:41 EDT ---
Package Review
==============
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: devel/x86_64
[x] Rpmlint output:
source RPM: empty
binary RPM:empty
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
SHA1SUM of package: b66764af72e14918367207b70d3097a868da74d8
Data-Dump-Streamer-2.08-40.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: koji scratch build + devel/x86_64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: koji scratch build + devel/x86_64
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the tests pass.
[x] Final provides and requires are sane.
================
*** APPROVED ***
================
Note: leaving as only comment in %changelog the bits left by an automatic
script, even after you review and modify the spec is a tiny bit misleading...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 6 months
rpms/perl-Alien-wxWidgets/devel .cvsignore, 1.12, 1.13 perl-Alien-wxWidgets.spec, 1.18, 1.19 sources, 1.12, 1.13
by Tom Callaway
Author: spot
Update of /cvs/pkgs/rpms/perl-Alien-wxWidgets/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv710/devel
Modified Files:
.cvsignore perl-Alien-wxWidgets.spec sources
Log Message:
0.42
Index: .cvsignore
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Alien-wxWidgets/devel/.cvsignore,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- .cvsignore 28 Nov 2007 18:25:56 -0000 1.12
+++ .cvsignore 8 Dec 2008 21:18:58 -0000 1.13
@@ -1 +1 @@
-Alien-wxWidgets-0.32.tar.gz
+Alien-wxWidgets-0.42.tar.gz
Index: perl-Alien-wxWidgets.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Alien-wxWidgets/devel/perl-Alien-wxWidgets.spec,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- perl-Alien-wxWidgets.spec 3 Mar 2008 20:31:33 -0000 1.18
+++ perl-Alien-wxWidgets.spec 8 Dec 2008 21:18:58 -0000 1.19
@@ -1,6 +1,6 @@
Name: perl-Alien-wxWidgets
-Version: 0.32
-Release: 4%{?dist}
+Version: 0.42
+Release: 1%{?dist}
Summary: Building, finding and using wxWidgets binaries
Group: Development/Libraries
@@ -55,6 +55,9 @@
%changelog
+* Mon Dec 8 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.42-1
+- 0.42
+
* Wed Feb 27 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.32-4
- Rebuild for perl 5.10 (again)
Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Alien-wxWidgets/devel/sources,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- sources 28 Nov 2007 18:25:56 -0000 1.12
+++ sources 8 Dec 2008 21:18:58 -0000 1.13
@@ -1 +1 @@
-534164c7b1f9c0d60397a689ffa90cb4 Alien-wxWidgets-0.32.tar.gz
+f96c09d393bc8b4cbd7ff8e412183032 Alien-wxWidgets-0.42.tar.gz
15 years, 6 months
rpms/perl-Alien-wxWidgets/F-10 perl-Alien-wxWidgets.spec, 1.18, 1.19 sources, 1.12, 1.13
by Tom Callaway
Author: spot
Update of /cvs/pkgs/rpms/perl-Alien-wxWidgets/F-10
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv710/F-10
Modified Files:
perl-Alien-wxWidgets.spec sources
Log Message:
0.42
Index: perl-Alien-wxWidgets.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Alien-wxWidgets/F-10/perl-Alien-wxWidgets.spec,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- perl-Alien-wxWidgets.spec 3 Mar 2008 20:31:33 -0000 1.18
+++ perl-Alien-wxWidgets.spec 8 Dec 2008 21:18:57 -0000 1.19
@@ -1,6 +1,6 @@
Name: perl-Alien-wxWidgets
-Version: 0.32
-Release: 4%{?dist}
+Version: 0.42
+Release: 1%{?dist}
Summary: Building, finding and using wxWidgets binaries
Group: Development/Libraries
@@ -55,6 +55,9 @@
%changelog
+* Mon Dec 8 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.42-1
+- 0.42
+
* Wed Feb 27 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.32-4
- Rebuild for perl 5.10 (again)
Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Alien-wxWidgets/F-10/sources,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- sources 28 Nov 2007 18:25:56 -0000 1.12
+++ sources 8 Dec 2008 21:18:57 -0000 1.13
@@ -1 +1 @@
-534164c7b1f9c0d60397a689ffa90cb4 Alien-wxWidgets-0.32.tar.gz
+f96c09d393bc8b4cbd7ff8e412183032 Alien-wxWidgets-0.42.tar.gz
15 years, 6 months
rpms/perl-Alien-wxWidgets/F-9 perl-Alien-wxWidgets.spec, 1.18, 1.19 sources, 1.12, 1.13
by Tom Callaway
Author: spot
Update of /cvs/pkgs/rpms/perl-Alien-wxWidgets/F-9
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv710/F-9
Modified Files:
perl-Alien-wxWidgets.spec sources
Log Message:
0.42
Index: perl-Alien-wxWidgets.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Alien-wxWidgets/F-9/perl-Alien-wxWidgets.spec,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- perl-Alien-wxWidgets.spec 3 Mar 2008 20:31:33 -0000 1.18
+++ perl-Alien-wxWidgets.spec 8 Dec 2008 21:18:58 -0000 1.19
@@ -1,6 +1,6 @@
Name: perl-Alien-wxWidgets
-Version: 0.32
-Release: 4%{?dist}
+Version: 0.42
+Release: 1%{?dist}
Summary: Building, finding and using wxWidgets binaries
Group: Development/Libraries
@@ -55,6 +55,9 @@
%changelog
+* Mon Dec 8 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.42-1
+- 0.42
+
* Wed Feb 27 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.32-4
- Rebuild for perl 5.10 (again)
Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Alien-wxWidgets/F-9/sources,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- sources 28 Nov 2007 18:25:56 -0000 1.12
+++ sources 8 Dec 2008 21:18:58 -0000 1.13
@@ -1 +1 @@
-534164c7b1f9c0d60397a689ffa90cb4 Alien-wxWidgets-0.32.tar.gz
+f96c09d393bc8b4cbd7ff8e412183032 Alien-wxWidgets-0.42.tar.gz
15 years, 6 months
rpms/perl-Wx/devel .cvsignore, 1.18, 1.19 perl-Wx.spec, 1.23, 1.24 sources, 1.18, 1.19
by Tom Callaway
Author: spot
Update of /cvs/pkgs/rpms/perl-Wx/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv27344/devel
Modified Files:
.cvsignore perl-Wx.spec sources
Log Message:
update to 0.89
Index: .cvsignore
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Wx/devel/.cvsignore,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- .cvsignore 4 Mar 2008 21:23:16 -0000 1.18
+++ .cvsignore 8 Dec 2008 20:48:43 -0000 1.19
@@ -1 +1 @@
-Wx-0.81.tar.gz
+Wx-0.89.tar.gz
Index: perl-Wx.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Wx/devel/perl-Wx.spec,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- perl-Wx.spec 4 Mar 2008 21:23:16 -0000 1.23
+++ perl-Wx.spec 8 Dec 2008 20:48:43 -0000 1.24
@@ -5,7 +5,7 @@
#
Name: perl-Wx
-Version: 0.81
+Version: 0.89
Release: 1%{?dist}
Summary: Interface to the wxWidgets cross-platform GUI toolkit
@@ -17,7 +17,10 @@
BuildRequires: wxGTK-devel
BuildRequires: perl(Alien::wxWidgets) >= 0.25
+BuildRequires: perl(Data::Dumper)
+BuildRequires: perl(ExtUtils::MakeMaker) >= 6.21
BuildRequires: perl(Module::Info)
+BuildRequires: perl(Test::More), perl(Test::Harness)
BuildRequires: perl(Test::Pod)
BuildRequires: perl(YAML) >= 0.35
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
@@ -55,7 +58,7 @@
chmod +x %{__perl_requires}
%build
-%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version` --wx-toolkit=gtk2 INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
+%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version | cut -d . -f 1-2` --wx-toolkit=gtk2 INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
@@ -79,7 +82,7 @@
%files
%defattr(-,root,root,-)
%doc Changes README.txt docs/todo.txt wxpl.ico wxpl.xpm
-%doc run samples/
+%doc samples/
%{_bindir}/*
%{perl_vendorarch}/Wx*
%{perl_vendorarch}/auto/Wx/
@@ -88,6 +91,9 @@
%changelog
+* Mon Dec 8 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.89-1
+- 0.89
+
* Tue Mar 4 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.81-1
- 0.81
- minor packaging cleanups
Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Wx/devel/sources,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- sources 4 Mar 2008 21:23:16 -0000 1.18
+++ sources 8 Dec 2008 20:48:43 -0000 1.19
@@ -1 +1 @@
-3b39d839f358380bb50c665b887b93a6 Wx-0.81.tar.gz
+6f7c8bb0bca7746feaff344770bf670b Wx-0.89.tar.gz
15 years, 6 months
rpms/perl-Wx/F-9 perl-Wx.spec,1.23,1.24 sources,1.18,1.19
by Tom Callaway
Author: spot
Update of /cvs/pkgs/rpms/perl-Wx/F-9
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv27344/F-9
Modified Files:
perl-Wx.spec sources
Log Message:
update to 0.89
Index: perl-Wx.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Wx/F-9/perl-Wx.spec,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- perl-Wx.spec 4 Mar 2008 21:23:16 -0000 1.23
+++ perl-Wx.spec 8 Dec 2008 20:48:42 -0000 1.24
@@ -5,7 +5,7 @@
#
Name: perl-Wx
-Version: 0.81
+Version: 0.89
Release: 1%{?dist}
Summary: Interface to the wxWidgets cross-platform GUI toolkit
@@ -17,7 +17,10 @@
BuildRequires: wxGTK-devel
BuildRequires: perl(Alien::wxWidgets) >= 0.25
+BuildRequires: perl(Data::Dumper)
+BuildRequires: perl(ExtUtils::MakeMaker) >= 6.21
BuildRequires: perl(Module::Info)
+BuildRequires: perl(Test::More), perl(Test::Harness)
BuildRequires: perl(Test::Pod)
BuildRequires: perl(YAML) >= 0.35
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
@@ -55,7 +58,7 @@
chmod +x %{__perl_requires}
%build
-%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version` --wx-toolkit=gtk2 INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
+%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version | cut -d . -f 1-2` --wx-toolkit=gtk2 INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
@@ -79,7 +82,7 @@
%files
%defattr(-,root,root,-)
%doc Changes README.txt docs/todo.txt wxpl.ico wxpl.xpm
-%doc run samples/
+%doc samples/
%{_bindir}/*
%{perl_vendorarch}/Wx*
%{perl_vendorarch}/auto/Wx/
@@ -88,6 +91,9 @@
%changelog
+* Mon Dec 8 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.89-1
+- 0.89
+
* Tue Mar 4 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 0.81-1
- 0.81
- minor packaging cleanups
Index: sources
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Wx/F-9/sources,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- sources 4 Mar 2008 21:23:16 -0000 1.18
+++ sources 8 Dec 2008 20:48:42 -0000 1.19
@@ -1 +1 @@
-3b39d839f358380bb50c665b887b93a6 Wx-0.81.tar.gz
+6f7c8bb0bca7746feaff344770bf670b Wx-0.89.tar.gz
15 years, 6 months