rpms/perl-Perl-Critic/F-9 perl-Perl-Critic.spec, 1.16, 1.17 sources, 1.10, 1.11
by Chris Weyl
Author: cweyl
Update of /cvs/extras/rpms/perl-Perl-Critic/F-9
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv27699
Modified Files:
perl-Perl-Critic.spec sources
Log Message:
* Sun Mar 09 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 1.082-1
- update to 1.082
- resolve BZ#431577
- add t/ examples/ extras/ tools/, and filter
Index: perl-Perl-Critic.spec
===================================================================
RCS file: /cvs/extras/rpms/perl-Perl-Critic/F-9/perl-Perl-Critic.spec,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- perl-Perl-Critic.spec 28 Feb 2008 13:01:55 -0000 1.16
+++ perl-Perl-Critic.spec 1 Jul 2008 03:58:44 -0000 1.17
@@ -1,15 +1,17 @@
Name: perl-Perl-Critic
-Version: 1.080
-Release: 3%{?dist}
+Version: 1.082
+Release: 1%{?dist}
Summary: Critique Perl source code for best-practices
Group: Development/Libraries
License: GPL+ or Artistic
URL: http://search.cpan.org/dist/Perl-Critic/
Source0: http://www.cpan.org/authors/id/T/TH/THALJEF/perlcritic/Perl-Critic-%{vers...
+Source0: http://www.cpan.org/modules/by-module/Perl/Perl-Critic-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-
BuildArch: noarch
+Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+
BuildRequires: perl(Module::Build)
BuildRequires: perl(B::Keywords) >= 1.05
BuildRequires: perl(Config::Tiny) >= 2
@@ -17,12 +19,12 @@
BuildRequires: perl(IO::String)
BuildRequires: perl(List::MoreUtils)
BuildRequires: perl(Module::Pluggable) >= 3.1
-BuildRequires: perl(PPI) >= 1.118
+BuildRequires: perl(PPI) >= 1.201
BuildRequires: perl(String::Format) >= 1.13
BuildRequires: perl(Perl::Tidy)
BuildRequires: perl(Test::Memory::Cycle)
-BuildRequires: perl(Readonly::XS)
-BuildRequires: perl(Exception::Class)
+BuildRequires: perl(Readonly) >= 1.03
+BuildRequires: perl(Exception::Class) >= 1.23
# BuildRequires: perl(Regexp::Parser)
# Author tests
#BuildRequires: perl(Test::Perl::Critic)
@@ -32,7 +34,7 @@
BuildRequires: perl(Test::Spelling)
BuildRequires: perl(Test::Pod)
BuildRequires: perl(Test::Pod::Coverage)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+
Requires: perl(Module::Pluggable) >= 3.1
Requires(hint): perl(Perl::Tidy)
@@ -51,6 +53,18 @@
%prep
%setup -q -n Perl-Critic-%{version}
+find . -type f -exec chmod -c -x {} +
+
+# make sure doc/tests don't generate provides
+# note we first filter out the bits in _docdir...
+cat << \EOF > %{name}-prov
+#!/bin/sh
+FOO=`perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
+%{__perl_provides} $FOO
+EOF
+
+%define __perl_provides %{_builddir}/Perl-Critic-%{version}/%{name}-prov
+chmod +x %{__perl_provides}
%build
%{__perl} Build.PL installdirs=vendor
@@ -60,13 +74,14 @@
%install
rm -rf $RPM_BUILD_ROOT
./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-chmod -R u+w $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT/*
%check
# Additional requirements of author tests:
# Test::Perl::Critic, Test::Kwalitee
-TEST_AUTHOR=1 ./Build test
+#TEST_AUTHOR=1 ./Build test
+./Build test
%clean
@@ -75,7 +90,7 @@
%files
%defattr(-,root,root,-)
-%doc Changes LICENSE README TODO.pod
+%doc Changes LICENSE README TODO.pod examples/ extras/ tools/
%{_bindir}/*
%{perl_vendorlib}/Perl/
%{_mandir}/man1/*.1*
@@ -83,6 +98,11 @@
%changelog
+* Sun Mar 09 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 1.082-1
+- update to 1.082
+- resolve BZ#431577
+- add t/ examples/ extras/ tools/, and filter
+
* Wed Feb 27 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 1.080-3
- Rebuild for perl 5.10 (again)
Index: sources
===================================================================
RCS file: /cvs/extras/rpms/perl-Perl-Critic/F-9/sources,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- sources 14 Jan 2008 23:32:59 -0000 1.10
+++ sources 1 Jul 2008 03:58:44 -0000 1.11
@@ -1 +1 @@
-a094cce997e96954b7fc7c21f1e91cc2 Perl-Critic-1.080.tar.gz
+f2ad44e084444b42f1b59b0f2f3bb387 Perl-Critic-1.082.tar.gz
15 years, 10 months
[Bug 431577] New: Build fails depending on current locale
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=431577
Summary: Build fails depending on current locale
Product: Fedora
Version: 8
Platform: All
OS/Version: Linux
Status: NEW
Severity: low
Priority: low
Component: perl-Perl-Critic
AssignedTo: cweyl(a)alumni.drew.edu
ReportedBy: ed(a)membled.com
QAContact: extras-qa(a)fedoraproject.org
CC: fedora-perl-devel-list(a)redhat.com
Building perl-Perl-Critic from the source package fails if your locale is not
en_US. Fix it by changing line 66 of the spec file to
LC_ALL=en_US.UTF-8 TEST_AUTHOR=1 ./Build test
However, I think you should consider turning off TEST_AUTHOR; it is intended for
the author's own tests, after all. Newer versions of Perl::Critic on CPAN fail
some author tests.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
15 years, 10 months
rpms/perl-Perl-Critic/devel .cvsignore, 1.10, 1.11 perl-Perl-Critic.spec, 1.16, 1.17 sources, 1.10, 1.11
by Chris Weyl
Author: cweyl
Update of /cvs/extras/rpms/perl-Perl-Critic/devel
In directory cvs-int.fedora.redhat.com:/tmp/cvs-serv27354
Modified Files:
.cvsignore perl-Perl-Critic.spec sources
Log Message:
* Sun Mar 09 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 1.082-1
- update to 1.082
- resolve BZ#431577
- add t/ examples/ extras/ tools/, and filter
Index: .cvsignore
===================================================================
RCS file: /cvs/extras/rpms/perl-Perl-Critic/devel/.cvsignore,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- .cvsignore 14 Jan 2008 23:32:59 -0000 1.10
+++ .cvsignore 1 Jul 2008 03:41:41 -0000 1.11
@@ -1 +1 @@
-Perl-Critic-1.080.tar.gz
+Perl-Critic-1.082.tar.gz
Index: perl-Perl-Critic.spec
===================================================================
RCS file: /cvs/extras/rpms/perl-Perl-Critic/devel/perl-Perl-Critic.spec,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- perl-Perl-Critic.spec 28 Feb 2008 13:01:55 -0000 1.16
+++ perl-Perl-Critic.spec 1 Jul 2008 03:41:41 -0000 1.17
@@ -1,15 +1,17 @@
Name: perl-Perl-Critic
-Version: 1.080
-Release: 3%{?dist}
+Version: 1.082
+Release: 1%{?dist}
Summary: Critique Perl source code for best-practices
Group: Development/Libraries
License: GPL+ or Artistic
URL: http://search.cpan.org/dist/Perl-Critic/
Source0: http://www.cpan.org/authors/id/T/TH/THALJEF/perlcritic/Perl-Critic-%{vers...
+Source0: http://www.cpan.org/modules/by-module/Perl/Perl-Critic-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-
BuildArch: noarch
+Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+
BuildRequires: perl(Module::Build)
BuildRequires: perl(B::Keywords) >= 1.05
BuildRequires: perl(Config::Tiny) >= 2
@@ -17,12 +19,12 @@
BuildRequires: perl(IO::String)
BuildRequires: perl(List::MoreUtils)
BuildRequires: perl(Module::Pluggable) >= 3.1
-BuildRequires: perl(PPI) >= 1.118
+BuildRequires: perl(PPI) >= 1.201
BuildRequires: perl(String::Format) >= 1.13
BuildRequires: perl(Perl::Tidy)
BuildRequires: perl(Test::Memory::Cycle)
-BuildRequires: perl(Readonly::XS)
-BuildRequires: perl(Exception::Class)
+BuildRequires: perl(Readonly) >= 1.03
+BuildRequires: perl(Exception::Class) >= 1.23
# BuildRequires: perl(Regexp::Parser)
# Author tests
#BuildRequires: perl(Test::Perl::Critic)
@@ -32,7 +34,7 @@
BuildRequires: perl(Test::Spelling)
BuildRequires: perl(Test::Pod)
BuildRequires: perl(Test::Pod::Coverage)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+
Requires: perl(Module::Pluggable) >= 3.1
Requires(hint): perl(Perl::Tidy)
@@ -51,6 +53,18 @@
%prep
%setup -q -n Perl-Critic-%{version}
+find . -type f -exec chmod -c -x {} +
+
+# make sure doc/tests don't generate provides
+# note we first filter out the bits in _docdir...
+cat << \EOF > %{name}-prov
+#!/bin/sh
+FOO=`perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
+%{__perl_provides} $FOO
+EOF
+
+%define __perl_provides %{_builddir}/Perl-Critic-%{version}/%{name}-prov
+chmod +x %{__perl_provides}
%build
%{__perl} Build.PL installdirs=vendor
@@ -60,13 +74,14 @@
%install
rm -rf $RPM_BUILD_ROOT
./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-chmod -R u+w $RPM_BUILD_ROOT/*
+%{_fixperms} $RPM_BUILD_ROOT/*
%check
# Additional requirements of author tests:
# Test::Perl::Critic, Test::Kwalitee
-TEST_AUTHOR=1 ./Build test
+#TEST_AUTHOR=1 ./Build test
+./Build test
%clean
@@ -75,7 +90,7 @@
%files
%defattr(-,root,root,-)
-%doc Changes LICENSE README TODO.pod
+%doc Changes LICENSE README TODO.pod examples/ extras/ tools/
%{_bindir}/*
%{perl_vendorlib}/Perl/
%{_mandir}/man1/*.1*
@@ -83,6 +98,11 @@
%changelog
+* Sun Mar 09 2008 Chris Weyl <cweyl(a)alumni.drew.edu> 1.082-1
+- update to 1.082
+- resolve BZ#431577
+- add t/ examples/ extras/ tools/, and filter
+
* Wed Feb 27 2008 Tom "spot" Callaway <tcallawa(a)redhat.com> - 1.080-3
- Rebuild for perl 5.10 (again)
Index: sources
===================================================================
RCS file: /cvs/extras/rpms/perl-Perl-Critic/devel/sources,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- sources 14 Jan 2008 23:32:59 -0000 1.10
+++ sources 1 Jul 2008 03:41:41 -0000 1.11
@@ -1 +1 @@
-a094cce997e96954b7fc7c21f1e91cc2 Perl-Critic-1.080.tar.gz
+f2ad44e084444b42f1b59b0f2f3bb387 Perl-Critic-1.082.tar.gz
15 years, 10 months