[Bug 1852437] New: perl-Perl-Critic-1.138-4.fc33 FTBFS with Perl 5.32: subroutine name is a homonym for builtin function isa at line 140

https://bugzilla.redhat.com/show_bug.cgi?id=1852437

            Bug ID: 1852437
           Summary: perl-Perl-Critic-1.138-4.fc33 FTBFS with Perl 5.32:
                    subroutine name is a homonym for builtin function isa
                    at line 140
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: perl-Perl-Critic
          Assignee: paul(a)city-fan.org
          Reporter: ppisar(a)redhat.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: jose.p.oliveira.oss(a)gmail.com, paul(a)city-fan.org,
                    perl-devel(a)lists.fedoraproject.org,
                    rob.myers(a)gtri.gatech.edu
            Blocks: 1803234 (F33FTBFS)
  Target Milestone: ---
           Link ID: Github Perl-Critic/Perl-Critic/issues/911
    Classification: Fedora



perl-Perl-Critic-1.138-4.fc33 fails to build in Fedora 33 because a test fails
with Perl 5.32:

t/gh-734.t .................................... ok
#   Failed test 'Test::Perl::Critic for
"blib/lib/Perl/Critic/Document.pm"'
#   at /usr/share/perl5/vendor_perl/Test/Perl/Critic.pm line 121.
# 
#   blib/lib/Perl/Critic/Document.pm: Subroutine name is a homonym for builtin
function isa at line 140, column 1.  See page 177 of PBP.  (Severity: 4,
Subroutines::ProhibitBuiltinHomonyms)
xt/40_criticize-code.t ........................ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/198 subtests



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1803234
[Bug 1803234] (F33FTBFS) - Fedora 33 FTBFS Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1852437] perl-Perl-Critic-1.138-4.fc33 FTBFS with Perl 5.32: subroutine name is a homonym for builtin function isa at line 140

https://bugzilla.redhat.com/show_bug.cgi?id=1852437



--- Comment #1 from Paul Howarth <paul(a)city-fan.org&gt; ---
As "isa" is a documented part of Perl::Critic::Document's API, I suspect
that
the fix for this will just be to add a ##nocritic pragma to waive the check.


-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1852437] perl-Perl-Critic-1.138-4.fc33 FTBFS with Perl 5.32: subroutine name is a homonym for builtin function isa at line 140

https://bugzilla.redhat.com/show_bug.cgi?id=1852437

Paul Howarth <paul(a)city-fan.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
   Fixed In Version|                            |perl-Perl-Critic-1.138-5.fc
                   |                            |33
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2020-07-11 17:54:10



--- Comment #2 from Paul Howarth <paul(a)city-fan.org&gt; ---
I worked around this using a "## nocritic" pragma, but the long-term fix might
be to include making "isa" a special case like "import",
"AUTOLOAD", and
"DESTROY" already are, as they are commonly overridden. That's one for
upstream
to decide though.


-- 
You are receiving this mail because:
You are on the CC list for the bug.