rpms/perl-Wx/devel perl-Wx.spec,1.27,1.28

[Marcela Mašláňová]

Author: mmaslano

Update of /cvs/pkgs/rpms/perl-Wx/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv22957

Modified Files:
    perl-Wx.spec 
Log Message:
* Mon Jun 29 2009 Marcela Mašláňová  - 0.91-3
- remove RPM_OPT_FLAGS which create message: undefined symbol: Perl_Guse_safe_putenv_ptr
- Resolves: rhbz#508496

Index: perl-Wx.spec
===================================================================
RCS file: /cvs/pkgs/rpms/perl-Wx/devel/perl-Wx.spec,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -p -r1.27 -r1.28
--- perl-Wx.spec	19 Jun 2009 21:43:09 -0000	1.27
+++ perl-Wx.spec	29 Jun 2009 14:15:01 -0000	1.28
@@ -6,7 +6,7 @@

Name:           perl-Wx
 Version:        0.91
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Interface to the wxWidgets cross-platform GUI toolkit

Group:          Development/Libraries
@@ -58,7 +58,7 @@ __EOF__
 chmod +x %{__perl_requires}

%build
-%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version | cut -d . -f 1-2` --wx-toolkit=gtk2 INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
+%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version | cut -d . -f 1-2` --wx-toolkit=gtk2 INSTALLDIRS=vendor
 make %{?_smp_mflags}

@@ -91,6 +91,10 @@ rm -rf $RPM_BUILD_ROOT

%changelog
+* Mon Jun 29 2009 Marcela Mašláňová  - 0.91-3
+- remove RPM_OPT_FLAGS which create message: undefined symbol: Perl_Guse_safe_putenv_ptr
+- Resolves: rhbz#508496
+
 * Fri Jun 19 2009 Stepan Kasal  - 0.91-2
 - rebuild

[Ralf Corsepius]

Marcela Mašláňová wrote:
> Author: mmaslano
>
> Update of /cvs/pkgs/rpms/perl-Wx/devel
> In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv22957
>
> Modified Files:
>    perl-Wx.spec 
> Log Message:
> Mon Jun 29 2009 Marcela Mašláňová  - 0.91-3
> remove RPM_OPT_FLAGS which create message: undefined symbol: Perl_Guse_safe_putenv_ptr
> Resolves: rhbz#508496
> Index: perl-Wx.spec
>
> RCS file: /cvs/pkgs/rpms/perl-Wx/devel/perl-Wx.spec,v
> retrieving revision 1.27
> retrieving revision 1.28
> diff -u -p -r1.27 -r1.28
> --- perl-Wx.spec	19 Jun 2009 21:43:09 -0000	1.27
> +++ perl-Wx.spec	29 Jun 2009 14:15:01 -0000	1.28
> @@ -6,7 +6,7 @@
>
> Name:           perl-Wx
>  Version:        0.91
> -Release:        2%{?dist}
> +Release:        3%{?dist}
>  Summary:        Interface to the wxWidgets cross-platform GUI toolkit
>
> Group:          Development/Libraries
> @@ -58,7 +58,7 @@ __EOF__
>  chmod +x %{__perl_requires}
>
> %build
> -%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version | cut -d . -f 1-2` --wx-toolkit=gtk2 INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
> +%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version | cut -d . -f 1-2` --wx-toolkit=gtk2 INSTALLDIRS=vendor
>  make %{?_smp_mflags}
>
> @@ -91,6 +91,10 @@ rm -rf $RPM_BUILD_ROOT
>
> %changelog
> +* Mon Jun 29 2009 Marcela Mašláňová  - 0.91-3
> +- remove RPM_OPT_FLAGS which create message: undefined symbol: Perl_Guse_safe_putenv_ptr
> +- Resolves: rhbz#508496

Marcella, this change is as wrong as change can be.

You must not take out RPM_OPT_FLAGS, but to dive into the issues 
RPM_OPT_FLAGS might trigger!

Ralf

[Marcela Mašláňová]

On 06/29/2009 04:33 PM, Ralf Corsepius wrote:
> Marcela Mašláňová wrote:
> > Author: mmaslano
> >
> > Update of /cvs/pkgs/rpms/perl-Wx/devel
> > In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv22957
> >
> > Modified Files:
> > perl-Wx.spec Log Message:
> > Mon Jun 29 2009 Marcela Mašláňová  - 0.91-3
> > remove RPM_OPT_FLAGS which create message: undefined symbol:
> >
> > Perl_Guse_safe_putenv_ptr
> > Resolves: rhbz#508496
> > Index: perl-Wx.spec
> >
> > RCS file: /cvs/pkgs/rpms/perl-Wx/devel/perl-Wx.spec,v
> > retrieving revision 1.27
> > retrieving revision 1.28
> > diff -u -p -r1.27 -r1.28
> > --- perl-Wx.spec 19 Jun 2009 21:43:09 -0000 1.27
> > +++ perl-Wx.spec 29 Jun 2009 14:15:01 -0000 1.28
> > @@ -6,7 +6,7 @@
> >
> > Name: perl-Wx
> > Version: 0.91
> > -Release: 2%{?dist}
> > +Release: 3%{?dist}
> > Summary: Interface to the wxWidgets cross-platform GUI toolkit
> >
> > Group: Development/Libraries
> > @@ -58,7 +58,7 @@ __EOF__
> > chmod +x %{__perl_requires}
> >
> > %build
> > -%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version
> > | cut -d . -f 1-2` --wx-toolkit=gtk2 INSTALLDIRS=vendor
> > OPTIMIZE="$RPM_OPT_FLAGS"
> > +%{__perl} Makefile.PL --wx-unicode --wx-version=`wx-config --version
> > | cut -d . -f 1-2` --wx-toolkit=gtk2 INSTALLDIRS=vendor
> > make %{?_smp_mflags}
> >
> > @@ -91,6 +91,10 @@ rm -rf $RPM_BUILD_ROOT
> >
> > %changelog
> > +* Mon Jun 29 2009 Marcela Mašláňová  - 0.91-3
> > +- remove RPM_OPT_FLAGS which create message: undefined symbol:
> > Perl_Guse_safe_putenv_ptr
> > +- Resolves: rhbz#508496
>
> Marcella, this change is as wrong as change can be.

It's not Italien name.
> You must not take out RPM_OPT_FLAGS, but to dive into the issues
> RPM_OPT_FLAGS might trigger!

Is it better to have broken package instead because our strict rules? 
This was only "meantime" fix. Feel free to dive in, it looks like a lot 
of work if you'd also check the build.
> Ralf

Best regards,