https://bugzilla.redhat.com/show_bug.cgi?id=1080246
Bug ID: 1080246 Summary: packaging issues Product: Fedora Version: rawhide Component: t-prot Assignee: emmanuel@seyman.fr Reporter: cickumqt@gmail.com QA Contact: extras-qa@fedoraproject.org CC: emmanuel@seyman.fr, perl-devel@lists.fedoraproject.org
Hi,
Here are some issues found in spec:
Quoted from spec:
%build
%install install -d $RPM_BUILD_ROOT%{_bindir} install t-prot $RPM_BUILD_ROOT%{_bindir}
install -d $RPM_BUILD_ROOT%{_mandir}/man1/ install -m 644 t-prot.1 $RPM_BUILD_ROOT%{_mandir}/man1/ gzip -f $RPM_BUILD_ROOT%{_mandir}/man1/t-prot.1
%files %doc ChangeLog TODO README contrib %{_bindir}/t-prot %{_mandir}/man1/t-prot.1.gz
Issues:
1. Add a comment at %build like "Empty build"
2. install t-prot $RPM_BUILD_ROOT%{_bindir}
Missing -p and -m755.
3. install -m 644 t-prot.1 $RPM_BUILD_ROOT%{_mandir}/man1/
Missing -p.
4. gzip -f $RPM_BUILD_ROOT%{_mandir}/man1/t-prot.1
You shouldn't do that. RPM will do this.
If you want RPM to compress it, leave the item in %files from currently-used
%{_mandir}/man1/t-prot.1.gz
to
%{_mandir}/man1/t-prot.1*
------------------------------------------------------ Please fix above all issues in git, you can build it as -2 but you can also wait the f21 mass rebuild.
Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1080246
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2014-03-25 02:33:31
--- Comment #1 from Emmanuel Seyman emmanuel@seyman.fr --- Fixed. Thanks for the report.
https://bugzilla.redhat.com/show_bug.cgi?id=1080246
--- Comment #2 from Michael Schwendt bugs.michael@gmx.net ---
- Add a comment at %build like "Empty build"
What is the rationale?
An empty %build section is self-explanatory. Not even a missing %build section would be a real mistake, but it's recommended to add it in such a case.
https://bugzilla.redhat.com/show_bug.cgi?id=1080246
--- Comment #3 from Christopher Meng cickumqt@gmail.com --- (In reply to Michael Schwendt from comment #2)
- Add a comment at %build like "Empty build"
What is the rationale?
An empty %build section is self-explanatory. Not even a missing %build section would be a real mistake, but it's recommended to add it in such a case.
I realized that I should put it as suggestion after I clicked the Save Changes button.
https://bugzilla.redhat.com/show_bug.cgi?id=1080246
--- Comment #4 from Michael Schwendt bugs.michael@gmx.net --- Again, it doesn't make sense to echo 'something "Empty build"' in %build.
If at all, someone who knows what "%build" is would recognize the empty section in the spec file and ask "Huh? _Why_ isn't anything built for this package?". So, if you wanted to add a useful comment, be explicit about why %build is empty, which likely implies pointing out whether the package is noarch.
perl-devel@lists.fedoraproject.org