On Tue, Jun 26, 2012 at 11:20:30AM -0700, Toshio Kuratomi wrote:
On Tue, Jun 26, 2012 at 01:08:02PM -0400, Ralph Bean wrote:
> On Mon, Jun 25, 2012 at 10:39:48PM -0700, Toshio Kuratomi wrote:
>
> Here's my list of updated patches (including a rename of my original).
> I kept them separated out instead of rebasing just to preserve
> history and make them easier to cherry-pick.
>
>
http://threebean.org/patches/python-bugzilla/0001-Python3-support.patch
>
http://threebean.org/patches/python-bugzilla/0002-Replace-str-foo-with-si...
>
http://threebean.org/patches/python-bugzilla/0003-Rewrite-two-loops-as-on...
>
http://threebean.org/patches/python-bugzilla/0004-Regression-fix.patch
>
http://threebean.org/patches/python-bugzilla/0005-Always-return-bytestrin...
>
These look good to me.
> > * Needs python-2.6 or greater (as python-2.5 doesn't have from __future__
> > import print_function, the new format of "except Foo as bar:", and
> > relative imports)
>
> This is correct. Can anyone comment on what python versions
> python-bugzilla is required to support? EPEL6 is on python-2.6 now.
>
So this question and whether adding the dep on python-six is okay are the
questions that need answering.
It has been over a month, so I'm bumping this discussion.
I understand in retrospect that I introduced a patch that could
potentially destabilize python-bugzilla thus giving everybody
nightmares after the BZ upgrade earlier in the Summer.
I think this work maintains all the backwards compatibility it can,
with exceptions to what Toshio has raised: no more python-2.5 and a
new dependency on python-six.
Someday, python2 will be unmaintained. We won't be able to start
porting things to python3 that depend on python-bugzilla until it
itself is ported. Better to get a head start.