On 10/16/2013 10:15 AM, Arun Neelicattu wrote:
Hi Cole,
I misunderstood, just assumed you wanted a single py2 to py3 commit. I can do the split
over the weekend hopefully.
Great, thanks a lot.
.gitignore changes: ack
setup.py changes: i think setuptools should handle it, will test further and see what I
can do to make it less 'hacky'.
tests/rw_functional.py refactoring: this was since the tests (original and new) raised
Fault as the test user did not have privileges to change the priority/severity and this
was uncaught. Just figured it was cleaner/extensible with the refactor. Do you want me to
leave it as is? Or just add a generic try/except with a generic failure message around
that block?
Hmm. I'm probably the only one that has ever run most of those tests, but I'm
surprised changing severity/priority raised an error and the rest of the suite
didn't. Double check that you can still reproduce (with cached login
credentials), but if it's still an issue I'm fine with the current code, just
add a short comment about it.
Thanks,
Cole